From: "NeilBrown" <neilb@suse.de>
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] NFS: fix minor issues with automount expiry.
Date: Wed, 28 Jul 2021 09:15:31 +1000 [thread overview]
Message-ID: <162742773175.21659.17666555162574585184@noble.neil.brown.name> (raw)
1/ If automount expiry timeout is set to zero, new mounts are not added
to the list. If the timeout is then changed, those previously
mounts will still not be timed out. This is probably not what
would be expected. Simply refusing to start the timer
is sufficient to prevent timeout.
2/ the MODULE_PARM_DESC for nfs_mountpoint_expiry_timeout is missing
a space between to two sentences. This is hidden by the fact that
the string is broken onto to line - against current policy.
So join onto a single (long) line, and add the space.
Signed-off-by: NeilBrown <neilb@suse.de>
---
fs/nfs/namespace.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c
index bc0c698f3350..be5e77a80811 100644
--- a/fs/nfs/namespace.c
+++ b/fs/nfs/namespace.c
@@ -196,10 +196,10 @@ struct vfsmount *nfs_d_automount(struct path *path)
goto out_fc;
mntget(mnt); /* prevent immediate expiration */
+ mnt_set_expiry(mnt, &nfs_automount_list);
if (timeout <= 0)
goto out_fc;
- mnt_set_expiry(mnt, &nfs_automount_list);
schedule_delayed_work(&nfs_automount_task, timeout);
out_fc:
@@ -366,5 +366,4 @@ static const struct kernel_param_ops param_ops_nfs_timeout = {
module_param(nfs_mountpoint_expiry_timeout, nfs_timeout, 0644);
MODULE_PARM_DESC(nfs_mountpoint_expiry_timeout,
- "Set the NFS automounted mountpoint timeout value (seconds)."
- "Values <= 0 turn expiration off.");
+ "Set the NFS automounted mountpoint timeout value (seconds). Values <= 0 turn expiration off.");
--
2.32.0
next reply other threads:[~2021-07-27 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 23:15 NeilBrown [this message]
2021-10-04 2:38 ` [PATCH] NFS: fix minor issues with automount expiry Trond Myklebust
2021-10-04 23:52 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162742773175.21659.17666555162574585184@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.