From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E3BC432BE for ; Wed, 28 Jul 2021 01:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC08160C3E for ; Wed, 28 Jul 2021 01:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234516AbhG1BfL (ORCPT ); Tue, 27 Jul 2021 21:35:11 -0400 Received: from mailgw01.mediatek.com ([60.244.123.138]:42372 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S234015AbhG1BfJ (ORCPT ); Tue, 27 Jul 2021 21:35:09 -0400 X-UUID: 83ffc371ee0242f1a9a5e03b4eae63e0-20210728 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=tystcQCeK1JokSJpr3jNYbyoX8+NJdw5MNRuzT9Nl1s=; b=B5YTcTWL9N2Ccfi/OHpSmHeQ1b5DSpNGkjNIucKMFWfNzier6BvpJ/OC9il7NL3B1NQCPxjNGQXCW/WBvxH/c0kJv8QuGKkvSn7x024/8rJD8bSMUJFrkBNlpLXaBwnQhuMB2iSh92KC0Hcv0bLiz67/4HtV0FlyXwJ4I3krgP8=; X-UUID: 83ffc371ee0242f1a9a5e03b4eae63e0-20210728 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2004428482; Wed, 28 Jul 2021 09:35:05 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Jul 2021 09:35:05 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 28 Jul 2021 09:35:03 +0800 Message-ID: <1627436103.31194.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] phy: introduce phy mode PHY_MODE_UART and phy_get_mode_ext() From: Chunfeng Yun To: Macpaul Lin CC: , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , Ainge Hsu , Eddie Hung , Kuohong Wang , Mediatek WSD Upstream , Macpaul Lin , , , , Date: Wed, 28 Jul 2021 09:35:03 +0800 In-Reply-To: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> References: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVHVlLCAyMDIxLTA3LTI3IGF0IDE4OjUwICswODAwLCBNYWNwYXVsIExpbiB3cm90ZToNCj4g U29tZSBlbWJlZGRlZCBwbGF0Zm9ybSBzaGFyZWQgUElOcyBiZXR3ZWVuIFVTQiBhbmQgVUFSVC4N Cj4gDQo+IEZvciBleGFtcGxlLCBzb21lIHBob25lIHdpbGwgdXNlIHNwZWNpYWwgY2FibGUgZGV0 ZWN0aW9uIGluIGJvb3QgbG9hZGVyDQo+IHRvIHN3aXRjaCBVU0IgcG9ydCBmdW5jdGlvbiBpbnRv IFVBUlQgbW9kZS4gSGVuY2UgS2VybmVsIG5lZWQgdG8gcXVlcnkNCj4gdGhlIGhhcmR3YXJlIHN0 YXRlIGZyb20gUEhZIHJlZ2lzdGVycyB0byBjb25maXJtIHRoZSBpbml0aWFsemF0aW9uIGZsb3cN Cj4gZm9yIFBIWSBhbmQgVVNCIGRyaXZlci4NCj4gDQo+IFRvIHN1cHBvcnQgdGhpcyBraW5kIG9m IFBJTiBzd2l0Y2gsIG5ldyBQSFkgTU9ERSBhbmQgcXVlcnkgQVBJIGlzDQo+IHJlcXVpcmVkLiBI ZXJlIHdlIGludHJvZHVjZSBhIG5ldyBQSFkgbW9kZTogUEhZX01PREVfVUFSVC4NCj4gDQo+IEFQ SSBwaHlfZ2V0X21vZGVfZXh0KCkgY2FuIGJlIHVzZWQgdG8gcXVlcnkgdGhlIE1PREUgZnJvbSBo YXJkd2FyZQ0KPiBpbnN0ZWFkIG9mIHJlYWRpbmcgaXQgZnJvbSBwaHkgYXR0cmlidXRlcy4NCj4g DQo+IFNpZ25lZC1vZmYtYnk6IE1hY3BhdWwgTGluIDxtYWNwYXVsLmxpbkBtZWRpYXRlay5jb20+ DQo+IC0tLQ0KPiAgZHJpdmVycy9waHkvcGh5LWNvcmUuYyAgfCAgIDE3ICsrKysrKysrKysrKysr KysrDQo+ICBpbmNsdWRlL2xpbnV4L3BoeS9waHkuaCB8ICAgIDMgKysrDQo+ICAyIGZpbGVzIGNo YW5nZWQsIDIwIGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9w aHktY29yZS5jIGIvZHJpdmVycy9waHkvcGh5LWNvcmUuYw0KPiBpbmRleCBjY2I1NzViLi5iOGY2 NTM5IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL3BoeS9waHktY29yZS5jDQo+ICsrKyBiL2RyaXZl cnMvcGh5L3BoeS1jb3JlLmMNCj4gQEAgLTM3Myw2ICszNzMsMjMgQEAgaW50IHBoeV9zZXRfbW9k ZV9leHQoc3RydWN0IHBoeSAqcGh5LCBlbnVtIHBoeV9tb2RlIG1vZGUsIGludCBzdWJtb2RlKQ0K PiAgfQ0KPiAgRVhQT1JUX1NZTUJPTF9HUEwocGh5X3NldF9tb2RlX2V4dCk7DQo+ICANCj4gK2lu dCBwaHlfZ2V0X21vZGVfZXh0KHN0cnVjdCBwaHkgKnBoeSkNCj4gK3sNCj4gKwlpbnQgcmV0Ow0K PiArDQo+ICsJaWYgKCFwaHkgfHwgIXBoeS0+b3BzLT5nZXRfbW9kZV9leHQpDQo+ICsJCXJldHVy biAwOw0KPiArDQo+ICsJbXV0ZXhfbG9jaygmcGh5LT5tdXRleCk7DQo+ICsJcmV0ID0gcGh5LT5v cHMtPmdldF9tb2RlX2V4dChwaHkpOw0KPiArCWlmICghcmV0KQ0KPiArCQlyZXQgPSBwaHktPmF0 dHJzLm1vZGU7DQo+ICsJbXV0ZXhfdW5sb2NrKCZwaHktPm11dGV4KTsNCj4gKw0KPiArCXJldHVy biByZXQ7DQo+ICt9DQo+ICtFWFBPUlRfU1lNQk9MX0dQTChwaHlfZ2V0X21vZGVfZXh0KTsNCj4g Kw0KPiAgaW50IHBoeV9zZXRfbWVkaWEoc3RydWN0IHBoeSAqcGh5LCBlbnVtIHBoeV9tZWRpYSBt ZWRpYSkNCj4gIHsNCj4gIAlpbnQgcmV0Ow0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9w aHkvcGh5LmggYi9pbmNsdWRlL2xpbnV4L3BoeS9waHkuaA0KPiBpbmRleCAwZWQ0MzRkLi43ZDMy YzZiIDEwMDY0NA0KPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3BoeS9waHkuaA0KPiArKysgYi9pbmNs dWRlL2xpbnV4L3BoeS9waHkuaA0KPiBAQCAtMzQsNiArMzQsNyBAQCBlbnVtIHBoeV9tb2RlIHsN Cj4gIAlQSFlfTU9ERV9VU0JfREVWSUNFX0hTLA0KPiAgCVBIWV9NT0RFX1VTQl9ERVZJQ0VfU1Ms DQo+ICAJUEhZX01PREVfVVNCX09URywNCj4gKwlQSFlfTU9ERV9VQVJULA0KPiAgCVBIWV9NT0RF X1VGU19IU19BLA0KPiAgCVBIWV9NT0RFX1VGU19IU19CLA0KPiAgCVBIWV9NT0RFX1BDSUUsDQo+ IEBAIC03MCw2ICs3MSw3IEBAIGVudW0gcGh5X21lZGlhIHsNCj4gICAqIEBwb3dlcl9vbjogcG93 ZXJpbmcgb24gdGhlIHBoeQ0KPiAgICogQHBvd2VyX29mZjogcG93ZXJpbmcgb2ZmIHRoZSBwaHkN Cj4gICAqIEBzZXRfbW9kZTogc2V0IHRoZSBtb2RlIG9mIHRoZSBwaHkNCj4gKyAqIEBnZXRfbW9k ZV9leHQ6IGdldCB0aGUgZXh0ZW50ZWQgbW9kZSBvZiB0aGUgcGh5DQo+ICAgKiBAc2V0X21lZGlh OiBzZXQgdGhlIG1lZGlhIHR5cGUgb2YgdGhlIHBoeSAob3B0aW9uYWwpDQo+ICAgKiBAc2V0X3Nw ZWVkOiBzZXQgdGhlIHNwZWVkIG9mIHRoZSBwaHkgKG9wdGlvbmFsKQ0KPiAgICogQHJlc2V0OiBy ZXNldHRpbmcgdGhlIHBoeQ0KPiBAQCAtODMsNiArODUsNyBAQCBzdHJ1Y3QgcGh5X29wcyB7DQo+ ICAJaW50CSgqcG93ZXJfb24pKHN0cnVjdCBwaHkgKnBoeSk7DQo+ICAJaW50CSgqcG93ZXJfb2Zm KShzdHJ1Y3QgcGh5ICpwaHkpOw0KPiAgCWludAkoKnNldF9tb2RlKShzdHJ1Y3QgcGh5ICpwaHks IGVudW0gcGh5X21vZGUgbW9kZSwgaW50IHN1Ym1vZGUpOw0KPiArCWludAkoKmdldF9tb2RlX2V4 dCkoc3RydWN0IHBoeSAqcGh5KTsNCj4gIAlpbnQJKCpzZXRfbWVkaWEpKHN0cnVjdCBwaHkgKnBo eSwgZW51bSBwaHlfbWVkaWEgbWVkaWEpOw0KPiAgCWludAkoKnNldF9zcGVlZCkoc3RydWN0IHBo eSAqcGh5LCBpbnQgc3BlZWQpOw0KPiAgDQphZGQgcHJvdG90eXBlIG9mIHBoeV9nZXRfbW9kZV9l eHQoc3RydWN0IHBoeSAqcGh5KSBmb3IgYm90aCBjYXNlcyB0aGF0DQpDT05GSUdfR0VORVJJQ19Q SFkgaXMgZW5hYmxlZCBvciBub3QgaW4gbGludXgvcGh5L3BoeS5oDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A1CC4338F for ; Wed, 28 Jul 2021 01:35:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8113160F41 for ; Wed, 28 Jul 2021 01:35:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8113160F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yaATUHQW6qaa8NgnAwnUH3EZYhensntFbkP5iL4Ery0=; b=Y+P2XTSoQ9Rr7I iNmmeZyt7vxYEoIz5MeOAzyywXYFhrkO/foCSdJSMV6xOUZAFAbEAW8dzEpkOFMEE5RmHEljWTQas I3kFKdqtELf68tk6DwHOeJifq5iRGMXmPXJqDPe+jG+nrd409N+QTqWZXpr0c/tf/Fhc6Zz+X8gEl FmtRq/7Ys77GNZq+egFVS3giPxiJsWI83gIdW4GX5CdN5y17LCmoGoqiYuDYeZsDL8QWhc6eB09IA Y6xpkmrcb098S+pIIaydBxnaOkLYzoGGQvdYrAJ0rekxuNiYIs15+5pzHhJXllo3SMooocgixk3ZX Usapo30SV7X5nVUtY8TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8YTt-00GnXm-Se; Wed, 28 Jul 2021 01:35:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8YTd-00GnVU-DV; Wed, 28 Jul 2021 01:35:20 +0000 X-UUID: 2264ea6cf28a4cafb0313a34e612beef-20210727 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=tystcQCeK1JokSJpr3jNYbyoX8+NJdw5MNRuzT9Nl1s=; b=B5YTcTWL9N2Ccfi/OHpSmHeQ1b5DSpNGkjNIucKMFWfNzier6BvpJ/OC9il7NL3B1NQCPxjNGQXCW/WBvxH/c0kJv8QuGKkvSn7x024/8rJD8bSMUJFrkBNlpLXaBwnQhuMB2iSh92KC0Hcv0bLiz67/4HtV0FlyXwJ4I3krgP8=; X-UUID: 2264ea6cf28a4cafb0313a34e612beef-20210727 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1123893777; Tue, 27 Jul 2021 18:35:13 -0700 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Jul 2021 18:35:06 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Jul 2021 09:35:05 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 28 Jul 2021 09:35:03 +0800 Message-ID: <1627436103.31194.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] phy: introduce phy mode PHY_MODE_UART and phy_get_mode_ext() From: Chunfeng Yun To: Macpaul Lin CC: , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , Ainge Hsu , Eddie Hung , Kuohong Wang , Mediatek WSD Upstream , Macpaul Lin , , , , Date: Wed, 28 Jul 2021 09:35:03 +0800 In-Reply-To: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> References: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_183517_507632_721966D2 X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2021-07-27 at 18:50 +0800, Macpaul Lin wrote: > Some embedded platform shared PINs between USB and UART. > > For example, some phone will use special cable detection in boot loader > to switch USB port function into UART mode. Hence Kernel need to query > the hardware state from PHY registers to confirm the initialzation flow > for PHY and USB driver. > > To support this kind of PIN switch, new PHY MODE and query API is > required. Here we introduce a new PHY mode: PHY_MODE_UART. > > API phy_get_mode_ext() can be used to query the MODE from hardware > instead of reading it from phy attributes. > > Signed-off-by: Macpaul Lin > --- > drivers/phy/phy-core.c | 17 +++++++++++++++++ > include/linux/phy/phy.h | 3 +++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index ccb575b..b8f6539 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -373,6 +373,23 @@ int phy_set_mode_ext(struct phy *phy, enum phy_mode mode, int submode) > } > EXPORT_SYMBOL_GPL(phy_set_mode_ext); > > +int phy_get_mode_ext(struct phy *phy) > +{ > + int ret; > + > + if (!phy || !phy->ops->get_mode_ext) > + return 0; > + > + mutex_lock(&phy->mutex); > + ret = phy->ops->get_mode_ext(phy); > + if (!ret) > + ret = phy->attrs.mode; > + mutex_unlock(&phy->mutex); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_get_mode_ext); > + > int phy_set_media(struct phy *phy, enum phy_media media) > { > int ret; > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 0ed434d..7d32c6b 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -34,6 +34,7 @@ enum phy_mode { > PHY_MODE_USB_DEVICE_HS, > PHY_MODE_USB_DEVICE_SS, > PHY_MODE_USB_OTG, > + PHY_MODE_UART, > PHY_MODE_UFS_HS_A, > PHY_MODE_UFS_HS_B, > PHY_MODE_PCIE, > @@ -70,6 +71,7 @@ enum phy_media { > * @power_on: powering on the phy > * @power_off: powering off the phy > * @set_mode: set the mode of the phy > + * @get_mode_ext: get the extented mode of the phy > * @set_media: set the media type of the phy (optional) > * @set_speed: set the speed of the phy (optional) > * @reset: resetting the phy > @@ -83,6 +85,7 @@ struct phy_ops { > int (*power_on)(struct phy *phy); > int (*power_off)(struct phy *phy); > int (*set_mode)(struct phy *phy, enum phy_mode mode, int submode); > + int (*get_mode_ext)(struct phy *phy); > int (*set_media)(struct phy *phy, enum phy_media media); > int (*set_speed)(struct phy *phy, int speed); > add prototype of phy_get_mode_ext(struct phy *phy) for both cases that CONFIG_GENERIC_PHY is enabled or not in linux/phy/phy.h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800EFC4338F for ; Wed, 28 Jul 2021 01:37:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4459760F23 for ; Wed, 28 Jul 2021 01:37:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4459760F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YUpAuDAvxtggFCncbaZ2FuLdjzmQSSdJlpI1nmj5dCE=; b=d/HCodYnCtcZKH FTJvLkHEiZPIPSpbKlvBQn/FzW4E4e71N+hGO9HjjVghIXDIieb1cBsvTWfEWpudgczjdQDw7d6gk GUAlbWZxzpGq/0yhzPXahJbhmZQromXsZAMdPDjQKf4nVMRXruWv/AzWOH22r2fI5fMisxMV/EjDn IVYsg1bPE4tE5rmlptClOi9+YKLewNc6YTEMgqtxeOmp+tLVbkUNsq/ATBMYaezYwPXzYE1MQim4j rqST0pJ702FAxARDmvgOjKZOA6vrUu9uUGyTRmxbl2JTxqtssyh8hNnNnS0mWMOta2Qn7JovAM3RB ztZfa1Iuh5gJhvr1zdLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8YTi-00GnWM-Na; Wed, 28 Jul 2021 01:35:22 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8YTd-00GnVU-DV; Wed, 28 Jul 2021 01:35:20 +0000 X-UUID: 2264ea6cf28a4cafb0313a34e612beef-20210727 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=tystcQCeK1JokSJpr3jNYbyoX8+NJdw5MNRuzT9Nl1s=; b=B5YTcTWL9N2Ccfi/OHpSmHeQ1b5DSpNGkjNIucKMFWfNzier6BvpJ/OC9il7NL3B1NQCPxjNGQXCW/WBvxH/c0kJv8QuGKkvSn7x024/8rJD8bSMUJFrkBNlpLXaBwnQhuMB2iSh92KC0Hcv0bLiz67/4HtV0FlyXwJ4I3krgP8=; X-UUID: 2264ea6cf28a4cafb0313a34e612beef-20210727 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1123893777; Tue, 27 Jul 2021 18:35:13 -0700 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Jul 2021 18:35:06 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Jul 2021 09:35:05 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 28 Jul 2021 09:35:03 +0800 Message-ID: <1627436103.31194.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] phy: introduce phy mode PHY_MODE_UART and phy_get_mode_ext() From: Chunfeng Yun To: Macpaul Lin CC: , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , Ainge Hsu , Eddie Hung , Kuohong Wang , Mediatek WSD Upstream , Macpaul Lin , , , , Date: Wed, 28 Jul 2021 09:35:03 +0800 In-Reply-To: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> References: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_183517_507632_721966D2 X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-07-27 at 18:50 +0800, Macpaul Lin wrote: > Some embedded platform shared PINs between USB and UART. > > For example, some phone will use special cable detection in boot loader > to switch USB port function into UART mode. Hence Kernel need to query > the hardware state from PHY registers to confirm the initialzation flow > for PHY and USB driver. > > To support this kind of PIN switch, new PHY MODE and query API is > required. Here we introduce a new PHY mode: PHY_MODE_UART. > > API phy_get_mode_ext() can be used to query the MODE from hardware > instead of reading it from phy attributes. > > Signed-off-by: Macpaul Lin > --- > drivers/phy/phy-core.c | 17 +++++++++++++++++ > include/linux/phy/phy.h | 3 +++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index ccb575b..b8f6539 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -373,6 +373,23 @@ int phy_set_mode_ext(struct phy *phy, enum phy_mode mode, int submode) > } > EXPORT_SYMBOL_GPL(phy_set_mode_ext); > > +int phy_get_mode_ext(struct phy *phy) > +{ > + int ret; > + > + if (!phy || !phy->ops->get_mode_ext) > + return 0; > + > + mutex_lock(&phy->mutex); > + ret = phy->ops->get_mode_ext(phy); > + if (!ret) > + ret = phy->attrs.mode; > + mutex_unlock(&phy->mutex); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_get_mode_ext); > + > int phy_set_media(struct phy *phy, enum phy_media media) > { > int ret; > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 0ed434d..7d32c6b 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -34,6 +34,7 @@ enum phy_mode { > PHY_MODE_USB_DEVICE_HS, > PHY_MODE_USB_DEVICE_SS, > PHY_MODE_USB_OTG, > + PHY_MODE_UART, > PHY_MODE_UFS_HS_A, > PHY_MODE_UFS_HS_B, > PHY_MODE_PCIE, > @@ -70,6 +71,7 @@ enum phy_media { > * @power_on: powering on the phy > * @power_off: powering off the phy > * @set_mode: set the mode of the phy > + * @get_mode_ext: get the extented mode of the phy > * @set_media: set the media type of the phy (optional) > * @set_speed: set the speed of the phy (optional) > * @reset: resetting the phy > @@ -83,6 +85,7 @@ struct phy_ops { > int (*power_on)(struct phy *phy); > int (*power_off)(struct phy *phy); > int (*set_mode)(struct phy *phy, enum phy_mode mode, int submode); > + int (*get_mode_ext)(struct phy *phy); > int (*set_media)(struct phy *phy, enum phy_media media); > int (*set_speed)(struct phy *phy, int speed); > add prototype of phy_get_mode_ext(struct phy *phy) for both cases that CONFIG_GENERIC_PHY is enabled or not in linux/phy/phy.h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1768FC4338F for ; Wed, 28 Jul 2021 01:35:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBA9460F41 for ; Wed, 28 Jul 2021 01:35:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CBA9460F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BvOAIhFJloEicHkXtd2O03xKAm+bTBUL/dTeTlFEooc=; b=ajIffVSmAXMs9s YRblE1YiL2iLzi6v/0S1XFKuExUfWnLeJV2HbFRdtGcEx7xeuCl2bEfOaP2+gnxwO9n3xc+wzdckd tHNRQogvz1PoUwqKi17TVWA7ysdv6dfpxuHJ5ienSbGGKNv1ZxJjIBKZdDvmXfcWJYiNA8LMNJ1VT d36kC7IqdpoGRTcJlUHYO24ccFYwInrT1SyxEE13EZ9hFi/3qKSOD53tI4zpMJmrqmsy3WdUGX9w+ a7kvZiD+lMCDHPB4n45FrEPaUMaRyfJE5y3YXqaFch2jHCA17BjW4AmzBY9iXwSgyhtzjlCKhUQKR kkLCAd1bun1YSKyS1Qkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8YTs-00GnXf-CE; Wed, 28 Jul 2021 01:35:32 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8YTd-00GnVU-DV; Wed, 28 Jul 2021 01:35:20 +0000 X-UUID: 2264ea6cf28a4cafb0313a34e612beef-20210727 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=tystcQCeK1JokSJpr3jNYbyoX8+NJdw5MNRuzT9Nl1s=; b=B5YTcTWL9N2Ccfi/OHpSmHeQ1b5DSpNGkjNIucKMFWfNzier6BvpJ/OC9il7NL3B1NQCPxjNGQXCW/WBvxH/c0kJv8QuGKkvSn7x024/8rJD8bSMUJFrkBNlpLXaBwnQhuMB2iSh92KC0Hcv0bLiz67/4HtV0FlyXwJ4I3krgP8=; X-UUID: 2264ea6cf28a4cafb0313a34e612beef-20210727 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1123893777; Tue, 27 Jul 2021 18:35:13 -0700 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Jul 2021 18:35:06 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Jul 2021 09:35:05 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 28 Jul 2021 09:35:03 +0800 Message-ID: <1627436103.31194.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] phy: introduce phy mode PHY_MODE_UART and phy_get_mode_ext() From: Chunfeng Yun To: Macpaul Lin CC: , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , Ainge Hsu , Eddie Hung , Kuohong Wang , Mediatek WSD Upstream , Macpaul Lin , , , , Date: Wed, 28 Jul 2021 09:35:03 +0800 In-Reply-To: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> References: <1627383013-4535-1-git-send-email-macpaul.lin@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_183517_507632_721966D2 X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, 2021-07-27 at 18:50 +0800, Macpaul Lin wrote: > Some embedded platform shared PINs between USB and UART. > > For example, some phone will use special cable detection in boot loader > to switch USB port function into UART mode. Hence Kernel need to query > the hardware state from PHY registers to confirm the initialzation flow > for PHY and USB driver. > > To support this kind of PIN switch, new PHY MODE and query API is > required. Here we introduce a new PHY mode: PHY_MODE_UART. > > API phy_get_mode_ext() can be used to query the MODE from hardware > instead of reading it from phy attributes. > > Signed-off-by: Macpaul Lin > --- > drivers/phy/phy-core.c | 17 +++++++++++++++++ > include/linux/phy/phy.h | 3 +++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index ccb575b..b8f6539 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -373,6 +373,23 @@ int phy_set_mode_ext(struct phy *phy, enum phy_mode mode, int submode) > } > EXPORT_SYMBOL_GPL(phy_set_mode_ext); > > +int phy_get_mode_ext(struct phy *phy) > +{ > + int ret; > + > + if (!phy || !phy->ops->get_mode_ext) > + return 0; > + > + mutex_lock(&phy->mutex); > + ret = phy->ops->get_mode_ext(phy); > + if (!ret) > + ret = phy->attrs.mode; > + mutex_unlock(&phy->mutex); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_get_mode_ext); > + > int phy_set_media(struct phy *phy, enum phy_media media) > { > int ret; > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 0ed434d..7d32c6b 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -34,6 +34,7 @@ enum phy_mode { > PHY_MODE_USB_DEVICE_HS, > PHY_MODE_USB_DEVICE_SS, > PHY_MODE_USB_OTG, > + PHY_MODE_UART, > PHY_MODE_UFS_HS_A, > PHY_MODE_UFS_HS_B, > PHY_MODE_PCIE, > @@ -70,6 +71,7 @@ enum phy_media { > * @power_on: powering on the phy > * @power_off: powering off the phy > * @set_mode: set the mode of the phy > + * @get_mode_ext: get the extented mode of the phy > * @set_media: set the media type of the phy (optional) > * @set_speed: set the speed of the phy (optional) > * @reset: resetting the phy > @@ -83,6 +85,7 @@ struct phy_ops { > int (*power_on)(struct phy *phy); > int (*power_off)(struct phy *phy); > int (*set_mode)(struct phy *phy, enum phy_mode mode, int submode); > + int (*get_mode_ext)(struct phy *phy); > int (*set_media)(struct phy *phy, enum phy_media media); > int (*set_speed)(struct phy *phy, int speed); > add prototype of phy_get_mode_ext(struct phy *phy) for both cases that CONFIG_GENERIC_PHY is enabled or not in linux/phy/phy.h -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy