From: Oleksandr Tyshchenko <olekstysh@gmail.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Andrey Konovalov <andreyknvl@gmail.com>, Ard Biesheuvel <ardb@kernel.org>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Joey Gouly <joey.gouly@arm.com>, Sami Tolvanen <samitolvanen@google.com>, Mark Rutland <mark.rutland@arm.com>, Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org> Subject: [RFC PATCH 1/2] arm64: mm: Make virt_addr_valid to check for pfn_valid again Date: Wed, 28 Jul 2021 19:44:15 +0300 [thread overview] Message-ID: <1627490656-1267-1-git-send-email-olekstysh@gmail.com> (raw) From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> The problem is that Arm's implementation of virt_addr_valid() leads to memblock_is_map_memory() check, which will fail for ZONE_DEVICE based addresses. But, the pfn_valid() check in turn is able to cope with ZONE_DEVICE based memory. You can find a good explanation of that problem at: https://lore.kernel.org/lkml/1614921898-4099-2-git-send-email-anshuman.khandual@arm.com Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> --- I am not quite sure whether it is a "correct" place and the change itself, I just partially restored a behaviour before: https://lore.kernel.org/lkml/20210511100550.28178-4-rppt@kernel.org So, the target of this patch is to get a feedback how to resolve this properly if, of course, this really needs to be resolved (I might miss important bits here). It is worth mentioning that patch doesn't fix the current code base (if I am not mistaken, no one calls virt_addr_valid() on Arm64 for ZONE_DEVICE based addresses at the moment, so it seems that nothing is broken), the fix is intended for the subsequent patch in this series that will try to enable Xen's "unpopulated-alloc" usage on Arm (it was enabled on x86 so far). Please see: [RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space The subsequent patch will enable the code where virt_addr_valid() is used in drivers/xen/unpopulated-alloc.c:fill_list() to check that a virtual address returned by memremap_pages() is valid. --- arch/arm64/include/asm/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h index 824a365..1a35a44 100644 --- a/arch/arm64/include/asm/memory.h +++ b/arch/arm64/include/asm/memory.h @@ -351,7 +351,7 @@ static inline void *phys_to_virt(phys_addr_t x) #define virt_addr_valid(addr) ({ \ __typeof__(addr) __addr = __tag_reset(addr); \ - __is_lm_address(__addr) && pfn_is_map_memory(virt_to_pfn(__addr)); \ + __is_lm_address(__addr) && pfn_valid(virt_to_pfn(__addr)); \ }) void dump_mem_limit(void); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr Tyshchenko <olekstysh@gmail.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Andrey Konovalov <andreyknvl@gmail.com>, Ard Biesheuvel <ardb@kernel.org>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Joey Gouly <joey.gouly@arm.com>, Sami Tolvanen <samitolvanen@google.com>, Mark Rutland <mark.rutland@arm.com>, Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org> Subject: [RFC PATCH 1/2] arm64: mm: Make virt_addr_valid to check for pfn_valid again Date: Wed, 28 Jul 2021 19:44:15 +0300 [thread overview] Message-ID: <1627490656-1267-1-git-send-email-olekstysh@gmail.com> (raw) From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> The problem is that Arm's implementation of virt_addr_valid() leads to memblock_is_map_memory() check, which will fail for ZONE_DEVICE based addresses. But, the pfn_valid() check in turn is able to cope with ZONE_DEVICE based memory. You can find a good explanation of that problem at: https://lore.kernel.org/lkml/1614921898-4099-2-git-send-email-anshuman.khandual@arm.com Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> --- I am not quite sure whether it is a "correct" place and the change itself, I just partially restored a behaviour before: https://lore.kernel.org/lkml/20210511100550.28178-4-rppt@kernel.org So, the target of this patch is to get a feedback how to resolve this properly if, of course, this really needs to be resolved (I might miss important bits here). It is worth mentioning that patch doesn't fix the current code base (if I am not mistaken, no one calls virt_addr_valid() on Arm64 for ZONE_DEVICE based addresses at the moment, so it seems that nothing is broken), the fix is intended for the subsequent patch in this series that will try to enable Xen's "unpopulated-alloc" usage on Arm (it was enabled on x86 so far). Please see: [RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space The subsequent patch will enable the code where virt_addr_valid() is used in drivers/xen/unpopulated-alloc.c:fill_list() to check that a virtual address returned by memremap_pages() is valid. --- arch/arm64/include/asm/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h index 824a365..1a35a44 100644 --- a/arch/arm64/include/asm/memory.h +++ b/arch/arm64/include/asm/memory.h @@ -351,7 +351,7 @@ static inline void *phys_to_virt(phys_addr_t x) #define virt_addr_valid(addr) ({ \ __typeof__(addr) __addr = __tag_reset(addr); \ - __is_lm_address(__addr) && pfn_is_map_memory(virt_to_pfn(__addr)); \ + __is_lm_address(__addr) && pfn_valid(virt_to_pfn(__addr)); \ }) void dump_mem_limit(void); -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-07-28 16:44 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-28 16:44 Oleksandr Tyshchenko [this message] 2021-07-28 16:44 ` [RFC PATCH 1/2] arm64: mm: Make virt_addr_valid to check for pfn_valid again Oleksandr Tyshchenko 2021-07-28 16:44 ` [RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space Oleksandr Tyshchenko 2021-07-28 16:44 ` Oleksandr Tyshchenko 2021-08-02 12:19 ` [RFC PATCH 1/2] arm64: mm: Make virt_addr_valid to check for pfn_valid again Catalin Marinas 2021-08-02 12:19 ` Catalin Marinas 2021-08-02 15:08 ` Mike Rapoport 2021-08-02 15:08 ` Mike Rapoport 2021-08-02 15:52 ` Oleksandr 2021-08-02 15:52 ` Oleksandr
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1627490656-1267-1-git-send-email-olekstysh@gmail.com \ --to=olekstysh@gmail.com \ --cc=Wei.Chen@arm.com \ --cc=andreyknvl@gmail.com \ --cc=ardb@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=jgross@suse.com \ --cc=joey.gouly@arm.com \ --cc=julien@xen.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=oleksandr_tyshchenko@epam.com \ --cc=samitolvanen@google.com \ --cc=sstabellini@kernel.org \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.