From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8ECFC4338F for ; Tue, 3 Aug 2021 10:06:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5E9760F8F for ; Tue, 3 Aug 2021 10:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235325AbhHCKHH (ORCPT ); Tue, 3 Aug 2021 06:07:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:48792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235443AbhHCKGA (ORCPT ); Tue, 3 Aug 2021 06:06:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7687B60F58; Tue, 3 Aug 2021 10:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627985131; bh=93hGHvv0jTlTB/pEmtoCJ8yywlMMD3nceQAE0r3RVYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RIJBSN8U6aaoMxxeZTyKttqq1mHfYfV4Abqz+vr8Iv1lafIA1LVwBbszbuxrMJ8hl EMrfXzLjxRCF/G4EYrVMaHVz35eDp5jT7XjcO/5Zc5teOZEZNJGwuBd0jBlGlhiFNC CX5+biaUbp0n/FFC+hBZr3RDFPMBa3bSgXzZg56jb4+mjNXJzWS+G9/jjDEoQ3htYv sCYHkUuObvSY5bxnq8fVkVUlN5vq1o0rrCWaLvEzeK9A/xNmXbt6r+eMPQt4Zgw1Va PvxwSWLH7y04yLNIo+fxvBQwhC/HJfMXs1Fzso/4uSDYZoGgK88M6gdSXS+1baQjFO EfFieD6fXDqhQ== From: Will Deacon To: linux-arm-kernel@lists.infradead.org, Barry Song , catalin.marinas@arm.com Cc: kernel-team@android.com, Will Deacon , linux@roeck-us.net, tyhicks@linux.microsoft.com, Qi Liu , linuxarm@huawei.com, maz@kernel.org, Ard Biesheuvel , tabba@google.com, Masami Hiramatsu , lecopzer.chen@mediatek.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: fix the doc of RANDOMIZE_MODULE_REGION_FULL Date: Tue, 3 Aug 2021 11:05:20 +0100 Message-Id: <162798340286.1497797.18069753288714137637.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210730125131.13724-1-song.bao.hua@hisilicon.com> References: <20210730125131.13724-1-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 31 Jul 2021 00:51:31 +1200, Barry Song wrote: > Obviously kaslr is setting the module region to 2GB rather than 4GB since > commit b2eed9b588112 ("arm64/kernel: kaslr: reduce module randomization > range to 2 GB"). So fix the size of region in Kconfig. > On the other hand, even though RANDOMIZE_MODULE_REGION_FULL is not set, > module_alloc() can fall back to a 2GB window if ARM64_MODULE_PLTS is set. > In this case, veneers are still needed. !RANDOMIZE_MODULE_REGION_FULL > doesn't necessarily mean veneers are not needed. > So fix the doc to be more precise to avoid any confusion to the readers > of the code. Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: fix the doc of RANDOMIZE_MODULE_REGION_FULL https://git.kernel.org/arm64/c/f9c4ff2ab9fe Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D51CC4338F for ; Tue, 3 Aug 2021 10:08:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43BC560C3E for ; Tue, 3 Aug 2021 10:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43BC560C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S/3yQFfnNDuy53NYNcnQBC1IWJRW6QcYtImW7HrKlLU=; b=GkDauT5Z3I65ZV Jn/VtklUt0mfSLtTr9e+Agf1+tcqNPbvmec5ZxLYUle8PZkYuK8iJVhQbIGiSt5X62rtsFRVECtZ3 QAILPme+3tr2WyJeBIxXOecdTXqx7jG1BXV4PazBgyBuyeWhaIjmyqOFovzza+WopJbbkqz5vEpMo DZhiYRNbg5Ak9j21pF5PGI9QhPOH7f3PRq4gJh3hyKrgdF1hAez7W0gZN/jNW2weYlXpZFjjGhVOh aXo9XuiQ5ZjFoFGcJOdLSUtlq/GSwzjg24lwiU7hfm6eRRw7A9/uFVIzCEzRFMOa4iUL3crdaPrUY 2YbKVJVY+IeHPaNG9ngA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mArJB-001v9B-PE; Tue, 03 Aug 2021 10:06:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mArIh-001v50-AJ for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 10:05:33 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7687B60F58; Tue, 3 Aug 2021 10:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627985131; bh=93hGHvv0jTlTB/pEmtoCJ8yywlMMD3nceQAE0r3RVYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RIJBSN8U6aaoMxxeZTyKttqq1mHfYfV4Abqz+vr8Iv1lafIA1LVwBbszbuxrMJ8hl EMrfXzLjxRCF/G4EYrVMaHVz35eDp5jT7XjcO/5Zc5teOZEZNJGwuBd0jBlGlhiFNC CX5+biaUbp0n/FFC+hBZr3RDFPMBa3bSgXzZg56jb4+mjNXJzWS+G9/jjDEoQ3htYv sCYHkUuObvSY5bxnq8fVkVUlN5vq1o0rrCWaLvEzeK9A/xNmXbt6r+eMPQt4Zgw1Va PvxwSWLH7y04yLNIo+fxvBQwhC/HJfMXs1Fzso/4uSDYZoGgK88M6gdSXS+1baQjFO EfFieD6fXDqhQ== From: Will Deacon To: linux-arm-kernel@lists.infradead.org, Barry Song , catalin.marinas@arm.com Cc: kernel-team@android.com, Will Deacon , linux@roeck-us.net, tyhicks@linux.microsoft.com, Qi Liu , linuxarm@huawei.com, maz@kernel.org, Ard Biesheuvel , tabba@google.com, Masami Hiramatsu , lecopzer.chen@mediatek.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: fix the doc of RANDOMIZE_MODULE_REGION_FULL Date: Tue, 3 Aug 2021 11:05:20 +0100 Message-Id: <162798340286.1497797.18069753288714137637.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210730125131.13724-1-song.bao.hua@hisilicon.com> References: <20210730125131.13724-1-song.bao.hua@hisilicon.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_030531_462543_3B220180 X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 31 Jul 2021 00:51:31 +1200, Barry Song wrote: > Obviously kaslr is setting the module region to 2GB rather than 4GB since > commit b2eed9b588112 ("arm64/kernel: kaslr: reduce module randomization > range to 2 GB"). So fix the size of region in Kconfig. > On the other hand, even though RANDOMIZE_MODULE_REGION_FULL is not set, > module_alloc() can fall back to a 2GB window if ARM64_MODULE_PLTS is set. > In this case, veneers are still needed. !RANDOMIZE_MODULE_REGION_FULL > doesn't necessarily mean veneers are not needed. > So fix the doc to be more precise to avoid any confusion to the readers > of the code. Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: fix the doc of RANDOMIZE_MODULE_REGION_FULL https://git.kernel.org/arm64/c/f9c4ff2ab9fe Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel