* [PATCH] powerpc/stacktrace: Include linux/delay.h
@ 2021-07-26 15:42 Michal Suchanek
2021-07-26 16:55 ` Gabriel Paubert
2021-07-29 18:01 ` Michal Suchanek
0 siblings, 2 replies; 4+ messages in thread
From: Michal Suchanek @ 2021-07-26 15:42 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Michal Suchanek
commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the
functionshould be included nonetheless.
Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
arch/powerpc/kernel/stacktrace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index 2b0d04a1b7d2..a17ac10f86b1 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -12,6 +12,7 @@
#include <linux/kallsyms.h>
#include <linux/module.h>
#include <linux/nmi.h>
+#include <linux/delay.h>
#include <linux/sched.h>
#include <linux/sched/debug.h>
#include <linux/sched/task_stack.h>
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/stacktrace: Include linux/delay.h
2021-07-26 15:42 [PATCH] powerpc/stacktrace: Include linux/delay.h Michal Suchanek
@ 2021-07-26 16:55 ` Gabriel Paubert
2021-07-29 18:01 ` Michal Suchanek
1 sibling, 0 replies; 4+ messages in thread
From: Gabriel Paubert @ 2021-07-26 16:55 UTC (permalink / raw)
To: Michal Suchanek; +Cc: linuxppc-dev
On Mon, Jul 26, 2021 at 05:42:43PM +0200, Michal Suchanek wrote:
> commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
> introduces udelay() call without including the linux/delay.h header.
> This may happen to work on master but the header that declares the
> functionshould be included nonetheless.
>
> Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> arch/powerpc/kernel/stacktrace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
> index 2b0d04a1b7d2..a17ac10f86b1 100644
> --- a/arch/powerpc/kernel/stacktrace.c
> +++ b/arch/powerpc/kernel/stacktrace.c
> @@ -12,6 +12,7 @@
> #include <linux/kallsyms.h>
> #include <linux/module.h>
> #include <linux/nmi.h>
> +#include <linux/delay.h>
> #include <linux/sched.h>
> #include <linux/sched/debug.h>
> #include <linux/sched/task_stack.h>
Hmm, I believe we try to keep the list of includes sorted in
alphabetical order.
Gabriel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] powerpc/stacktrace: Include linux/delay.h
2021-07-26 15:42 [PATCH] powerpc/stacktrace: Include linux/delay.h Michal Suchanek
2021-07-26 16:55 ` Gabriel Paubert
@ 2021-07-29 18:01 ` Michal Suchanek
2021-08-03 10:20 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Michal Suchanek @ 2021-07-29 18:01 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Michal Suchanek
commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the
functionshould be included nonetheless.
Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
V2: Add header in alphabetical order.
---
arch/powerpc/kernel/stacktrace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index 2b0d04a1b7d2..9e4a4a7af380 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -8,6 +8,7 @@
* Copyright 2018 Nick Piggin, Michael Ellerman, IBM Corp.
*/
+#include <linux/delay.h>
#include <linux/export.h>
#include <linux/kallsyms.h>
#include <linux/module.h>
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/stacktrace: Include linux/delay.h
2021-07-29 18:01 ` Michal Suchanek
@ 2021-08-03 10:20 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-08-03 10:20 UTC (permalink / raw)
To: Michal Suchanek, linuxppc-dev
On Thu, 29 Jul 2021 20:01:03 +0200, Michal Suchanek wrote:
> commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
> introduces udelay() call without including the linux/delay.h header.
> This may happen to work on master but the header that declares the
> functionshould be included nonetheless.
Applied to powerpc/next.
[1/1] powerpc/stacktrace: Include linux/delay.h
https://git.kernel.org/powerpc/c/135462ae7692a824e5b63299178684fca3a366e6
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-03 10:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 15:42 [PATCH] powerpc/stacktrace: Include linux/delay.h Michal Suchanek
2021-07-26 16:55 ` Gabriel Paubert
2021-07-29 18:01 ` Michal Suchanek
2021-08-03 10:20 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.