From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C35C4338F for ; Mon, 9 Aug 2021 05:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E673560F9F for ; Mon, 9 Aug 2021 05:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232916AbhHIFBX (ORCPT ); Mon, 9 Aug 2021 01:01:23 -0400 Received: from foss.arm.com ([217.140.110.172]:52802 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232786AbhHIFBW (ORCPT ); Mon, 9 Aug 2021 01:01:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D1311042; Sun, 8 Aug 2021 22:01:02 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2737F3F718; Sun, 8 Aug 2021 22:01:01 -0700 (PDT) From: Sudeep Holla To: Rishabh Bhatnagar , cristian.marussi@arm.com Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, adharmap@codeaurora.org, avajid@codeaurora.org Subject: Re: [PATCH v3] firmware: arm_scmi: Free mailbox channels if probe fails Date: Mon, 9 Aug 2021 06:00:57 +0100 Message-Id: <162848516052.232525.343233021782950735.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1628111999-21595-1-git-send-email-rishabhb@codeaurora.org> References: <1628111999-21595-1-git-send-email-rishabhb@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Aug 2021 14:19:59 -0700, Rishabh Bhatnagar wrote: > Mailbox channels for the base protocol are setup during probe. > There can be a scenario where probe fails to acquire the base > protocol due to a timeout leading to cleaning up of all device > managed memory including the scmi_mailbox structure setup during > mailbox_chan_setup function. > [ 12.735104]arm-scmi soc:qcom,scmi: timed out in resp(caller: version_get+0x84/0x140) > [ 12.735224]arm-scmi soc:qcom,scmi: unable to communicate with SCMI > [ 12.735947]arm-scmi: probe of soc:qcom,scmi failed with error -110 > > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scmi: Free mailbox channels if probe fails https://git.kernel.org/sudeep.holla/c/1e7cbfaa66 -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 643EDC4338F for ; Mon, 9 Aug 2021 05:02:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13FB56101D for ; Mon, 9 Aug 2021 05:02:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 13FB56101D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mEI0DQtPwBY3PMtmQFcAD/s55razSoFDiVCA/7G6G4M=; b=JLXt2lJfQLE+ba BG8YW/xk3ZoXryId+FecgWxzd+imgByG4GEAXB/LY8BI4/tY5F1i7mNSaahBoApoge9E2HW6Fg546 itMW6ZBqGyD2/F34TcTRxKtNz2z8LuVVreJUryUPE9QSNEgdk3N4w9sxCgAJ7vbI7T8OgnPCBmKmG qTfQPCwO3xdqaS2RJmHX9bzWjJSJkWRFPaUUNyBhJ4EyeYEXHXwquIvFdoTRV1YRt3ecM/dQ6rADi 4jafpbG2mSO5OPzGtBWgyTNKKA6+PiFBVDm/m5gi3T31CibJANMqE0Jtjsv187PVkpXgcGAp0BmJm 82OH3zg5xqPSLQvAey5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCxPS-00H7OA-QY; Mon, 09 Aug 2021 05:01:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCxPO-00H7NR-4m for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 05:01:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D1311042; Sun, 8 Aug 2021 22:01:02 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2737F3F718; Sun, 8 Aug 2021 22:01:01 -0700 (PDT) From: Sudeep Holla To: Rishabh Bhatnagar , cristian.marussi@arm.com Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, adharmap@codeaurora.org, avajid@codeaurora.org Subject: Re: [PATCH v3] firmware: arm_scmi: Free mailbox channels if probe fails Date: Mon, 9 Aug 2021 06:00:57 +0100 Message-Id: <162848516052.232525.343233021782950735.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1628111999-21595-1-git-send-email-rishabhb@codeaurora.org> References: <1628111999-21595-1-git-send-email-rishabhb@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210808_220106_278616_3E6C0673 X-CRM114-Status: UNSURE ( 8.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 4 Aug 2021 14:19:59 -0700, Rishabh Bhatnagar wrote: > Mailbox channels for the base protocol are setup during probe. > There can be a scenario where probe fails to acquire the base > protocol due to a timeout leading to cleaning up of all device > managed memory including the scmi_mailbox structure setup during > mailbox_chan_setup function. > [ 12.735104]arm-scmi soc:qcom,scmi: timed out in resp(caller: version_get+0x84/0x140) > [ 12.735224]arm-scmi soc:qcom,scmi: unable to communicate with SCMI > [ 12.735947]arm-scmi: probe of soc:qcom,scmi failed with error -110 > > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scmi: Free mailbox channels if probe fails https://git.kernel.org/sudeep.holla/c/1e7cbfaa66 -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel