From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F205AC4320A for ; Tue, 10 Aug 2021 20:30:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5A40604AC for ; Tue, 10 Aug 2021 20:30:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233318AbhHJUa3 (ORCPT ); Tue, 10 Aug 2021 16:30:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:40070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233254AbhHJUa2 (ORCPT ); Tue, 10 Aug 2021 16:30:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id D915A61008; Tue, 10 Aug 2021 20:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628627405; bh=2lDrpN5sVgt5Al+6FtFDkfLPd2yIOq9/MTsVWaprtBA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=aMxK/lnKxAxzyHW1M86Q4h5jZQ7QsE1PI+9bepMwe5zmMTR0f8ZiaActaaAEgOdDh WWIv1lmv4pZQ600DjYEKD/7ML71RBMQzKwQ+iq/uKKnI3hQhepAWUr6ay4Zd7wzMwz lrZ8nRsZ0FAr7RH/GW+0Q8BE1T30JO5lMPHGf8qNYiNHO0Vmg/NQlOklLHp91sPykc p7e0xM+vdQ8s6Vwoshr3KfByV7QXS/R/XNFau+sq4R3PA30G7h3vraSrUxTt4uIRos CyEX5ScZxkbKV0++IOA3J9JO7qrs9BMkuqjJhxLrlqlznT4r1jtZOuqimMFOgD8fHq 2teZsmGlvc20A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge From: patchwork-bot+netdevbpf@kernel.org Message-Id: <162862740581.16281.10031076649352815360.git-patchwork-notify@kernel.org> Date: Tue, 10 Aug 2021 20:30:05 +0000 References: <20210810115024.1629983-1-vladimir.oltean@nxp.com> In-Reply-To: <20210810115024.1629983-1-vladimir.oltean@nxp.com> To: Vladimir Oltean Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, olteanv@gmail.com, vkochan@marvell.com, tchornyi@marvell.com, saeedm@nvidia.com, leon@kernel.org, jiri@nvidia.com, idosch@nvidia.com, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, grygorii.strashko@ti.com, jwi@linux.ibm.com, kgraul@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, jianbol@nvidia.com, vladbu@nvidia.com, bjarni.jonasson@microchip.com, vigneshr@ti.com, tobias@waldekranz.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-s390@vger.kernel.org, linux@armlinux.org.uk, idosch@idosch.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 10 Aug 2021 14:50:24 +0300 you wrote: > The blamed commit a new field to struct switchdev_notifier_fdb_info, but > did not make sure that all call paths set it to something valid. For > example, a switchdev driver may emit a SWITCHDEV_FDB_ADD_TO_BRIDGE > notifier, and since the 'is_local' flag is not set, it contains junk > from the stack, so the bridge might interpret those notifications as > being for local FDB entries when that was not intended. > > [...] Here is the summary with links: - [v2,net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge https://git.kernel.org/netdev/net/c/c35b57ceff90 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48072C4338F for ; Tue, 10 Aug 2021 20:33:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E23E9606A5 for ; Tue, 10 Aug 2021 20:33:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E23E9606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Date: Message-Id:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RgtrMgUQr4/FvkUt+N5E9ntv57kc7uKLXWO/XH+xgsQ=; b=eisMZYZ9IeKsGU zBbU4THx9u0sSt5FsASJEkc9NDlb3tF/wT/YOKdOCp5nTersVYzP7hKpWHTqTwiqbQeYtTORMIu4B dX35T8FDGSXERrD6ervYHjp6xLBj9B0XYAcwJugx4zUYduY8k5pe/oeWbuE5mY3P7ziQ257mAyQ+R o+5hqQ2YhDNedHf884c58sRXZAPnFIK4AiNlEMGzsu3NI40FRg9IlpuJ3ZcQuL0hfb6dJ5H64vTAP zg8G4PciMNtT3X3Bb9bnnG4oe3LbYsTDq2Bm6LVa6RwhEmLev10trlKKO5omc7Wla/azCl3ms0e9/ gEQY4FvpGV0EnoDqCfbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDYO2-004rsF-A9; Tue, 10 Aug 2021 20:30:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDYNy-004rr7-8e for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 20:30:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPS id D915A61008; Tue, 10 Aug 2021 20:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628627405; bh=2lDrpN5sVgt5Al+6FtFDkfLPd2yIOq9/MTsVWaprtBA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=aMxK/lnKxAxzyHW1M86Q4h5jZQ7QsE1PI+9bepMwe5zmMTR0f8ZiaActaaAEgOdDh WWIv1lmv4pZQ600DjYEKD/7ML71RBMQzKwQ+iq/uKKnI3hQhepAWUr6ay4Zd7wzMwz lrZ8nRsZ0FAr7RH/GW+0Q8BE1T30JO5lMPHGf8qNYiNHO0Vmg/NQlOklLHp91sPykc p7e0xM+vdQ8s6Vwoshr3KfByV7QXS/R/XNFau+sq4R3PA30G7h3vraSrUxTt4uIRos CyEX5ScZxkbKV0++IOA3J9JO7qrs9BMkuqjJhxLrlqlznT4r1jtZOuqimMFOgD8fHq 2teZsmGlvc20A== MIME-Version: 1.0 Subject: Re: [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge From: patchwork-bot+netdevbpf@kernel.org Message-Id: <162862740581.16281.10031076649352815360.git-patchwork-notify@kernel.org> Date: Tue, 10 Aug 2021 20:30:05 +0000 References: <20210810115024.1629983-1-vladimir.oltean@nxp.com> In-Reply-To: <20210810115024.1629983-1-vladimir.oltean@nxp.com> To: Vladimir Oltean Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, olteanv@gmail.com, vkochan@marvell.com, tchornyi@marvell.com, saeedm@nvidia.com, leon@kernel.org, jiri@nvidia.com, idosch@nvidia.com, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, grygorii.strashko@ti.com, jwi@linux.ibm.com, kgraul@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, jianbol@nvidia.com, vladbu@nvidia.com, bjarni.jonasson@microchip.com, vigneshr@ti.com, tobias@waldekranz.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-s390@vger.kernel.org, linux@armlinux.org.uk, idosch@idosch.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_133006_365946_13FB558D X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 10 Aug 2021 14:50:24 +0300 you wrote: > The blamed commit a new field to struct switchdev_notifier_fdb_info, but > did not make sure that all call paths set it to something valid. For > example, a switchdev driver may emit a SWITCHDEV_FDB_ADD_TO_BRIDGE > notifier, and since the 'is_local' flag is not set, it contains junk > from the stack, so the bridge might interpret those notifications as > being for local FDB entries when that was not intended. > > [...] Here is the summary with links: - [v2,net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge https://git.kernel.org/netdev/net/c/c35b57ceff90 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel