From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E09C4338F for ; Thu, 12 Aug 2021 19:57:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3039460F57 for ; Thu, 12 Aug 2021 19:57:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3039460F57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sBiat7lN3fxZ6Q96NGi17Gm8zS1PbWtCV/lo/ByZ4zk=; b=J96OddgjGqmGSu rEmVCIAZ/S7V32hQ2Kw6cUr/SThqV2PoHPnvKd5chbe04J9Ag/CTI9BWmWPHfgNcbK4HVc5ZqZxAn 8s5BM+MHj+XAoeoFrlVGjTL7lwXFepMKZIixS5toUzHlhH2RDrYBRDGO1HEqWyuKRsv3BX5NIJRko KEArK8D2dl6xnqqf9SeXJzp3xi76mJwo/rt3hyALi5YPncz0BhVrdUhdLHUP7Etq0hHe6IBKRwkKk RtfR1s+x+HUTX2gZKpYH21nYa0ArCfHTz40qNuoO9EkMa0brKKTXsodjtivawp6i+UPA02AGsdlJ0 BTLUQwMcDorzuOdq11Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEGpW-00B5xe-Ur; Thu, 12 Aug 2021 19:57:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEGov-00B5gs-6N; Thu, 12 Aug 2021 19:56:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C614F60C3E; Thu, 12 Aug 2021 19:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628798212; bh=i+iHAHQEZxgzPWsBXZpS6OWK2GN9mm61bYvEAAIedxY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=PbDJcbRIktiOdGAFhIShmv7e7COvfN1s2n+tBIePCLv9JWOxiVcqv3/dP1viY0kU8 YCDRv6zmlt4xdreZ+JikZgKddB6tw6N+3wobQvPeZlelvMOlCAEan+Aw75C/fh7HyM kfSEmPYaYwNHX3Op1knSmFLXmQHcbgZc4V5Nxafxz8ZZ0f8FFtecHB5+ohqaC1MzMt cSjPeIa5s40liaow4XYn7Ws5n999QqTTKfjMYgRSAe3WNL7pOSqIqvVeZbWHNEgm6m GinQVOlZuUehFz3eIgFDsAn1vX+ZKVSGbpoyhVHmXrziwKxdGvcB45l8JDPiCh1htk xbWYo0/OqIkxQ== MIME-Version: 1.0 In-Reply-To: <20210812170025.67074-4-andriy.shevchenko@linux.intel.com> References: <20210812170025.67074-1-andriy.shevchenko@linux.intel.com> <20210812170025.67074-4-andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v4 4/4] clk: fractional-divider: Document the arithmetics used behind the code From: Stephen Boyd Cc: Rafael J. Wysocki , Len Brown , Michael Turquette , Abel Vesa , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Lee Jones , Liu Ying To: Andy Shevchenko , Elaine Zhang , Heiko Stuebner , Rafael J. Wysocki , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Date: Thu, 12 Aug 2021 12:56:51 -0700 Message-ID: <162879821159.19113.17550166363142634282@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_125653_318366_611CD98D X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Quoting Andy Shevchenko (2021-08-12 10:00:25) > It appears that some code lines raise the question why they are needed > and how they are participated in the calculus of the resulting values. > > Document this in a form of the top comment in the module file. > > Reported-by: Liu Ying > Signed-off-by: Andy Shevchenko > --- Applied to clk-next _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2387FC4338F for ; Thu, 12 Aug 2021 19:59:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D602E60FBF for ; Thu, 12 Aug 2021 19:59:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D602E60FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RWCg2wvRyF588ppqOAfJVuhBX5DEAd9rwOX4yt7haBs=; b=LAWlR/SQ8RDq/e auJqmn/8kOHXVp0m649zBDiK3HfYXUmB2wgkUAL3hxdNsN9pRBmSuBa4ofI12WzgFjKLtE6OR6+nB JZfP2O61V4C1qT80YfcxCXBPEKk+rVtxMrSarv2tWIMYo+U0XL3Gh+qs7Hfb4OSBlj2eur2PWX0f8 ab8v8zYkVzPkxXxY/cDBOlwTGxVrv54vxcHNIvVcJWqBjlr1WzarbjDdOkz1PcpkCnAdZUt6Fod2m 4eACBT6fvzZLdln/1/NHaxzScnSrbc02WI07BjLfPv5v0yiuG/XGJeV2FMWvdZ5ZsXQXtKvIuI+U/ fuTc8y9rV5FPq2FOxQfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEGpI-00B5oZ-Gb; Thu, 12 Aug 2021 19:57:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEGov-00B5gs-6N; Thu, 12 Aug 2021 19:56:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C614F60C3E; Thu, 12 Aug 2021 19:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628798212; bh=i+iHAHQEZxgzPWsBXZpS6OWK2GN9mm61bYvEAAIedxY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=PbDJcbRIktiOdGAFhIShmv7e7COvfN1s2n+tBIePCLv9JWOxiVcqv3/dP1viY0kU8 YCDRv6zmlt4xdreZ+JikZgKddB6tw6N+3wobQvPeZlelvMOlCAEan+Aw75C/fh7HyM kfSEmPYaYwNHX3Op1knSmFLXmQHcbgZc4V5Nxafxz8ZZ0f8FFtecHB5+ohqaC1MzMt cSjPeIa5s40liaow4XYn7Ws5n999QqTTKfjMYgRSAe3WNL7pOSqIqvVeZbWHNEgm6m GinQVOlZuUehFz3eIgFDsAn1vX+ZKVSGbpoyhVHmXrziwKxdGvcB45l8JDPiCh1htk xbWYo0/OqIkxQ== MIME-Version: 1.0 In-Reply-To: <20210812170025.67074-4-andriy.shevchenko@linux.intel.com> References: <20210812170025.67074-1-andriy.shevchenko@linux.intel.com> <20210812170025.67074-4-andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v4 4/4] clk: fractional-divider: Document the arithmetics used behind the code From: Stephen Boyd Cc: Rafael J. Wysocki , Len Brown , Michael Turquette , Abel Vesa , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Lee Jones , Liu Ying To: Andy Shevchenko , Elaine Zhang , Heiko Stuebner , Rafael J. Wysocki , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Date: Thu, 12 Aug 2021 12:56:51 -0700 Message-ID: <162879821159.19113.17550166363142634282@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_125653_318366_611CD98D X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Andy Shevchenko (2021-08-12 10:00:25) > It appears that some code lines raise the question why they are needed > and how they are participated in the calculus of the resulting values. > > Document this in a form of the top comment in the module file. > > Reported-by: Liu Ying > Signed-off-by: Andy Shevchenko > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel