From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372AbbL3I7k (ORCPT ); Wed, 30 Dec 2015 03:59:40 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:58194 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754289AbbL3I7h (ORCPT ); Wed, 30 Dec 2015 03:59:37 -0500 From: Arnd Bergmann To: Rongrong Zou Cc: Rongrong Zou , minyard@acm.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will.deacon@arm.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, lijianhua@huawei.com Subject: Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Date: Wed, 30 Dec 2015 09:59:11 +0100 Message-ID: <1628979.qkJQGmVH0I@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56833234.8010109@huawei.com> References: <1451396032-23708-1-git-send-email-zourongrong@gmail.com> <12016636.UdNIMv3WjG@wuerfel> <56833234.8010109@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rfVYkI1ipmc40BmEYbd//f3J+sAbQGySzEfRGsU/9kohbQE5MXO N/HC+/idGb/duVoOIOAPd6EeyBMIPnf90oNTpUHKseyELeLSftbO9700YKxAy+4UFQepdGd NwPy1HWGlo+HWRDG8/uAMlxtT8xqO+3RgZb/d5mOrsGeoC5B1rcpqh6cE2Ya0NFqB9u1uil wd1PyDaj0CPjLFXTYl53A== X-UI-Out-Filterresults: notjunk:1;V01:K0:5TsGa+WPjcg=:E6jmER02z6/BAELe+9SXla T15NjODA0KDm0abclcbV8NqRYxUchTNZUw3xcH6tvCFF2jGqrPNbT4Hh3Fhl379Ay9EuYbKlg J1AwZ/u8k9LhlziiNetIFT3iZG1P+kzqxZJiDU2AeBf+hfV1hYWBbzpxFz0p1jVs6yuW94YQS nsxUlN7iy++e7bDBNcW8ON+4vo1fMilVV0EP/pQ7TVtFKbbLCVkpI8e4eIPQTul57sIJ5jo8L yrXy8CZVDB9igbP7PSMIGl1nUBLiTNK8wUax2Y6oAnkrZwKNXafu74rZFAISxFXlb5pPNH/BY O7UVg0+oVRMiCZSBAF3mEscATIJZ5wiNlqh7XBPMG755T2MDFVF12cU2koAFqbDQQQE7hqpgl QYA6tkaZEJaHjfaRir5d+Tv7fT17Ipxzlg4wEqueTNg2orjWmAfpOj195W3g+idqIBu/vW+qD qu3dmZ1djqXk0MVKmKSws3gk5jluzHTVOMijEu3f/J7dSECp8lXgJES9IQfPhLBznXjeeq1T4 yKZZ1I+OwieUtSyUVxrLuVJq+DolpluhzDnb2YM91i9LCunD/xK5luXnb7ydxDUPAxSaXkv98 XrJcniBF6wyAGwmuU8jdBv0EsgxQZih5Lh05NUUH3QB7sZnePK+Jafn9PxztIvaPrVQ8ZsN9f 2vy8GjYpXD7TnzNXFAt0b628hpGYXgTTPQB1Ba4R53BaSHSy4TGXcVXxScTKbYgU+9kvCI8I2 EaDYjSKtWTCh+0GV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 30 December 2015 09:24:04 Rongrong Zou wrote: > >>>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > >>>> index 4043c35..98ae206 100644 > >>>> --- a/arch/arm64/Kconfig.platforms > >>>> +++ b/arch/arm64/Kconfig.platforms > >>>> @@ -127,5 +127,8 @@ config ARCH_ZYNQMP > >>>> bool "Xilinx ZynqMP Family" > >>>> help > >>>> This enables support for Xilinx ZynqMP Family > >>>> - > >>>> +config ARM64_INDIRECT_PIO > >>>> + bool "ARM64 Indirect port I/O" > >>>> + help > >>>> + This enables support for ARM64 indirect port I/O > >>>> endmenu > >>> > >>> The option should probably go into arch/arm64/Kconfig. Possibly you can make > >>> it a silent option that just gets selected whenever a driver is enabled > >>> that might set the callbacks. > >> > >> I try to bind it with HISILICON platform. > > > > It should be possible to build the actual driver on all platforms, at > > least with COMPILE_TEST. > > Sorry, I'm a little confused, can you describe it in detail? > > config ARM64_INDIRECT_PIO bool help Any driver that provides indirect ISA I/O port access should select this symbol config HISILICON_HI123456_LPC bool "Workaround for nonstandard ISA I/O space on Hisilicon Hi123456 SoC" depends on ARCH_HISI || COMPILE_TEST select ARM64_INDIRECT_PIO help ... Arnd