From: "J. Bruce Fields" <bfields@redhat.com>
To: Trond Myklebust <trondmy@hammerspace.com>,
Anna Schumaker <schumakeranna@gmail.com>
Cc: daire@dneg.com, linux-nfs@vger.kernel.org,
"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 0/8] reexport lock fixes v2
Date: Mon, 16 Aug 2021 09:59:19 -0400 [thread overview]
Message-ID: <1629122367-18541-1-git-send-email-bfields@redhat.com> (raw)
From: "J. Bruce Fields" <bfields@redhat.com>
The following fix up some problems that can cause crashes or silently
broken lock guarantees in the reexport case.
Not fixed:
- Attempts to reclaim locks after a reboot of the reexport
server will fail. This at least seems like an improvement
over the current situation, which is that they'll succeed even
in cases where they shouldn't. Complete support for reboot
recovery is a bigger job.
- NFSv4.1+ lock nofications don't work. So, clients have to
poll as they do with NFSv4.0, which is suboptimal, but correct
(and an improvement over the current situation, which is a
kernel oops).
So what we have at this point is a suboptimal lock implementation that
doesn't support lock recovery.
Another alternative might be to turn off file locking entirely in the
re-export case. I'd rather take the incremental improvement and fix the
oopses.
Changes since v1:
- Use ENOGRACE instead of returning NFS-specific error from vfs lock
method.
- Take write opens for write locks in the NLM case (as we always
have in the NFSv4 case).
- Don't block NLM threads waiting for blocking locks.
With those changes I'm passing connecthon tests for NFSv3-4.2 reexports
of an NFSv4.0 filesystem.
--b.
J. Bruce Fields (8):
lockd: lockd server-side shouldn't set fl_ops
nlm: minor nlm_lookup_file argument change
nlm: minor refactoring
lockd: update nlm_lookup_file reexport comment
Keep read and write fds with each nlm_file
nfs: don't atempt blocking locks on nfs reexports
lockd: don't attempt blocking locks on nfs reexports
nfs: don't allow reexport reclaims
fs/lockd/svc4proc.c | 6 +-
fs/lockd/svclock.c | 80 +++++++++++++----------
fs/lockd/svcproc.c | 6 +-
fs/lockd/svcsubs.c | 125 +++++++++++++++++++++++++-----------
fs/nfs/export.c | 2 +-
fs/nfs/file.c | 3 +
fs/nfsd/lockd.c | 8 ++-
fs/nfsd/nfs4state.c | 11 +++-
fs/nfsd/nfsproc.c | 1 +
include/linux/errno.h | 1 +
include/linux/exportfs.h | 2 +
include/linux/fs.h | 1 +
include/linux/lockd/bind.h | 3 +-
include/linux/lockd/lockd.h | 13 ++--
14 files changed, 177 insertions(+), 85 deletions(-)
--
2.31.1
next reply other threads:[~2021-08-16 14:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 13:59 J. Bruce Fields [this message]
2021-08-16 13:59 ` [PATCH 1/8] lockd: lockd server-side shouldn't set fl_ops J. Bruce Fields
2021-08-16 13:59 ` [PATCH 2/8] nlm: minor nlm_lookup_file argument change J. Bruce Fields
2021-08-16 13:59 ` [PATCH 3/8] nlm: minor refactoring J. Bruce Fields
2021-08-16 13:59 ` [PATCH 4/8] lockd: update nlm_lookup_file reexport comment J. Bruce Fields
2021-08-16 13:59 ` [PATCH 5/8] Keep read and write fds with each nlm_file J. Bruce Fields
2021-08-16 17:52 ` kernel test robot
2021-08-16 17:52 ` kernel test robot
2021-08-16 17:56 ` kernel test robot
2021-08-16 17:56 ` kernel test robot
2021-08-16 13:59 ` [PATCH 6/8] nfs: don't atempt blocking locks on nfs reexports J. Bruce Fields
2021-08-16 13:59 ` [PATCH 7/8] lockd: don't attempt " J. Bruce Fields
2021-08-16 19:28 ` kernel test robot
2021-08-16 19:28 ` kernel test robot
2021-08-16 13:59 ` [PATCH 8/8] nfs: don't allow reexport reclaims J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629122367-18541-1-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=daire@dneg.com \
--cc=linux-nfs@vger.kernel.org \
--cc=schumakeranna@gmail.com \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.