From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C22A1C4338F for ; Tue, 17 Aug 2021 09:10:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4294E60EE4 for ; Tue, 17 Aug 2021 09:10:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4294E60EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A4A282C2C; Tue, 17 Aug 2021 11:09:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="AnDFZvSg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA0E48296F; Tue, 17 Aug 2021 11:09:45 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0617.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EF38B82C89 for ; Tue, 17 Aug 2021 11:09:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ye.li@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WypZjaEoeAwar9Cqsl4n4jiIgjVkId7HmEkCSLXFz0box2N12mJmJHyqFw6RHjjYmlzqFC4Tx0PynDbj+teZCew/Adww+TC8+FJ4GfyRtEhLysDDzPJ7TQWxugHFvD9dnT5TsxULXLY1LvLFXJKE6TxxVjw9gQRXLdRFC9TFugShgRCXdlEgb3S8RsJ8T/NLRfxqMxHvIC24PZVVp5DAFr4mRCVxjDDGufic1g/+m2fapr6whR5pwBeboxEOpwHmuyFHXqjtLE3J5j5miA9Sqz7MXd1fYbq1qTgBsK3R2ruUN7M0HejWVSukmjSLQkOdcoo5b5QbLpKkK4CTX/aR+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HfxenAUR2N4sFx2KnPZF4bEkfoIfPadbhDy9wUjM30o=; b=LEI1fsMoTczD7LpW8JkdvbU42wp8BfhPYYetey1ngYjFqwPkCrObBIY7jy0g1Dny9OJ5nvXIeVIdbMKFWt9kSafOiLstlVX0ltRb2FP4h73HQpOUYThnzLXYaQxt1ysraBNqIRH6Lklz0LdpI72C/rQb6Xg+UVdepmN0VECkDhvN5VvJM6/ojjKfMmxQJTsrFx5iemuIAnsGwxU0ATFt+EcNPfhGeyE0WlFRGWnfYNxhlKlBfxNzIsgaHVQEubRbkkZBpjRNVf0tVP8fSsqDW80xGHXB9ErMXBxgcTntj9wBrij/RYhoA6biy3dW+scYCma7kjf9oLNMwLZALXthZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HfxenAUR2N4sFx2KnPZF4bEkfoIfPadbhDy9wUjM30o=; b=AnDFZvSgtr560Yi2Tyw8Ni/LNrSoLAh97bD/0xhTSNFQix//5KmsyGUTaXJ60Q+IvIvwpesTtUhlWkMrbdNxdkcRqoAaC2SFZwNNMrzVh1/Wvh2Q8piXIZVNaBqV2pyZPVC2hmAeiAPqTL0NnFIe/TGjVxG/bG0ajBWrQSLEQNQ= Authentication-Results: samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB7069.eurprd04.prod.outlook.com (2603:10a6:800:127::19) by VI1PR04MB6878.eurprd04.prod.outlook.com (2603:10a6:803:12f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Tue, 17 Aug 2021 09:09:36 +0000 Received: from VI1PR04MB7069.eurprd04.prod.outlook.com ([fe80::5d8c:a6f9:c7db:56e4]) by VI1PR04MB7069.eurprd04.prod.outlook.com ([fe80::5d8c:a6f9:c7db:56e4%3]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021 09:09:36 +0000 From: Ye Li To: jh80.chung@samsung.com, u-boot@lists.denx.de, peng.fan@nxp.com Cc: uboot-imx@nxp.com, haibo.chen@nxp.com Subject: [PATCH] mmc: fsl_esdhc_imx: Fix clock disable issue Date: Tue, 17 Aug 2021 17:09:20 +0800 Message-Id: <1629191360-63760-1-git-send-email-ye.li@nxp.com> X-Mailer: git-send-email 2.7.4 Content-Type: text/plain X-ClientProxiedBy: HK2PR02CA0204.apcprd02.prod.outlook.com (2603:1096:201:20::16) To VI1PR04MB7069.eurprd04.prod.outlook.com (2603:10a6:800:127::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ubuntu.localdomain (115.198.187.246) by HK2PR02CA0204.apcprd02.prod.outlook.com (2603:1096:201:20::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.4415.16 via Frontend Transport; Tue, 17 Aug 2021 09:09:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24702c9c-dd15-4ca0-e8e1-08d9615ebc40 X-MS-TrafficTypeDiagnostic: VI1PR04MB6878: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7abdPFGMYjNlexG+hZ4uPe+KJ/NK5aJqK4hJceHyfjLqUHevHIY4JruevRv7fbv2kZ8hCMSE6Ap+EXcNuqODbUN0gZqrn5q9vt8+WXErw8M5nO9KY2PyrV5Ea/10561CoC+Rq4yPU52we37SVzesu3B/4JkPvbLQBI1QXpurE4EP0yC0kEqjhpFef0IFmrbDwEogMwL+DCzoBBVBlVn1f/FeE9R3OZIJ7Y2PlbkEfYylYn+eEQG3yIeRCW6yrx+iTy/D170aBmhohOJOIaYgUo30qCIDdO2AOjQ4ObCCkmpbI/TVkfrvyIC7pOID2BwBGER5EBWsELbw5uPX8OOx1yfFydOLaDM//p4zMAkvlfS6z9jhfFz1DBqJbD2ClJz1/ISN+60xcjznjmXfx+/rZOL9Z5jH+PZ4do84CWffJyhGVrNkFnr9v1x3CrA7o1R19zqxt5hRhc9hwsT3ZE69JQ9YggmQH8863FQOMbez7ItApJfmtBhlCqqeXpojwjQpYni195r34OiGWsgp2aGmdiAhWNRPcrs3Eps3I7H7eQLuuKAgR8+e7kcjUJZa+zBMDOrQWCCudh1M9nSUXAkebyeIUzSI/CNV/n5rtKFtoIaqzMZODxc5gW2PaoI8GNzhORWqDN9upX7ULp1ijJUiiwcROL62kPSnG3qpwBPpcikiwJroQzeqhYob8nvx4DmPl+4B7aOVMQxT6xeq/16pHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB7069.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(376002)(366004)(136003)(44832011)(26005)(2906002)(6636002)(6512007)(8676002)(478600001)(5660300002)(316002)(52116002)(66946007)(66556008)(6666004)(38100700002)(36756003)(6486002)(83380400001)(38350700002)(186003)(6506007)(86362001)(4326008)(66476007)(2616005)(8936002)(956004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DG0SP/MWgcktgXsbmKd71KqCQ4e10KegA4+x15w5MLo+AZCUOzcKOZKkp7cH?= =?us-ascii?Q?/g9W2rbqrfn4pXAVVy06W7JWUdf1X0Is6imJJlRRPJzOPOfaHjvwHwYpIS0+?= =?us-ascii?Q?Rp91hwySCpoflOMvFoD5Z2c/YWTPwjohr8Hj1HvfUwA8bLS9J8VGgWcUSxca?= =?us-ascii?Q?ByW6F/u1Lt6DYNRzKHEGRI6SxLIYWNVCtlRlLdsLZ3Z9a6DYrrNgNHartt9n?= =?us-ascii?Q?QEUgkRV2GNZVGoCurpT8RmCukYGa6zzQwwuezkDbcNe3hz8+/4IHTqO4Wkgw?= =?us-ascii?Q?L8oAnfmWWXdn5wSSF5n+gRpnDSVggZ2JQnqa39v4b31OAb2Kp3U6XuRnGmpf?= =?us-ascii?Q?uzfWbviwQqD9sU4OMMG1Z2zFikJti/cvFysqbcjNQt1goO2p5facQWewbiSW?= =?us-ascii?Q?MO+QodTIr4tQilN3HBIwBEUI4Ut3Ry5Sli7Wulsn7Z2oMogyDr4vlKswrGYb?= =?us-ascii?Q?nSo16VXTg6xrK0NX8b+ND97NVlUMjHubfO+Dyw0F5sX62lVV24jp/N6FeuVT?= =?us-ascii?Q?DOR7sdbjKYkGC5lrJ5zvBQU398NFvtaITNsMR2s5IhCC9Z0aYeCgi92ovd6W?= =?us-ascii?Q?/W8kt3BQ0Z4J7DhXJ5FD3TqOYoH0kzxZ5WvwBJo3IYF5ExpgnvAw27rWlJ7k?= =?us-ascii?Q?3SVDwhdRM6zpdfJynTaf5hrk7wvgShcAQrp6WL5p9Hw0KFpeQTaf1nVEFhsf?= =?us-ascii?Q?jb0i8VyvOmz4iIkeVEIAhyIP66w4xuGpzGrVNUlZ5Pw6UHS88RUZ/wxw4i5m?= =?us-ascii?Q?g2lwZ9C/XZJbtBj8p+cxANxqhEJwM8XgoeyjwIsu9cZ6R6/ESaTjnqwmSDkh?= =?us-ascii?Q?dGAZ+oLegEP2YRlgh4ha+H662AAMno2cJeJBRIO8b9PtPSgytJ4HGiz5A2hc?= =?us-ascii?Q?XmiABASEU1JrHVRuCEJGSLANduck+97/c/mbq5P4EdRvHRteUCEv1ouJJstA?= =?us-ascii?Q?XQVHFRG0RMejFvS4zNRA2ER6jAWhq0nLB9ikuVRpmSKU8nfJeC8j3R/gKlQ2?= =?us-ascii?Q?993wnrAF1QuOUdQIh6u7CxEw4JZjQ6TUOk2443wl0wk0BilmqqTNdD7novQY?= =?us-ascii?Q?MviNz422rotQjGeF/Z0AWGLrkNHXlxf20w2oapLo4VkFfdtJErIbC9h6Psaw?= =?us-ascii?Q?TcrECX2PIETShsI296+cjGIZzi1/3LiI9rHwC+2NAcxipohh3mEhLQrYo1Mk?= =?us-ascii?Q?1aJUipWV+rjCEfhB8e+lXXbxmYApsUXK6ibQhcoup/vicw8b1L/J4WT/G494?= =?us-ascii?Q?dMX7Wu6gBMNn8jc8F2iLyd7lbbXiWPd2XQgj9a6lN9fAcpOMMBwhvzGAp/PL?= =?us-ascii?Q?k8KQWAHfgNGToTp/I/LWMm+s?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24702c9c-dd15-4ca0-e8e1-08d9615ebc40 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7069.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 09:09:36.6868 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sZO6iVrHX4kDStVAYzu5Rb37CKiSbaKhBtG64thWdNfVVYGcitltN4HrAdPnhCHY X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6878 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The SD clock disable is wrapped by MMC_SUPPORTS_TUNING. So it only works when UHS is enabled. However, in SD initialization the power cycle does not depends on UHS. But the power cycle needs disable the SD clock before power down. So this causes a problem when UHS is not enabled. Some cards can't become ready (ACMD14 timeout) due to the clock is enabled during power cycle. Signed-off-by: Ye Li Reviewed-by: Haibo Chen --- drivers/mmc/fsl_esdhc_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c index aabf395..7b67972 100644 --- a/drivers/mmc/fsl_esdhc_imx.c +++ b/drivers/mmc/fsl_esdhc_imx.c @@ -971,7 +971,6 @@ static int esdhc_set_ios_common(struct fsl_esdhc_priv *priv, struct mmc *mmc) if (priv->clock != clock) set_sysctl(priv, mmc, clock); -#ifdef MMC_SUPPORTS_TUNING if (mmc->clk_disable) { #ifdef CONFIG_FSL_USDHC esdhc_clrbits32(®s->vendorspec, VENDORSPEC_CKEN); @@ -987,6 +986,7 @@ static int esdhc_set_ios_common(struct fsl_esdhc_priv *priv, struct mmc *mmc) #endif } +#ifdef MMC_SUPPORTS_TUNING /* * For HS400/HS400ES mode, make sure set the strobe dll in the * target clock rate. So call esdhc_set_strobe_dll() after the -- 2.7.4