From: Neeraj Upadhyay <neeraju@codeaurora.org>
To: paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
joel@joelfernandes.org
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
urezki@gmail.com, frederic@kernel.org, boqun.feng@gmail.com,
Neeraj Upadhyay <neeraju@codeaurora.org>
Subject: [PATCH 2/5] rcu-tasks: Correct firstreport usage in check_all_holdout_tasks_trace
Date: Wed, 18 Aug 2021 12:58:40 +0530 [thread overview]
Message-ID: <1629271723-3816-3-git-send-email-neeraju@codeaurora.org> (raw)
In-Reply-To: <1629271723-3816-1-git-send-email-neeraju@codeaurora.org>
In check_all_holdout_tasks_trace(), firstreport is a pointer argument;
so, check the dereferenced value, instead of checking the pointer.
Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
---
kernel/rcu/tasks.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index e62da45..9db7293 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -1134,7 +1134,7 @@ static void check_all_holdout_tasks_trace(struct list_head *hop,
cpus_read_unlock();
if (needreport) {
- if (firstreport)
+ if (*firstreport)
pr_err("INFO: rcu_tasks_trace detected stalls? (Late IPI?)\n");
show_stalled_ipi_trace();
}
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2021-08-18 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 7:28 [PATCH 0/5] rcu-tasks miscellaneous fixes Neeraj Upadhyay
2021-08-18 7:28 ` [PATCH 1/5] rcu-tasks: Fix s/rcu_add_holdout/trc_add_holdout/ typo in comment Neeraj Upadhyay
2021-08-18 7:28 ` Neeraj Upadhyay [this message]
2021-08-18 7:28 ` [PATCH 3/5] rcu-tasks: Correct check for no_hz_full cpu in show_stalled_task_trace Neeraj Upadhyay
2021-08-18 7:28 ` [PATCH 4/5] rcu-tasks: Fix read-side primitives comment for call_rcu_tasks_trace Neeraj Upadhyay
2021-08-18 15:46 ` Paul E. McKenney
2021-08-18 7:28 ` [PATCH 5/5] rcu-tasks: Clarify read side section info for rcu_tasks_rude GP primitives Neeraj Upadhyay
2021-08-18 15:50 ` [PATCH 0/5] rcu-tasks miscellaneous fixes Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629271723-3816-3-git-send-email-neeraju@codeaurora.org \
--to=neeraju@codeaurora.org \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.