From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3468C4338F for ; Wed, 18 Aug 2021 13:46:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B29F7610A3 for ; Wed, 18 Aug 2021 13:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237100AbhHRNqb (ORCPT ); Wed, 18 Aug 2021 09:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236797AbhHRNq3 (ORCPT ); Wed, 18 Aug 2021 09:46:29 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 859D1C061764; Wed, 18 Aug 2021 06:45:54 -0700 (PDT) Received: by ozlabs.org (Postfix, from userid 1034) id 4GqTgg1gpFz9sVw; Wed, 18 Aug 2021 23:45:51 +1000 (AEST) From: Michael Ellerman To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Michael Ellerman In-Reply-To: <20210805075649.2086567-1-aik@ozlabs.ru> References: <20210805075649.2086567-1-aik@ozlabs.ru> Subject: Re: [PATCH kernel v2] KVM: PPC: Use arch_get_random_seed_long instead of powernv variant Message-Id: <162929392634.3619265.14874763094240884044.b4-ty@ellerman.id.au> Date: Wed, 18 Aug 2021 23:38:46 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 5 Aug 2021 17:56:49 +1000, Alexey Kardashevskiy wrote: > The powernv_get_random_long() does not work in nested KVM (which is > pseries) and produces a crash when accessing in_be64(rng->regs) in > powernv_get_random_long(). > > This replaces powernv_get_random_long with the ppc_md machine hook > wrapper. Applied to powerpc/next. [1/1] KVM: PPC: Use arch_get_random_seed_long instead of powernv variant https://git.kernel.org/powerpc/c/2ac78e0c00184a9ba53d507be7549c69a3f566b6 cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BC2C4338F for ; Wed, 18 Aug 2021 13:49:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A77F3610A1 for ; Wed, 18 Aug 2021 13:49:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A77F3610A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GqTlT0z7cz3dGl for ; Wed, 18 Aug 2021 23:49:09 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org (client-ip=2401:3900:2:1::2; helo=ozlabs.org; envelope-from=michael@ozlabs.org; receiver=) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GqTgq5LWKz3cT1 for ; Wed, 18 Aug 2021 23:45:57 +1000 (AEST) Received: by ozlabs.org (Postfix, from userid 1034) id 4GqTgg1gpFz9sVw; Wed, 18 Aug 2021 23:45:51 +1000 (AEST) From: Michael Ellerman To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org In-Reply-To: <20210805075649.2086567-1-aik@ozlabs.ru> References: <20210805075649.2086567-1-aik@ozlabs.ru> Subject: Re: [PATCH kernel v2] KVM: PPC: Use arch_get_random_seed_long instead of powernv variant Message-Id: <162929392634.3619265.14874763094240884044.b4-ty@ellerman.id.au> Date: Wed, 18 Aug 2021 23:38:46 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 5 Aug 2021 17:56:49 +1000, Alexey Kardashevskiy wrote: > The powernv_get_random_long() does not work in nested KVM (which is > pseries) and produces a crash when accessing in_be64(rng->regs) in > powernv_get_random_long(). > > This replaces powernv_get_random_long with the ppc_md machine hook > wrapper. Applied to powerpc/next. [1/1] KVM: PPC: Use arch_get_random_seed_long instead of powernv variant https://git.kernel.org/powerpc/c/2ac78e0c00184a9ba53d507be7549c69a3f566b6 cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Wed, 18 Aug 2021 13:38:46 +0000 Subject: Re: [PATCH kernel v2] KVM: PPC: Use arch_get_random_seed_long instead of powernv variant Message-Id: <162929392634.3619265.14874763094240884044.b4-ty@ellerman.id.au> List-Id: References: <20210805075649.2086567-1-aik@ozlabs.ru> In-Reply-To: <20210805075649.2086567-1-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Michael Ellerman On Thu, 5 Aug 2021 17:56:49 +1000, Alexey Kardashevskiy wrote: > The powernv_get_random_long() does not work in nested KVM (which is > pseries) and produces a crash when accessing in_be64(rng->regs) in > powernv_get_random_long(). > > This replaces powernv_get_random_long with the ppc_md machine hook > wrapper. Applied to powerpc/next. [1/1] KVM: PPC: Use arch_get_random_seed_long instead of powernv variant https://git.kernel.org/powerpc/c/2ac78e0c00184a9ba53d507be7549c69a3f566b6 cheers