From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43508C4338F for ; Fri, 20 Aug 2021 12:22:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 298CF60FE7 for ; Fri, 20 Aug 2021 12:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240367AbhHTMXG (ORCPT ); Fri, 20 Aug 2021 08:23:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:34604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237882AbhHTMXC (ORCPT ); Fri, 20 Aug 2021 08:23:02 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0878460F45; Fri, 20 Aug 2021 12:22:25 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mH3XT-006BUP-26; Fri, 20 Aug 2021 13:22:23 +0100 From: Marc Zyngier To: Hector Martin , Sven Peter Cc: Will Deacon , linux-kernel@vger.kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/apple-aic: fix irq_disable from within irq handlers Date: Fri, 20 Aug 2021 13:22:18 +0100 Message-Id: <162946212617.2128248.7705849006178271820.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210812100942.17206-1-sven@svenpeter.dev> References: <20210812100942.17206-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: marcan@marcan.st, sven@svenpeter.dev, will@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Aug 2021 12:09:42 +0200, Sven Peter wrote: > When disable_irq_nosync for an interrupt is called from within its > interrupt handler, this interrupt is only marked as disabled with the > intention to mask it when it triggers again. > The AIC hardware however automatically masks the interrupt when it is read. > aic_irq_eoi then unmasks it again if it's not disabled *and* not masked. > This results in a state mismatch between the hardware state and the > state kept in irq_data: The hardware interrupt is masked but > IRQD_IRQ_MASKED is not set. Any further calls to unmask_irq will directly > return and the interrupt can never be enabled again. > > [...] Applied to irq/misc-5.15, thanks! [1/1] irqchip/apple-aic: fix irq_disable from within irq handlers commit: 0fb038ba08dba0a5e937b79a67ed9c21ab5b59c5 Cheers, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B258C4338F for ; Fri, 20 Aug 2021 12:25:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6FCB610CA for ; Fri, 20 Aug 2021 12:25:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6FCB610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VJ/U83UkFF1h1KUUh6k/vMcqCHxj4MnLHkVpO0ousb0=; b=C2b29fGtdQbA0I DZlrwbjun/VI+uVi2xv/1Aeh7Oie/WmAE22771Ln26ToTWxhPJZIY8dBpEbX4nN9CMPHS803saFLN 7dp9PvFI3sQhKxhjug6DyvugUgLisE5n7RZHjNZrO5LU+touzBOEw9TLWETCLYls4v5cJ2P61HENK z5LbGF9GLLUJRh+1Z6DRCxR26xe7y2PX9soe8ZpEfen6nmMKfhPF3pOsfes8my1WFvLubuXhX9p7m hon11/EPKOIgBdN4ucJ2rJ8R3pddGkgIAatk541JHN31aNc3i40qxorVh5kf+F5FxwXukJwi9hWx8 q6VwTMXfP57ozhFpSDtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH3Xf-00B78T-LY; Fri, 20 Aug 2021 12:22:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH3XV-00B77X-Ba for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 12:22:26 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0878460F45; Fri, 20 Aug 2021 12:22:25 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mH3XT-006BUP-26; Fri, 20 Aug 2021 13:22:23 +0100 From: Marc Zyngier To: Hector Martin , Sven Peter Cc: Will Deacon , linux-kernel@vger.kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/apple-aic: fix irq_disable from within irq handlers Date: Fri, 20 Aug 2021 13:22:18 +0100 Message-Id: <162946212617.2128248.7705849006178271820.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210812100942.17206-1-sven@svenpeter.dev> References: <20210812100942.17206-1-sven@svenpeter.dev> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: marcan@marcan.st, sven@svenpeter.dev, will@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_052225_474269_ACA8F6E6 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 12 Aug 2021 12:09:42 +0200, Sven Peter wrote: > When disable_irq_nosync for an interrupt is called from within its > interrupt handler, this interrupt is only marked as disabled with the > intention to mask it when it triggers again. > The AIC hardware however automatically masks the interrupt when it is read. > aic_irq_eoi then unmasks it again if it's not disabled *and* not masked. > This results in a state mismatch between the hardware state and the > state kept in irq_data: The hardware interrupt is masked but > IRQD_IRQ_MASKED is not set. Any further calls to unmask_irq will directly > return and the interrupt can never be enabled again. > > [...] Applied to irq/misc-5.15, thanks! [1/1] irqchip/apple-aic: fix irq_disable from within irq handlers commit: 0fb038ba08dba0a5e937b79a67ed9c21ab5b59c5 Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel