From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5] mk: add sensible default target with
	defconfig
Date: Sat, 05 Aug 2017 10:24:56 +0200
Message-ID: <1629535.s0UyKbnLHZ@xps>
References: <1501842539-1152-1-git-send-email-david.hunt@intel.com>
 <1501843142-22208-1-git-send-email-david.hunt@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: David Hunt <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 85E4037AF
 for <dev@dpdk.org>; Sat,  5 Aug 2017 10:24:58 +0200 (CEST)
In-Reply-To: <1501843142-22208-1-git-send-email-david.hunt@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/08/2017 12:39, David Hunt:
> Users can now use 'make defconfig' to generate a configuration using
> the most appropriate defaults for the current machine.
> 
> <arch-machine-execenv-toolchain>
>   arch taken from uname -m
>   machine defaults to native
>   execenv is taken from uname, Linux=linuxapp, otherwise bsdapp
>   toolchain is taken from $CC -v to see which compiler to use
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
[...]
> --- a/doc/build-sdk-quick.txt
> +++ b/doc/build-sdk-quick.txt
> @@ -1,7 +1,10 @@
>  Basic build
> +	make defconfig && make
> +	or
>  	make config T=x86_64-native-linuxapp-gcc && make

Nice :)

> +	@echo "Configuration done using "$(shell basename \
> +		$(RTE_CONFIG_TEMPLATE) | sed "s/defconfig_//g")

Excuse me for being pedantic with Makefile, I will avoid shell invocation:

+       @echo "Configuration done using" \
+               $(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))


Applied with my pedantic change, thanks :)