From: houlong wei <houlong.wei@mediatek.com> To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Alexandre Courbot" <acourbot@chromium.org>, "kernel@collabora.com" <kernel@collabora.com>, "Enric Balletbo i Serra" <enric.balletbo@collabora.com>, "hverkuil@xs4all.nl" <hverkuil@xs4all.nl>, "dafna3@gmail.com" <dafna3@gmail.com>, "mchehab@kernel.org" <mchehab@kernel.org>, "tfiga@chromium.org" <tfiga@chromium.org>, "Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>, "Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>, "Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>, "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>, "courbot@chromium.org" <courbot@chromium.org>, "hsinyi@chromium.org" <hsinyi@chromium.org>, "eizan@chromium.org" <eizan@chromium.org>, houlong.wei@mediatek.com Subject: Re: [PATCH v3] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer Date: Wed, 25 Aug 2021 18:28:16 +0800 [thread overview] Message-ID: <1629887296.13994.1.camel@mhfsdcap03> (raw) In-Reply-To: <20210825101717.18075-1-dafna.hirschfeld@collabora.com> On Wed, 2021-08-25 at 18:17 +0800, Dafna Hirschfeld wrote: > From: Alexandre Courbot <acourbot@chromium.org> > > When running memcpy_toio: > memcpy_toio(send_obj->share_buf, buf, len); > it was found that errors appear if len is not a multiple of 8: > > [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 > > This patch ensures the copy of a multile of 8 size by calling > round_up(len, 8) when copying > > Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.") > Signed-off-by: Alexandre Courbot <acourbot@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > --- Reviewed-by: Houlong Wei <houlong.wei@mediatek.com> > changes since v2: > 1. do the extra copy only if len is not multiple of 8 > > changes since v1: > 1. change sign-off-by tags > 2. change values to memset > > drivers/media/platform/mtk-vpu/mtk_vpu.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c > index ec290dde59cf..658161ee3e4e 100644 > --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c > +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c > @@ -349,7 +349,16 @@ int vpu_ipi_send(struct platform_device *pdev, > } > } while (vpu_cfg_readl(vpu, HOST_TO_VPU)); > > - memcpy_toio(send_obj->share_buf, buf, len); > + if (len % 8 != 0) { > + unsigned char data[SHARE_BUF_SIZE]; > + > + memset(data + len, 0, sizeof(data) - len); > + memcpy(data, buf, len); > + memcpy_toio(send_obj->share_buf, data, round_up(len, 8)); > + } else { > + memcpy_toio(send_obj->share_buf, buf, len); > + } > + > writel(len, &send_obj->len); > writel(id, &send_obj->id); >
WARNING: multiple messages have this Message-ID (diff)
From: houlong wei <houlong.wei@mediatek.com> To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Alexandre Courbot" <acourbot@chromium.org>, "kernel@collabora.com" <kernel@collabora.com>, "Enric Balletbo i Serra" <enric.balletbo@collabora.com>, "hverkuil@xs4all.nl" <hverkuil@xs4all.nl>, "dafna3@gmail.com" <dafna3@gmail.com>, "mchehab@kernel.org" <mchehab@kernel.org>, "tfiga@chromium.org" <tfiga@chromium.org>, "Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>, "Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>, "Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>, "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>, "courbot@chromium.org" <courbot@chromium.org>, "hsinyi@chromium.org" <hsinyi@chromium.org>, "eizan@chromium.org" <eizan@chromium.org>, houlong.wei@mediatek.com Subject: Re: [PATCH v3] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer Date: Wed, 25 Aug 2021 18:28:16 +0800 [thread overview] Message-ID: <1629887296.13994.1.camel@mhfsdcap03> (raw) In-Reply-To: <20210825101717.18075-1-dafna.hirschfeld@collabora.com> On Wed, 2021-08-25 at 18:17 +0800, Dafna Hirschfeld wrote: > From: Alexandre Courbot <acourbot@chromium.org> > > When running memcpy_toio: > memcpy_toio(send_obj->share_buf, buf, len); > it was found that errors appear if len is not a multiple of 8: > > [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 > > This patch ensures the copy of a multile of 8 size by calling > round_up(len, 8) when copying > > Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.") > Signed-off-by: Alexandre Courbot <acourbot@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > --- Reviewed-by: Houlong Wei <houlong.wei@mediatek.com> > changes since v2: > 1. do the extra copy only if len is not multiple of 8 > > changes since v1: > 1. change sign-off-by tags > 2. change values to memset > > drivers/media/platform/mtk-vpu/mtk_vpu.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c > index ec290dde59cf..658161ee3e4e 100644 > --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c > +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c > @@ -349,7 +349,16 @@ int vpu_ipi_send(struct platform_device *pdev, > } > } while (vpu_cfg_readl(vpu, HOST_TO_VPU)); > > - memcpy_toio(send_obj->share_buf, buf, len); > + if (len % 8 != 0) { > + unsigned char data[SHARE_BUF_SIZE]; > + > + memset(data + len, 0, sizeof(data) - len); > + memcpy(data, buf, len); > + memcpy_toio(send_obj->share_buf, data, round_up(len, 8)); > + } else { > + memcpy_toio(send_obj->share_buf, buf, len); > + } > + > writel(len, &send_obj->len); > writel(id, &send_obj->id); > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-08-25 10:28 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-25 10:17 [PATCH v3] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer Dafna Hirschfeld 2021-08-25 10:17 ` Dafna Hirschfeld 2021-08-25 10:28 ` houlong wei [this message] 2021-08-25 10:28 ` houlong wei 2021-09-01 8:50 ` Hans Verkuil 2021-09-01 8:50 ` Hans Verkuil 2021-09-20 15:19 ` Dafna Hirschfeld 2021-09-20 15:19 ` Dafna Hirschfeld
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1629887296.13994.1.camel@mhfsdcap03 \ --to=houlong.wei@mediatek.com \ --cc=Andrew-CT.Chen@mediatek.com \ --cc=Minghsiu.Tsai@mediatek.com \ --cc=acourbot@chromium.org \ --cc=courbot@chromium.org \ --cc=dafna.hirschfeld@collabora.com \ --cc=dafna3@gmail.com \ --cc=eizan@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=hsinyi@chromium.org \ --cc=hverkuil@xs4all.nl \ --cc=kernel@collabora.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mchehab@kernel.org \ --cc=tfiga@chromium.org \ --cc=tiffany.lin@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.