From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB80DC432BE for ; Wed, 25 Aug 2021 10:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFE32611EF for ; Wed, 25 Aug 2021 10:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239859AbhHYK3Z (ORCPT ); Wed, 25 Aug 2021 06:29:25 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:11043 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S239888AbhHYK3M (ORCPT ); Wed, 25 Aug 2021 06:29:12 -0400 X-UUID: d03e7707fe3e4856be758ec4a7b9bc5e-20210825 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ljYjhZk7xODYifRKLlNuoAeWY2WaxL/PB579A6YFENM=; b=bWqaWLmZ55cjGCFIOCVc4c8MHQaOnk+qyq/MJ4tQuzWkL4RB9P29PrpeU1A87iy7TdvQyRAizZQPTr93eW5ayRGrwVVG1W6jUQcpV6swy+FfKDGZq0As2I7CVJWfEFcAiMFuvMnTruVPDdD05wOFlFamgz6XFvF27sMoq02InYg=; X-UUID: d03e7707fe3e4856be758ec4a7b9bc5e-20210825 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 980542094; Wed, 25 Aug 2021 18:28:22 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N2.mediatek.inc (172.27.4.76) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Aug 2021 18:28:17 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 25 Aug 2021 18:28:16 +0800 Message-ID: <1629887296.13994.1.camel@mhfsdcap03> Subject: Re: [PATCH v3] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer From: houlong wei To: Dafna Hirschfeld CC: "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Alexandre Courbot" , "kernel@collabora.com" , Enric Balletbo i Serra , "hverkuil@xs4all.nl" , "dafna3@gmail.com" , "mchehab@kernel.org" , "tfiga@chromium.org" , "Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?=" , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Tiffany Lin =?UTF-8?Q?=28=E6=9E=97=E6=85=A7=E7=8F=8A=29?= , "matthias.bgg@gmail.com" , "courbot@chromium.org" , "hsinyi@chromium.org" , "eizan@chromium.org" , Date: Wed, 25 Aug 2021 18:28:16 +0800 In-Reply-To: <20210825101717.18075-1-dafna.hirschfeld@collabora.com> References: <20210825101717.18075-1-dafna.hirschfeld@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 01E81F49704AFDF79AFC70AA7CA2ACF2B7B250A311999B359EA670EF2614D5452000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gV2VkLCAyMDIxLTA4LTI1IGF0IDE4OjE3ICswODAwLCBEYWZuYSBIaXJzY2hmZWxkIHdyb3Rl Og0KPiBGcm9tOiBBbGV4YW5kcmUgQ291cmJvdCA8YWNvdXJib3RAY2hyb21pdW0ub3JnPg0KPiAN Cj4gV2hlbiBydW5uaW5nIG1lbWNweV90b2lvOg0KPiBtZW1jcHlfdG9pbyhzZW5kX29iai0+c2hh cmVfYnVmLCBidWYsIGxlbik7DQo+IGl0IHdhcyBmb3VuZCB0aGF0IGVycm9ycyBhcHBlYXIgaWYg bGVuIGlzIG5vdCBhIG11bHRpcGxlIG9mIDg6DQo+IA0KPiBbNTguMzUwODQxXSBtdGstbWRwIDE0 MDAxMDAwLnJkbWE6IHByb2Nlc3NpbmcgZmFpbGVkOiAtMjINCj4gDQo+IFRoaXMgcGF0Y2ggZW5z dXJlcyB0aGUgY29weSBvZiBhIG11bHRpbGUgb2YgOCBzaXplIGJ5IGNhbGxpbmcNCj4gcm91bmRf dXAobGVuLCA4KSB3aGVuIGNvcHlpbmcNCj4gDQo+IEZpeGVzOiBlNjU5OWFkZmFkMzAgKCJtZWRp YTogbXRrLXZwdTogYXZvaWQgdW5hbGlnbmVkIGFjY2VzcyB0byBEVENNIGJ1ZmZlci4iKQ0KPiBT aWduZWQtb2ZmLWJ5OiBBbGV4YW5kcmUgQ291cmJvdCA8YWNvdXJib3RAY2hyb21pdW0ub3JnPg0K PiBTaWduZWQtb2ZmLWJ5OiBFbnJpYyBCYWxsZXRibyBpIFNlcnJhIDxlbnJpYy5iYWxsZXRib0Bj b2xsYWJvcmEuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBEYWZuYSBIaXJzY2hmZWxkIDxkYWZuYS5o aXJzY2hmZWxkQGNvbGxhYm9yYS5jb20+DQo+IC0tLQ0KDQpSZXZpZXdlZC1ieTogSG91bG9uZyBX ZWkgPGhvdWxvbmcud2VpQG1lZGlhdGVrLmNvbT4NCg0KPiBjaGFuZ2VzIHNpbmNlIHYyOg0KPiAx LiBkbyB0aGUgZXh0cmEgY29weSBvbmx5IGlmIGxlbiBpcyBub3QgbXVsdGlwbGUgb2YgOA0KPiAN Cj4gY2hhbmdlcyBzaW5jZSB2MToNCj4gMS4gY2hhbmdlIHNpZ24tb2ZmLWJ5IHRhZ3MNCj4gMi4g Y2hhbmdlIHZhbHVlcyB0byBtZW1zZXQNCj4gDQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL210 ay12cHUvbXRrX3ZwdS5jIHwgMTEgKysrKysrKysrKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS9tdGstdnB1L210a192cHUuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v bXRrLXZwdS9tdGtfdnB1LmMNCj4gaW5kZXggZWMyOTBkZGU1OWNmLi42NTgxNjFlZTNlNGUgMTAw NjQ0DQo+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZwdS9tdGtfdnB1LmMNCj4g KysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdnB1L210a192cHUuYw0KPiBAQCAtMzQ5 LDcgKzM0OSwxNiBAQCBpbnQgdnB1X2lwaV9zZW5kKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYsDQo+ICAJCX0NCj4gIAl9IHdoaWxlICh2cHVfY2ZnX3JlYWRsKHZwdSwgSE9TVF9UT19WUFUp KTsNCj4gIA0KPiAtCW1lbWNweV90b2lvKHNlbmRfb2JqLT5zaGFyZV9idWYsIGJ1ZiwgbGVuKTsN Cj4gKwlpZiAobGVuICUgOCAhPSAwKSB7DQo+ICsJCXVuc2lnbmVkIGNoYXIgZGF0YVtTSEFSRV9C VUZfU0laRV07DQo+ICsNCj4gKwkJbWVtc2V0KGRhdGEgKyBsZW4sIDAsIHNpemVvZihkYXRhKSAt IGxlbik7DQo+ICsJCW1lbWNweShkYXRhLCBidWYsIGxlbik7DQo+ICsJCW1lbWNweV90b2lvKHNl bmRfb2JqLT5zaGFyZV9idWYsIGRhdGEsIHJvdW5kX3VwKGxlbiwgOCkpOw0KPiArCX0gZWxzZSB7 DQo+ICsJCW1lbWNweV90b2lvKHNlbmRfb2JqLT5zaGFyZV9idWYsIGJ1ZiwgbGVuKTsNCj4gKwl9 DQo+ICsNCj4gIAl3cml0ZWwobGVuLCAmc2VuZF9vYmotPmxlbik7DQo+ICAJd3JpdGVsKGlkLCAm c2VuZF9vYmotPmlkKTsNCj4gIA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158AAC4338F for ; Wed, 25 Aug 2021 10:42:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F156610A4 for ; Wed, 25 Aug 2021 10:42:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F156610A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06HaqJNQWUeBj2sIXp+eQHQ3dQOz8snV7vKq+0Oo2Xk=; b=nTaXeMc7prgZ1z RghfFWctcmlHlHKkF8ltnvyaUu7S0d+kWk/mvm7oL8WGME3mp0cOYxwZo0t/i5jiVjAZrTyYVziVN cbjPyBbn5bwRtFoiffVLTbsmDI9uPtb4su9zoyKpSe5sS+2khZmzsKEObG4cUixE/3WEHUJyHAv2N z6km2R0GTXOmRLDym9bgTrT56f1EUKDVecIoCGMZahdkH7U4KaYsVxze+HBOw3v/RL67YHrtI/COa 7l67AUs4ULbRuWp4K1hnrQXV1THQa/53et8x/+DqwJMdl0wE2SSYEPAGJzCYRw87sZ/QxdvcO3HFA DcUFiXYZ3wdY8oogqK3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIqMV-006awV-KW; Wed, 25 Aug 2021 10:42:27 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIq8w-006UZm-64 for linux-mediatek@lists.infradead.org; Wed, 25 Aug 2021 10:28:29 +0000 X-UUID: 686d25dd884e4204bde379ea56ffbce3-20210825 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ljYjhZk7xODYifRKLlNuoAeWY2WaxL/PB579A6YFENM=; b=bWqaWLmZ55cjGCFIOCVc4c8MHQaOnk+qyq/MJ4tQuzWkL4RB9P29PrpeU1A87iy7TdvQyRAizZQPTr93eW5ayRGrwVVG1W6jUQcpV6swy+FfKDGZq0As2I7CVJWfEFcAiMFuvMnTruVPDdD05wOFlFamgz6XFvF27sMoq02InYg=; X-UUID: 686d25dd884e4204bde379ea56ffbce3-20210825 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1487035527; Wed, 25 Aug 2021 03:28:24 -0700 Received: from MTKMBS33N2.mediatek.inc (172.27.4.76) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Aug 2021 03:28:22 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N2.mediatek.inc (172.27.4.76) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Aug 2021 18:28:17 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 25 Aug 2021 18:28:16 +0800 Message-ID: <1629887296.13994.1.camel@mhfsdcap03> Subject: Re: [PATCH v3] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer From: houlong wei To: Dafna Hirschfeld CC: "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Alexandre Courbot" , "kernel@collabora.com" , Enric Balletbo i Serra , "hverkuil@xs4all.nl" , "dafna3@gmail.com" , "mchehab@kernel.org" , "tfiga@chromium.org" , "Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?=" , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Tiffany Lin =?UTF-8?Q?=28=E6=9E=97=E6=85=A7=E7=8F=8A=29?= , "matthias.bgg@gmail.com" , "courbot@chromium.org" , "hsinyi@chromium.org" , "eizan@chromium.org" , Date: Wed, 25 Aug 2021 18:28:16 +0800 In-Reply-To: <20210825101717.18075-1-dafna.hirschfeld@collabora.com> References: <20210825101717.18075-1-dafna.hirschfeld@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 01E81F49704AFDF79AFC70AA7CA2ACF2B7B250A311999B359EA670EF2614D5452000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_032826_296253_AEAFAC36 X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2021-08-25 at 18:17 +0800, Dafna Hirschfeld wrote: > From: Alexandre Courbot > > When running memcpy_toio: > memcpy_toio(send_obj->share_buf, buf, len); > it was found that errors appear if len is not a multiple of 8: > > [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 > > This patch ensures the copy of a multile of 8 size by calling > round_up(len, 8) when copying > > Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.") > Signed-off-by: Alexandre Courbot > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Dafna Hirschfeld > --- Reviewed-by: Houlong Wei > changes since v2: > 1. do the extra copy only if len is not multiple of 8 > > changes since v1: > 1. change sign-off-by tags > 2. change values to memset > > drivers/media/platform/mtk-vpu/mtk_vpu.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c > index ec290dde59cf..658161ee3e4e 100644 > --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c > +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c > @@ -349,7 +349,16 @@ int vpu_ipi_send(struct platform_device *pdev, > } > } while (vpu_cfg_readl(vpu, HOST_TO_VPU)); > > - memcpy_toio(send_obj->share_buf, buf, len); > + if (len % 8 != 0) { > + unsigned char data[SHARE_BUF_SIZE]; > + > + memset(data + len, 0, sizeof(data) - len); > + memcpy(data, buf, len); > + memcpy_toio(send_obj->share_buf, data, round_up(len, 8)); > + } else { > + memcpy_toio(send_obj->share_buf, buf, len); > + } > + > writel(len, &send_obj->len); > writel(id, &send_obj->id); > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek