From: patchwork-bot+netdevbpf@kernel.org
To: Peter Collingbourne <pcc@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, colin.king@canonical.com,
cong.wang@bytedance.com, viro@zeniv.linux.org.uk,
gregkh@linuxfoundation.org, David.Laight@aculab.com,
arnd@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls
Date: Fri, 27 Aug 2021 08:50:06 +0000 [thread overview]
Message-ID: <163005420640.11012.15053925482191718453.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210826194601.3509717-1-pcc@google.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 26 Aug 2021 12:46:01 -0700 you wrote:
> A common implementation of isatty(3) involves calling a ioctl passing
> a dummy struct argument and checking whether the syscall failed --
> bionic and glibc use TCGETS (passing a struct termios), and musl uses
> TIOCGWINSZ (passing a struct winsize). If the FD is a socket, we will
> copy sizeof(struct ifreq) bytes of data from the argument and return
> -EFAULT if that fails. The result is that the isatty implementations
> may return a non-POSIX-compliant value in errno in the case where part
> of the dummy struct argument is inaccessible, as both struct termios
> and struct winsize are smaller than struct ifreq (at least on arm64).
>
> [...]
Here is the summary with links:
- [v2] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls
https://git.kernel.org/netdev/net/c/d0efb16294d1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-08-27 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 19:46 [PATCH v2] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls Peter Collingbourne
2021-08-27 8:50 ` patchwork-bot+netdevbpf [this message]
2021-08-31 16:30 ` Jakub Kicinski
2021-09-01 8:22 ` David Laight
2021-09-01 14:03 ` Jakub Kicinski
2021-09-01 18:01 ` Peter Collingbourne
2021-09-01 23:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163005420640.11012.15053925482191718453.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=David.Laight@aculab.com \
--cc=arnd@kernel.org \
--cc=colin.king@canonical.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pcc@google.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.