From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAEAFC432BE for ; Sun, 29 Aug 2021 04:15:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B5B360E94 for ; Sun, 29 Aug 2021 04:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231902AbhH2EPv (ORCPT ); Sun, 29 Aug 2021 00:15:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:39104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbhH2EPt (ORCPT ); Sun, 29 Aug 2021 00:15:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E981060E08; Sun, 29 Aug 2021 04:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630210498; bh=Qg4wsLXlDpD1zwmlBbHXRGxiCepR2RCY/C5RXovTJYE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=F79Es4jWcaSofx0PWWTDpkY2/fviRSgxhnhtqTkbECFjzGoClSTyA+a9oEQ577Fp8 fZNx0nYTVEKngO+QSmLnLseUouai/6IK4LPYpnqaXUwsHtm5SiknPrQTeTGYpd3uLd Ua2pJArM3EZn/jtl3OnrA91tQsO1RWYQSE4fDa8xfeHx7Mehi7PyK4ioiqzLcRf0Zw yY8emlBZKjUfgAekSdJlix2KEC8hoV5kW9M3GskpDUGiqbNRYtfuVz7jZS/Z//EQ9Q 09fpczCiJOVZ8/G745i57GM4Jp7POE8mXodFz4zLXlWYspBhBeJVJR8s2tnxOuT+YB aHCsx0S1WSJhw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210813032429.14715-4-miles.chen@mediatek.com> References: <20210813032429.14715-1-miles.chen@mediatek.com> <20210813032429.14715-4-miles.chen@mediatek.com> Subject: Re: [RESEND PATCH 3/4] clk: mediatek: support COMMON_CLK_MT6779 module build From: Stephen Boyd Cc: Wendell Lin , Hanks Chen , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, Miles Chen , Lee Jones To: Matthias Brugger , Michael Turquette , Miles Chen Date: Sat, 28 Aug 2021 21:14:56 -0700 Message-ID: <163021049667.2676726.10138202396240942833@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Miles Chen (2021-08-12 20:24:28) > diff --git a/drivers/clk/mediatek/clk-mt6779-aud.c b/drivers/clk/mediatek= /clk-mt6779-aud.c > index 11b209f95e25..439c0bc94b73 100644 > --- a/drivers/clk/mediatek/clk-mt6779-aud.c > +++ b/drivers/clk/mediatek/clk-mt6779-aud.c > @@ -4,6 +4,7 @@ > * Author: Wendell Lin > */ > =20 > +#include > #include > #include > #include > @@ -115,3 +116,4 @@ static struct platform_driver clk_mt6779_aud_drv =3D { > }; > =20 > builtin_platform_driver(clk_mt6779_aud_drv); > +MODULE_LICENSE("GPL"); How does this work? builtin_platform_driver() means that it's not modular code. Shouldn't that be module_platform_driver()? Have you tried loading and unloading the module? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF69C432BE for ; Sun, 29 Aug 2021 04:15:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ECB360F25 for ; Sun, 29 Aug 2021 04:15:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2ECB360F25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PUStnOxgdI/tjJMo+XXwCiH4k7QAcS4ErOM42ir7DDM=; b=U+xQuceO9ZEZfg PZ0H8ttT/2aFc9QUG+oi2Yf/oHieKJbucsPzTtqobl6NQq9Tg72Itq4aJE2b9t5rV6BcIn9Q1j/ik DGqtXKU2SZvdMZYwyHiLpMgzBNjPrqmX8/6UAte3BcLPoKD6l/2p9W/odgds9OSEWIgpsJxWHzZKl Z84MUIocL2pjqPMNuNeegoThnsDA0yJxIrggnlReIxkD4Ne8zw/AUJO9ofF09HRm1Qiod82aYLV1n PF9C9wCNrZGyseOyDDZjWOEtmI2SheMknt4ij2ljs4BvZM9MVuuW+P0XHf0h+Wgjv1k4yyyqNVSyl tkm77bbkElB8b4ZAe2OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKCDw-00EzuF-3p; Sun, 29 Aug 2021 04:15:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKCDi-00Ezt5-VT; Sun, 29 Aug 2021 04:15:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E981060E08; Sun, 29 Aug 2021 04:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630210498; bh=Qg4wsLXlDpD1zwmlBbHXRGxiCepR2RCY/C5RXovTJYE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=F79Es4jWcaSofx0PWWTDpkY2/fviRSgxhnhtqTkbECFjzGoClSTyA+a9oEQ577Fp8 fZNx0nYTVEKngO+QSmLnLseUouai/6IK4LPYpnqaXUwsHtm5SiknPrQTeTGYpd3uLd Ua2pJArM3EZn/jtl3OnrA91tQsO1RWYQSE4fDa8xfeHx7Mehi7PyK4ioiqzLcRf0Zw yY8emlBZKjUfgAekSdJlix2KEC8hoV5kW9M3GskpDUGiqbNRYtfuVz7jZS/Z//EQ9Q 09fpczCiJOVZ8/G745i57GM4Jp7POE8mXodFz4zLXlWYspBhBeJVJR8s2tnxOuT+YB aHCsx0S1WSJhw== MIME-Version: 1.0 In-Reply-To: <20210813032429.14715-4-miles.chen@mediatek.com> References: <20210813032429.14715-1-miles.chen@mediatek.com> <20210813032429.14715-4-miles.chen@mediatek.com> Subject: Re: [RESEND PATCH 3/4] clk: mediatek: support COMMON_CLK_MT6779 module build From: Stephen Boyd Cc: Wendell Lin , Hanks Chen , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, Miles Chen , Lee Jones To: Matthias Brugger , Michael Turquette , Miles Chen Date: Sat, 28 Aug 2021 21:14:56 -0700 Message-ID: <163021049667.2676726.10138202396240942833@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210828_211459_075651_BF59ADD9 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Quoting Miles Chen (2021-08-12 20:24:28) > diff --git a/drivers/clk/mediatek/clk-mt6779-aud.c b/drivers/clk/mediatek/clk-mt6779-aud.c > index 11b209f95e25..439c0bc94b73 100644 > --- a/drivers/clk/mediatek/clk-mt6779-aud.c > +++ b/drivers/clk/mediatek/clk-mt6779-aud.c > @@ -4,6 +4,7 @@ > * Author: Wendell Lin > */ > > +#include > #include > #include > #include > @@ -115,3 +116,4 @@ static struct platform_driver clk_mt6779_aud_drv = { > }; > > builtin_platform_driver(clk_mt6779_aud_drv); > +MODULE_LICENSE("GPL"); How does this work? builtin_platform_driver() means that it's not modular code. Shouldn't that be module_platform_driver()? Have you tried loading and unloading the module? _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEE5C432BE for ; Sun, 29 Aug 2021 04:17:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADBC160F23 for ; Sun, 29 Aug 2021 04:17:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADBC160F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2bLq/xzlVW4VUvZPfMB76UgBg72sqo1dPSY8trNtPMQ=; b=HenmZlBxYcktsy dZ7Kw1cajFqg4BGbXj9n/aIxEYBGnDQiyvqcYscGPaEuawC89njG93uxTQIhHaUrkBO6cpT83n+bq B5NvVVOP4SczoK715XqV/lXMidSXDw00SI8mvLx/89BqX0qN3/P9x6rpUr+89mFRnZKQrlHDSNgcb kOR5SI1FiupdW8FRZJizBsXVmZEqeqttDlI6kigo0XLBc77Ggn1oKuqRQqMEANfa44U94AendjXkc xLz/HGs8fYX2OyypDYshJC9UoasHY5k95n7vMEUJbTQdgXj4fILFd9bTrbUuB3bUoDs2tUz+r6Dai /nRxF4/NUINauKTlwZaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKCDm-00EztZ-Uc; Sun, 29 Aug 2021 04:15:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKCDi-00Ezt5-VT; Sun, 29 Aug 2021 04:15:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E981060E08; Sun, 29 Aug 2021 04:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630210498; bh=Qg4wsLXlDpD1zwmlBbHXRGxiCepR2RCY/C5RXovTJYE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=F79Es4jWcaSofx0PWWTDpkY2/fviRSgxhnhtqTkbECFjzGoClSTyA+a9oEQ577Fp8 fZNx0nYTVEKngO+QSmLnLseUouai/6IK4LPYpnqaXUwsHtm5SiknPrQTeTGYpd3uLd Ua2pJArM3EZn/jtl3OnrA91tQsO1RWYQSE4fDa8xfeHx7Mehi7PyK4ioiqzLcRf0Zw yY8emlBZKjUfgAekSdJlix2KEC8hoV5kW9M3GskpDUGiqbNRYtfuVz7jZS/Z//EQ9Q 09fpczCiJOVZ8/G745i57GM4Jp7POE8mXodFz4zLXlWYspBhBeJVJR8s2tnxOuT+YB aHCsx0S1WSJhw== MIME-Version: 1.0 In-Reply-To: <20210813032429.14715-4-miles.chen@mediatek.com> References: <20210813032429.14715-1-miles.chen@mediatek.com> <20210813032429.14715-4-miles.chen@mediatek.com> Subject: Re: [RESEND PATCH 3/4] clk: mediatek: support COMMON_CLK_MT6779 module build From: Stephen Boyd Cc: Wendell Lin , Hanks Chen , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, Miles Chen , Lee Jones To: Matthias Brugger , Michael Turquette , Miles Chen Date: Sat, 28 Aug 2021 21:14:56 -0700 Message-ID: <163021049667.2676726.10138202396240942833@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210828_211459_075651_BF59ADD9 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Miles Chen (2021-08-12 20:24:28) > diff --git a/drivers/clk/mediatek/clk-mt6779-aud.c b/drivers/clk/mediatek/clk-mt6779-aud.c > index 11b209f95e25..439c0bc94b73 100644 > --- a/drivers/clk/mediatek/clk-mt6779-aud.c > +++ b/drivers/clk/mediatek/clk-mt6779-aud.c > @@ -4,6 +4,7 @@ > * Author: Wendell Lin > */ > > +#include > #include > #include > #include > @@ -115,3 +116,4 @@ static struct platform_driver clk_mt6779_aud_drv = { > }; > > builtin_platform_driver(clk_mt6779_aud_drv); > +MODULE_LICENSE("GPL"); How does this work? builtin_platform_driver() means that it's not modular code. Shouldn't that be module_platform_driver()? Have you tried loading and unloading the module? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel