From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113C3C432BE for ; Mon, 30 Aug 2021 11:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB56A6113E for ; Mon, 30 Aug 2021 11:30:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236523AbhH3LbA (ORCPT ); Mon, 30 Aug 2021 07:31:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:60098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236397AbhH3LbA (ORCPT ); Mon, 30 Aug 2021 07:31:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id E978061139; Mon, 30 Aug 2021 11:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630323007; bh=4tXTk/7KNC+gT+6ButRi4wIIyra4WmcdLPO4LXO3XQU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ridLiZOTVJloHtE+lGqdGk6hc86ff2UKyawWxwFwCK4QSHKZnfeb2iMZZXwIUMUPY 8Q/Q8+kpdfJmfxZ9zepYspzsEupC98yTkh1dTXse/1arlNmrISkbRur7wowMvauww2 UiuXU7IYX+0JTtpLdwuGORRRkcV2LHU2dbjuVZ1PPN1z2Oyp7mVrqqm9TfneuY9iby EEHKRmlbc3Jueq8QT7p+CtD9xakhza4NMV7/IoMDZ1RZDkvbXtv6Hzpp6IOrxqHCHg +zFBs2T216Bq8+jqVHGd47yjFQP0XRkZXWp86wccTPGKkEqjlPXrk9xjLtGaIQxG5f oEcd7yUfk/UDQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2 net] net: qrtr: make checks in qrtr_endpoint_post() stricter From: patchwork-bot+netdevbpf@kernel.org Message-Id: <163032300690.3135.17165027106916962159.git-patchwork-notify@kernel.org> Date: Mon, 30 Aug 2021 11:30:06 +0000 References: <20210830083717.GU7722@kadam> In-Reply-To: <20210830083717.GU7722@kadam> To: Dan Carpenter Cc: mani@kernel.org, loic.poulain@linaro.org, butterflyhuangxx@gmail.com, davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 30 Aug 2021 11:37:17 +0300 you wrote: > These checks are still not strict enough. The main problem is that if > "cb->type == QRTR_TYPE_NEW_SERVER" is true then "len - hdrlen" is > guaranteed to be 4 but we need to be at least 16 bytes. In fact, we > can reject everything smaller than sizeof(*pkt) which is 20 bytes. > > Also I don't like the ALIGN(size, 4). It's better to just insist that > data is needs to be aligned at the start. > > [...] Here is the summary with links: - [v2,net] net: qrtr: make checks in qrtr_endpoint_post() stricter https://git.kernel.org/netdev/net-next/c/aaa8e4922c88 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html