From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2216DC432BE for ; Wed, 1 Sep 2021 02:01:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD5846102A for ; Wed, 1 Sep 2021 02:01:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AD5846102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DdKeefiDQKUc4siRMVRjedL6N+fs6C77ODbD2h/WFaM=; b=LbM2MrPFq2w2s8 ZS9lODAfd+VYXVpIFJet9bwcQjyqhYAx01KEsdTiVQ8cBiHj5oyuHW+1AS6bMvP0goh0p0+vzJGTD Ih6QNz5JoQ0P0lmWUsAZkPIWFnstYKTjUGDHppciFiJOk5Ix6861cuxXD6Bl475X4BooGcNN5GXmC k8yYf9WOB+rk/j9yWrp12CqcLvajPWyhPt0TnzwoMs+i/cFQTz9mka97NjcGWfOq1xXmKW+/QvpDo gK7F2JN7A7KImtCulfW32SxhkVyvp1P7AFDYplNlQ6+EJfUi0lDuaMjh0y21QqVe7G1CcKymFpeuZ D062z6UoCq7jIU51lsWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLFYb-003Z6R-RQ; Wed, 01 Sep 2021 02:00:53 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLFYV-003Z3c-SK; Wed, 01 Sep 2021 02:00:53 +0000 X-UUID: 6491662cbc67404e8a93a7464f94e123-20210831 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ub7a04aXHDVjVK9sBTnKWMjbU6am9jSc/2uqzMU1vgQ=; b=AEfvpOJYjE6rGTv1ga18NvrN30i4SfiTu9aMphY51XGOsorpNw9pRRISGNbkUA6/dy83TObFlUh5PKVZp1IWPikDS8jd9AmbFZy8tGOmodB7oMoHpKzG/Ndj4Zzu8Bm9nuY1ywrl7j0jq7z9xyow2h/VM43nZHupdViUnNcuOSE=; X-UUID: 6491662cbc67404e8a93a7464f94e123-20210831 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 148778375; Tue, 31 Aug 2021 19:00:40 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug 2021 19:00:39 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Sep 2021 10:00:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 1 Sep 2021 10:00:36 +0800 Message-ID: <1630461636.21764.1.camel@mhfsdcap03> Subject: Re: [PATCH v11 2/4] dt-bindings: pinctrl: mt8195: change pull up/down description From: zhiyong.tao To: Rob Herring CC: , , , , , , , , , , , , , , , , Date: Wed, 1 Sep 2021 10:00:36 +0800 In-Reply-To: References: <20210830003603.31864-1-zhiyong.tao@mediatek.com> <20210830003603.31864-3-zhiyong.tao@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_190049_371442_84AC318C X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2021-08-31 at 17:13 -0500, Rob Herring wrote: > On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote: > > Change pull up/down description > > Every commit is a 'change'. Your commit msg should explain 'why', not > what the diff is. > Hi robh, we will add 'why' explanation in the commit msg in v12. > > > > Signed-off-by: Zhiyong Tao > > --- > > .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++-- > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > index 2f12ec59eee5..a341ed9f0095 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > @@ -85,9 +85,35 @@ patternProperties: > > 2/4/6/8/10/12/14/16mA in mt8195. > > enum: [0, 1, 2, 3, 4, 5, 6, 7] > > > > - bias-pull-down: true > > - > > - bias-pull-up: true > > + bias-pull-down: > > + description: | > > + For pull down type is normal, it don't need add RSEL & R1R0 define > > + and resistance value. > > + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > + define in mt8195. > > + For pull down type is RSEL, it can add RSEL define & resistance value(ohm) > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > + "75000" & "5000" in mt8195. > > Sounds like constraints on the values. Please write a schema. > we will add a schema here in v12. Thanks > > + > > + bias-pull-up: > > + description: | > > + For pull up type is normal, it don't need add RSEL & R1R0 define > > + and resistance value. > > + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > + define in mt8195. > > + For pull up type is RSEL, it can add RSEL define & resistance value(ohm) > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195. > > > > bias-disable: true > > > > -- > > 2.18.0 > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331CDC432BE for ; Wed, 1 Sep 2021 02:03:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA46461057 for ; Wed, 1 Sep 2021 02:03:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EA46461057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+EmsJE+HoIPuISmy/iwyJgs84K3i+VKo7mD9s5yHeKU=; b=LCC5lvfYqddtol wE93DoLPSxZriu/kMMOvsZqSViuM8J8vLGWqJ6qzs6mYLCRSBoI+j3WnP60YyhRMxxS7tBAlrN2Ow 5qlaHjju52Rdp/akigpAEjAtpAj7OXST7qE/A0cZw1op5wnDEVfNrkA+cVTfv2x4EtRtRqSKNfR7d yJWkpRELWDf7yF8AkvHDCinwgnlNVkQ6T4Q/lqzzj5XkY6LMWFHRwWv+HIuuKDFTaZvF8QYB7WQxJ G+NvMftIvSkgF3KXGnHcifSavxVo3E/het+cBCRff+rQTPcgWuEuQh5WXpq1fuud7jNrKvfLnD3N1 QRIcaqeXeKVUhmwUydyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLFYd-003Z6X-Ku; Wed, 01 Sep 2021 02:00:55 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLFYV-003Z3c-SK; Wed, 01 Sep 2021 02:00:53 +0000 X-UUID: 6491662cbc67404e8a93a7464f94e123-20210831 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ub7a04aXHDVjVK9sBTnKWMjbU6am9jSc/2uqzMU1vgQ=; b=AEfvpOJYjE6rGTv1ga18NvrN30i4SfiTu9aMphY51XGOsorpNw9pRRISGNbkUA6/dy83TObFlUh5PKVZp1IWPikDS8jd9AmbFZy8tGOmodB7oMoHpKzG/Ndj4Zzu8Bm9nuY1ywrl7j0jq7z9xyow2h/VM43nZHupdViUnNcuOSE=; X-UUID: 6491662cbc67404e8a93a7464f94e123-20210831 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 148778375; Tue, 31 Aug 2021 19:00:40 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug 2021 19:00:39 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Sep 2021 10:00:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 1 Sep 2021 10:00:36 +0800 Message-ID: <1630461636.21764.1.camel@mhfsdcap03> Subject: Re: [PATCH v11 2/4] dt-bindings: pinctrl: mt8195: change pull up/down description From: zhiyong.tao To: Rob Herring CC: , , , , , , , , , , , , , , , , Date: Wed, 1 Sep 2021 10:00:36 +0800 In-Reply-To: References: <20210830003603.31864-1-zhiyong.tao@mediatek.com> <20210830003603.31864-3-zhiyong.tao@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_190049_371442_84AC318C X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-08-31 at 17:13 -0500, Rob Herring wrote: > On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote: > > Change pull up/down description > > Every commit is a 'change'. Your commit msg should explain 'why', not > what the diff is. > Hi robh, we will add 'why' explanation in the commit msg in v12. > > > > Signed-off-by: Zhiyong Tao > > --- > > .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++-- > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > index 2f12ec59eee5..a341ed9f0095 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > @@ -85,9 +85,35 @@ patternProperties: > > 2/4/6/8/10/12/14/16mA in mt8195. > > enum: [0, 1, 2, 3, 4, 5, 6, 7] > > > > - bias-pull-down: true > > - > > - bias-pull-up: true > > + bias-pull-down: > > + description: | > > + For pull down type is normal, it don't need add RSEL & R1R0 define > > + and resistance value. > > + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > + define in mt8195. > > + For pull down type is RSEL, it can add RSEL define & resistance value(ohm) > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > + "75000" & "5000" in mt8195. > > Sounds like constraints on the values. Please write a schema. > we will add a schema here in v12. Thanks > > + > > + bias-pull-up: > > + description: | > > + For pull up type is normal, it don't need add RSEL & R1R0 define > > + and resistance value. > > + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > + define in mt8195. > > + For pull up type is RSEL, it can add RSEL define & resistance value(ohm) > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195. > > > > bias-disable: true > > > > -- > > 2.18.0 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel