From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041ACC432BE for ; Wed, 1 Sep 2021 02:37:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9D376102A for ; Wed, 1 Sep 2021 02:37:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B9D376102A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 448ED894B7; Wed, 1 Sep 2021 02:37:28 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DC37894B7; Wed, 1 Sep 2021 02:37:27 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 65FC9A8830; Wed, 1 Sep 2021 02:37:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Patchwork To: "Matthew Brost" Cc: intel-gfx@lists.freedesktop.org Date: Wed, 01 Sep 2021 02:37:27 -0000 Message-ID: <163046384735.2831.3081711947168083952@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20210901022043.2395135-1-John.C.Harrison@Intel.com> In-Reply-To: <20210901022043.2395135-1-John.C.Harrison@Intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_Enable_GuC_submission_by_default_on_DG1_=28rev2=29?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: Enable GuC submission by default on DG1 (rev2) URL : https://patchwork.freedesktop.org/series/93325/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6980dea021fa drm/i915: Do not define vma on stack 8e2a5b71ad3f drm/i915/guc: put all guc objects in lmem when available 86c5db967bd1 drm/i915/guc: Add DG1 GuC / HuC firmware defs c88604227edc drm/i915/guc: Enable GuC submission by default on DG1 97b71fbd31ae Me: Allow relocs on DG1 for CI -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 1 warnings, 0 checks, 8 lines checked 4ec48c0b396e Me: Workaround LMEM blow up -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 1 warnings, 0 checks, 8 lines checked edda215da5e9 Me: Dump GuC log to dmesg on SLPC load failure -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:17: CHECK:SPACING: No space is necessary after a cast #17: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:267: + (intel_engine_mask_t) ~0U); -:56: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #56: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:1999: + if (!buf) { + drm_err(&i915->drm, "Failed to allocate buffer for error capture!\n"); -:68: WARNING:LINE_SPACING: Missing a blank line after declarations #68: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2011: + ssize_t got = i915_gpu_coredump_copy_to_buffer(error, buf, pos_err, buf_size - 1); + if (got <= 0) -:91: CHECK:BRACES: braces {} should be used on all arms of this statement #91: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2034: + if (count > MAX_CHUNK) { [...] + } else [...] -:97: WARNING:LINE_SPACING: Missing a blank line after declarations #97: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2040: + char chr = ptr[pos]; + ptr[pos] = 0; -:104: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #104: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2047: + drm_info(&i915->drm, "Capture %c%s%c\n", tag[0], ptr2, tag[1]); -:107: CHECK:BRACES: Unbalanced braces around else statement #107: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2050: + } else -:139: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 5 warnings, 3 checks, 118 lines checked