From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D422C432BE for ; Wed, 1 Sep 2021 05:35:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FB3B61090 for ; Wed, 1 Sep 2021 05:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242002AbhIAFgK (ORCPT ); Wed, 1 Sep 2021 01:36:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:35734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233857AbhIAFgJ (ORCPT ); Wed, 1 Sep 2021 01:36:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E2A761059; Wed, 1 Sep 2021 05:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630474513; bh=T1FksYP7QPcFhgT46aKX7pcP5aYxOKXLzlqcQgGkZYk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=aOwBZbY2FDZ46mFnNrSjBp6Tzsrei3zfbZIwQXR8vyecZ2F5Tkx14SM9omWvv19cN zB4cTuGpneYQo9iVOOhvlbXsVpDCesrm4gxsqAtpsQdhHnKgrIBr50dGHIkjQoAV6H pxGhZqXKwE8+88CS0S7kUi2Y2yw3hT6/TEsh91u3LNZoBY5au4U55bqTKqhOCVFwKU kkR9iA3hMSmxce1Jq3CqvuVkhAnY8rQXTm2PXeLEK3jczzXcnkR9bS7MDPXCDQGrqQ ekmiV99x9TUJj96wgfdAD7Av2a5Nx145Ts5Xun6NWilI99kacAvDLsgrJ6/lweI+VE 1DycHtlBXxjHw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20210830182445.167527-1-marijn.suijten@somainline.org> <20210830182445.167527-2-marijn.suijten@somainline.org> <163036177339.2676726.12271104951144475163@swboyd.mtv.corp.google.com> <163036399040.2676726.5816296584899284140@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent From: Stephen Boyd Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Andy Gross , Michael Turquette , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , Abhinav Kumar , Jonathan Marek , Matthias Kaehlcke , Douglas Anderson , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd To: Marijn Suijten Date: Tue, 31 Aug 2021 22:35:12 -0700 Message-ID: <163047451225.42057.10341429266269552927@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Marijn Suijten (2021-08-30 16:10:26) >=20 > I'm 95% sure this shouldn't cause any problems given current DTs and > their history, but that's probably not enough. This might also impact > DTs that have not yet been upstreamed, but afaik the general stance is > to not care and actually serve as a fair hint/warning before new DTs > make it to the list. >=20 > If there is a protocol in place to deprecate, warn, and eventually > remove this reliance on global clock names I'm more than happy to add > .name as a temporary fallback, even if likely unneeded. Otherwise we > might never get rid of it. I'm not aware of any protocol to deprecate, warn, and remove the fallback name. It's a fallback because it can't ever really be removed. Anyway, if you're not willing to add the .name then that's fine. We can deal with the problem easily by adding a .name in the future if someone complains that things aren't working. Sound like a plan? If so, it's probably good to add some sort of note in the commit text so that when the bisector lands on this patch they can realize that this intentionally broke them. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E90C43214 for ; Wed, 1 Sep 2021 05:35:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A7AB61058 for ; Wed, 1 Sep 2021 05:35:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A7AB61058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C36166E049; Wed, 1 Sep 2021 05:35:14 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id C468F6E049; Wed, 1 Sep 2021 05:35:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E2A761059; Wed, 1 Sep 2021 05:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630474513; bh=T1FksYP7QPcFhgT46aKX7pcP5aYxOKXLzlqcQgGkZYk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=aOwBZbY2FDZ46mFnNrSjBp6Tzsrei3zfbZIwQXR8vyecZ2F5Tkx14SM9omWvv19cN zB4cTuGpneYQo9iVOOhvlbXsVpDCesrm4gxsqAtpsQdhHnKgrIBr50dGHIkjQoAV6H pxGhZqXKwE8+88CS0S7kUi2Y2yw3hT6/TEsh91u3LNZoBY5au4U55bqTKqhOCVFwKU kkR9iA3hMSmxce1Jq3CqvuVkhAnY8rQXTm2PXeLEK3jczzXcnkR9bS7MDPXCDQGrqQ ekmiV99x9TUJj96wgfdAD7Av2a5Nx145Ts5Xun6NWilI99kacAvDLsgrJ6/lweI+VE 1DycHtlBXxjHw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20210830182445.167527-1-marijn.suijten@somainline.org> <20210830182445.167527-2-marijn.suijten@somainline.org> <163036177339.2676726.12271104951144475163@swboyd.mtv.corp.google.com> <163036399040.2676726.5816296584899284140@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent From: Stephen Boyd Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Andy Gross , Michael Turquette , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , Abhinav Kumar , Jonathan Marek , Matthias Kaehlcke , Douglas Anderson , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd To: Marijn Suijten Date: Tue, 31 Aug 2021 22:35:12 -0700 Message-ID: <163047451225.42057.10341429266269552927@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Marijn Suijten (2021-08-30 16:10:26) >=20 > I'm 95% sure this shouldn't cause any problems given current DTs and > their history, but that's probably not enough. This might also impact > DTs that have not yet been upstreamed, but afaik the general stance is > to not care and actually serve as a fair hint/warning before new DTs > make it to the list. >=20 > If there is a protocol in place to deprecate, warn, and eventually > remove this reliance on global clock names I'm more than happy to add > .name as a temporary fallback, even if likely unneeded. Otherwise we > might never get rid of it. I'm not aware of any protocol to deprecate, warn, and remove the fallback name. It's a fallback because it can't ever really be removed. Anyway, if you're not willing to add the .name then that's fine. We can deal with the problem easily by adding a .name in the future if someone complains that things aren't working. Sound like a plan? If so, it's probably good to add some sort of note in the commit text so that when the bisector lands on this patch they can realize that this intentionally broke them.