All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Gupta, Anshuman" <anshuman.gupta@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce Intel PXP (rev6)
Date: Thu, 09 Sep 2021 13:14:19 -0000	[thread overview]
Message-ID: <163119325929.16810.5648591882513918813@emeril.freedesktop.org> (raw)
In-Reply-To: <20210909122915.971652-1-daniele.ceraolospurio@intel.com>

== Series Details ==

Series: drm/i915: Introduce Intel PXP (rev6)
URL   : https://patchwork.freedesktop.org/series/90503/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4b04867d778d drm/i915/pxp: Define PXP component interface
-:31: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 49 lines checked
48b326460b6f mei: pxp: export pavp client to me client bus
-:36: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 276 lines checked
95ad0c8a1ff6 drm/i915/pxp: define PXP device flag and kconfig
-:46: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#46: FILE: drivers/gpu/drm/i915/i915_drv.h:1681:
+#define HAS_PXP(dev_priv) (IS_ENABLED(CONFIG_DRM_I915_PXP) && \
+			   INTEL_INFO(dev_priv)->has_pxp) && \
+			   VDBOX_MASK(&dev_priv->gt)

-:46: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#46: FILE: drivers/gpu/drm/i915/i915_drv.h:1681:
+#define HAS_PXP(dev_priv) (IS_ENABLED(CONFIG_DRM_I915_PXP) && \
+			   INTEL_INFO(dev_priv)->has_pxp) && \
+			   VDBOX_MASK(&dev_priv->gt)

total: 1 errors, 0 warnings, 1 checks, 33 lines checked
32d2a598f087 drm/i915/pxp: allocate a vcs context for pxp usage
-:98: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#98: 
new file mode 100644

-:122: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#122: FILE: drivers/gpu/drm/i915/pxp/intel_pxp.c:20:
+	for (engine = gt->engine_class[VIDEO_DECODE_CLASS][0]; !engine; engine++);

total: 1 errors, 1 warnings, 0 checks, 168 lines checked
ce029c5228f4 drm/i915/pxp: Implement funcs to create the TEE channel
-:78: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 148 lines checked
cc2086cc202f drm/i915/pxp: set KCR reg init
6c57836d2dda drm/i915/pxp: Create the arbitrary session after boot
-:98: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#98: 
new file mode 100644

-:383: CHECK:LINE_SPACING: Please don't use multiple blank lines
#383: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_tee_interface.h:36:
+
+

total: 0 errors, 1 warnings, 1 checks, 337 lines checked
10e6202ef0ff drm/i915/pxp: Implement arb session teardown
-:63: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#63: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:153:
+#define   MI_FLUSH_DW_PROTECTED_MEM_EN	(1<<22)
                                       	  ^

-:117: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#117: 
new file mode 100644

total: 0 errors, 1 warnings, 1 checks, 283 lines checked
8098ad3734e4 drm/i915/pxp: Implement PXP irq handler
-:211: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#211: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 423 lines checked
f2ea2f8e1f45 drm/i915/pxp: interfaces for using protected objects
5f170f70a91c drm/i915/pxp: start the arb session on demand
61274982b95b drm/i915/pxp: Enable PXP power management
-:121: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#121: 
new file mode 100644

-:189: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#189: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_pm.h:18:
+}
+static inline void intel_pxp_resume(struct intel_pxp *pxp)

total: 0 errors, 1 warnings, 1 checks, 232 lines checked
48584fd7f1e0 drm/i915/pxp: Add plane decryption support
-:36: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#36: 
v10 (Daniele): update PXP check again to match rework in earlier patches and

total: 0 errors, 1 warnings, 0 checks, 155 lines checked
87c269e251cd drm/i915/pxp: black pixels on pxp disabled
-:169: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#169: FILE: drivers/gpu/drm/i915/i915_reg.h:11411:
+#define PLANE_CSC_COEFF(pipe, plane, index)	_MMIO_PLANE(plane, \
+							    _PLANE_CSC_RY_GY_1(pipe) +  (index) * 4, \
+							    _PLANE_CSC_RY_GY_2(pipe) + (index) * 4)

-:169: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#169: FILE: drivers/gpu/drm/i915/i915_reg.h:11411:
+#define PLANE_CSC_COEFF(pipe, plane, index)	_MMIO_PLANE(plane, \
+							    _PLANE_CSC_RY_GY_1(pipe) +  (index) * 4, \
+							    _PLANE_CSC_RY_GY_2(pipe) + (index) * 4)

-:170: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#170: FILE: drivers/gpu/drm/i915/i915_reg.h:11412:
+							    _PLANE_CSC_RY_GY_1(pipe) +  (index) * 4, \

-:183: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#183: FILE: drivers/gpu/drm/i915/i915_reg.h:11425:
+#define PLANE_CSC_PREOFF(pipe, plane, index)	_MMIO_PLANE(plane, _PLANE_CSC_PREOFF_HI_1(pipe) + \
+							    (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \
+							    (index) * 4)

-:183: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#183: FILE: drivers/gpu/drm/i915/i915_reg.h:11425:
+#define PLANE_CSC_PREOFF(pipe, plane, index)	_MMIO_PLANE(plane, _PLANE_CSC_PREOFF_HI_1(pipe) + \
+							    (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \
+							    (index) * 4)

-:184: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#184: FILE: drivers/gpu/drm/i915/i915_reg.h:11426:
+							    (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \

-:197: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#197: FILE: drivers/gpu/drm/i915/i915_reg.h:11439:
+#define PLANE_CSC_POSTOFF(pipe, plane, index)	_MMIO_PLANE(plane, _PLANE_CSC_POSTOFF_HI_1(pipe) + \
+							    (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \
+							    (index) * 4)

-:197: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#197: FILE: drivers/gpu/drm/i915/i915_reg.h:11439:
+#define PLANE_CSC_POSTOFF(pipe, plane, index)	_MMIO_PLANE(plane, _PLANE_CSC_POSTOFF_HI_1(pipe) + \
+							    (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \
+							    (index) * 4)

-:198: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#198: FILE: drivers/gpu/drm/i915/i915_reg.h:11440:
+							    (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \

total: 0 errors, 3 warnings, 6 checks, 148 lines checked
f9652eddefaa drm/i915/pxp: add pxp debugfs
-:47: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 120 lines checked
0863fbc2021b drm/i915/pxp: add PXP documentation
9f43a759224f drm/i915/pxp: enable PXP for integrated Gen12



  parent reply	other threads:[~2021-09-09 13:14 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 12:28 [PATCH v8 00/17] drm/i915: Introduce Intel PXP Daniele Ceraolo Spurio
2021-09-09 12:28 ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:28 ` [PATCH v8 01/17] drm/i915/pxp: Define PXP component interface Daniele Ceraolo Spurio
2021-09-09 12:28   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 02/17] mei: pxp: export pavp client to me client bus Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [Intel-gfx] [PATCH v8 03/17] drm/i915/pxp: define PXP device flag and kconfig Daniele Ceraolo Spurio
2021-09-09 12:29   ` Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 04/17] drm/i915/pxp: allocate a vcs context for pxp usage Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 05/17] drm/i915/pxp: Implement funcs to create the TEE channel Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 06/17] drm/i915/pxp: set KCR reg init Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 07/17] drm/i915/pxp: Create the arbitrary session after boot Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 08/17] drm/i915/pxp: Implement arb session teardown Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 09/17] drm/i915/pxp: Implement PXP irq handler Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 10/17] drm/i915/pxp: interfaces for using protected objects Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 21:07   ` Rodrigo Vivi
2021-09-10  8:10     ` Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 11/17] drm/i915/pxp: start the arb session on demand Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 12/17] drm/i915/pxp: Enable PXP power management Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 13/17] drm/i915/pxp: Add plane decryption support Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 14/17] drm/i915/pxp: black pixels on pxp disabled Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 15/17] drm/i915/pxp: add pxp debugfs Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 16/17] drm/i915/pxp: add PXP documentation Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 21:25   ` Rodrigo Vivi
2021-09-10  9:52     ` Daniele Ceraolo Spurio
2021-09-09 12:29 ` [PATCH v8 17/17] drm/i915/pxp: enable PXP for integrated Gen12 Daniele Ceraolo Spurio
2021-09-09 12:29   ` [Intel-gfx] " Daniele Ceraolo Spurio
2021-09-09 13:14 ` Patchwork [this message]
2021-09-09 13:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Introduce Intel PXP (rev6) Patchwork
2021-09-09 13:19 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-09-09 13:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-09 15:28 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163119325929.16810.5648591882513918813@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.