From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 345F3C433EF for ; Mon, 13 Sep 2021 09:33:55 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4A7161004; Mon, 13 Sep 2021 09:33:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D4A7161004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1mPiLa-0008Lf-EA; Mon, 13 Sep 2021 09:33:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mPiLY-0008LS-Fx for linux-f2fs-devel@lists.sourceforge.net; Mon, 13 Sep 2021 09:33:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:From:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XvHQOu9l4DP8EFrpN4BTIm0zt0tMEmmBO/olLQkXAI4=; b=lbjSPrUnTlXkpIa9GtkCFvE7OD A3X/ClQkvlyr3qxKJ5qU8VgFKhmossDJHVfs0urtZcnO7gdoFjb4fbD9gJ0LfN4o/zl5aKqPOA8Ye MH+n1n8gT+Umg1/OD9Oce0CXfDTKmRMcTYMjkT6IFScPrfYtDeG9wTiwuAt5X4UyJZnQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:From:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XvHQOu9l4DP8EFrpN4BTIm0zt0tMEmmBO/olLQkXAI4=; b=jSuxUzFfOdn0n2lrb/VMK19l5l 0jlC9QbGwfXFcRdrwnYrY+JFJimGNUQD8GV5sa/+reCLMuhawAkDXIDfEBMP10dSR10Xmq2vmN8p+ TmzQcpyikOzLfC0ea0IYyva3nZCN14QOh2ByCa9t89TLqjpr8GpmXNqdV8i+IhzfL0tM=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mPiLX-0002z1-TJ for linux-f2fs-devel@lists.sourceforge.net; Mon, 13 Sep 2021 09:33:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id EE23561004; Mon, 13 Sep 2021 09:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631525626; bh=cp2igwOu4f/N6poavOzpskXOVS/dM6dEmEfPLkIM0sU=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=ce7OHBBh7wT8Tr/0I3fVYs5P7yQraEVsVqYfm+l4STczrSnbbMry/iZEXZTwRD/yD /vRUmWVZ8jEaj4UPStgNmgfcUg9t9XQh0b6svfmwgqPh9Us7TXhpBoM2EuH1ta6lZ2 metv6InprcmLD810uG9hvgYHHRBmvyh8THxuSW4s= To: ebiggers@google.com, ebiggers@kernel.org, gregkh@linuxfoundation.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org From: Date: Mon, 13 Sep 2021 11:33:36 +0200 In-Reply-To: <20210908215033.1122580-4-ebiggers@kernel.org> Message-ID: <16315256162465@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-Headers-End: 1mPiLX-0002z1-TJ Subject: [f2fs-dev] Patch "f2fs: report correct st_size for encrypted symlinks" has been added to the 4.19-stable tree X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable-commits@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This is a note to let you know that I've just added the patch titled f2fs: report correct st_size for encrypted symlinks to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: f2fs-report-correct-st_size-for-encrypted-symlinks.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Mon Sep 13 11:31:12 AM CEST 2021 From: Eric Biggers Date: Wed, 8 Sep 2021 14:50:32 -0700 Subject: f2fs: report correct st_size for encrypted symlinks To: stable@vger.kernel.org Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org Message-ID: <20210908215033.1122580-4-ebiggers@kernel.org> From: Eric Biggers commit 461b43a8f92e68e96c4424b31e15f2b35f1bbfa9 upstream. The stat() family of syscalls report the wrong size for encrypted symlinks, which has caused breakage in several userspace programs. Fix this by calling fscrypt_symlink_getattr() after f2fs_getattr() for encrypted symlinks. This function computes the correct size by reading and decrypting the symlink target (if it's not already cached). For more details, see the commit which added fscrypt_symlink_getattr(). Fixes: cbaf042a3cc6 ("f2fs crypto: add symlink encryption") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20210702065350.209646-4-ebiggers@kernel.org Signed-off-by: Eric Biggers Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/namei.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -1219,9 +1219,18 @@ static const char *f2fs_encrypted_get_li return target; } +static int f2fs_encrypted_symlink_getattr(const struct path *path, + struct kstat *stat, u32 request_mask, + unsigned int query_flags) +{ + f2fs_getattr(path, stat, request_mask, query_flags); + + return fscrypt_symlink_getattr(path, stat); +} + const struct inode_operations f2fs_encrypted_symlink_inode_operations = { .get_link = f2fs_encrypted_get_link, - .getattr = f2fs_getattr, + .getattr = f2fs_encrypted_symlink_getattr, .setattr = f2fs_setattr, #ifdef CONFIG_F2FS_FS_XATTR .listxattr = f2fs_listxattr, Patches currently in stable-queue which might be from ebiggers@kernel.org are queue-4.19/ubifs-report-correct-st_size-for-encrypted-symlinks.patch queue-4.19/ext4-report-correct-st_size-for-encrypted-symlinks.patch queue-4.19/fscrypt-add-fscrypt_symlink_getattr-for-computing-st_size.patch queue-4.19/f2fs-report-correct-st_size-for-encrypted-symlinks.patch _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A31B9C433F5 for ; Mon, 13 Sep 2021 09:36:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 729866101A for ; Mon, 13 Sep 2021 09:36:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 729866101A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:From:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=a/HbuMuss0Li6dX9VfDmTxD3lajvnVAHuWOEvmy8GLs=; b=aKnuJ5GZqeWJV7 R0RxS3AgYpnGyKyq1DVIJyBTVYsBdOwIuqVl1sG28V8zYnC8G55k3gk5+3Kuuu6FwAY7D9FnCyJ5l ML6/F7G1hpp9SFqSb8Dd5Jmfq33eGCV+pY1pywmIGGBlebnc3F/cQXZm2UL1eDI1icZmtvBc8a0Ha 1+AThBCQQaWwKNq9IY8rK2HurLIEj20Vm51qtmikYd+JK3aBgJTP4EJomJAtHIjXARJoyCry5OD0Z cUbPnc65h9500oK47GvEYBQXHhG27jfU3wbvGXEO3CVRwHWbey8zKOzqP+cN/3bQE2OfrSvkktrs/ GcUCBiQm4TAMm1u/wLeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPiNO-0015WA-PY; Mon, 13 Sep 2021 09:35:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPiLT-00156Q-7U for linux-mtd@lists.infradead.org; Mon, 13 Sep 2021 09:33:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id EE23561004; Mon, 13 Sep 2021 09:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631525626; bh=cp2igwOu4f/N6poavOzpskXOVS/dM6dEmEfPLkIM0sU=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=ce7OHBBh7wT8Tr/0I3fVYs5P7yQraEVsVqYfm+l4STczrSnbbMry/iZEXZTwRD/yD /vRUmWVZ8jEaj4UPStgNmgfcUg9t9XQh0b6svfmwgqPh9Us7TXhpBoM2EuH1ta6lZ2 metv6InprcmLD810uG9hvgYHHRBmvyh8THxuSW4s= Subject: Patch "f2fs: report correct st_size for encrypted symlinks" has been added to the 4.19-stable tree To: ebiggers@google.com, ebiggers@kernel.org, gregkh@linuxfoundation.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org Cc: From: Date: Mon, 13 Sep 2021 11:33:36 +0200 In-Reply-To: <20210908215033.1122580-4-ebiggers@kernel.org> Message-ID: <16315256162465@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_023347_371284_DD6D19AA X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled f2fs: report correct st_size for encrypted symlinks to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: f2fs-report-correct-st_size-for-encrypted-symlinks.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Mon Sep 13 11:31:12 AM CEST 2021 From: Eric Biggers Date: Wed, 8 Sep 2021 14:50:32 -0700 Subject: f2fs: report correct st_size for encrypted symlinks To: stable@vger.kernel.org Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org Message-ID: <20210908215033.1122580-4-ebiggers@kernel.org> From: Eric Biggers commit 461b43a8f92e68e96c4424b31e15f2b35f1bbfa9 upstream. The stat() family of syscalls report the wrong size for encrypted symlinks, which has caused breakage in several userspace programs. Fix this by calling fscrypt_symlink_getattr() after f2fs_getattr() for encrypted symlinks. This function computes the correct size by reading and decrypting the symlink target (if it's not already cached). For more details, see the commit which added fscrypt_symlink_getattr(). Fixes: cbaf042a3cc6 ("f2fs crypto: add symlink encryption") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20210702065350.209646-4-ebiggers@kernel.org Signed-off-by: Eric Biggers Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/namei.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -1219,9 +1219,18 @@ static const char *f2fs_encrypted_get_li return target; } +static int f2fs_encrypted_symlink_getattr(const struct path *path, + struct kstat *stat, u32 request_mask, + unsigned int query_flags) +{ + f2fs_getattr(path, stat, request_mask, query_flags); + + return fscrypt_symlink_getattr(path, stat); +} + const struct inode_operations f2fs_encrypted_symlink_inode_operations = { .get_link = f2fs_encrypted_get_link, - .getattr = f2fs_getattr, + .getattr = f2fs_encrypted_symlink_getattr, .setattr = f2fs_setattr, #ifdef CONFIG_F2FS_FS_XATTR .listxattr = f2fs_listxattr, Patches currently in stable-queue which might be from ebiggers@kernel.org are queue-4.19/ubifs-report-correct-st_size-for-encrypted-symlinks.patch queue-4.19/ext4-report-correct-st_size-for-encrypted-symlinks.patch queue-4.19/fscrypt-add-fscrypt_symlink_getattr-for-computing-st_size.patch queue-4.19/f2fs-report-correct-st_size-for-encrypted-symlinks.patch ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/