From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Peter Zijlstra" <peterz@infradead.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for kernel/locking: Add context to ww_mutex_trylock. (rev4)
Date: Tue, 14 Sep 2021 09:31:10 -0000 [thread overview]
Message-ID: <163161187021.3455.14427323980906484470@emeril.freedesktop.org> (raw)
In-Reply-To: <20210907132044.157225-1-maarten.lankhorst@linux.intel.com>
== Series Details ==
Series: kernel/locking: Add context to ww_mutex_trylock. (rev4)
URL : https://patchwork.freedesktop.org/series/94437/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3e5b7ed1e30d kernel/locking: Add context to ww_mutex_trylock.
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
> > + * ww_mutex_trylock - tries to acquire the w/w mutex with optional acquire context
-:144: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#144: FILE: include/linux/ww_mutex.h:340:
+extern int __must_check ww_mutex_trylock(struct ww_mutex *lock,
-:217: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#217: FILE: kernel/locking/test-ww_mutex.c:20:
+#define ww_acquire_init_noinject(a, b) do { \
+ ww_acquire_init((a), (b)); \
+ (a)->deadlock_inject_countdown = ~0U; \
+ } while (0)
-:372: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
#372: FILE: kernel/locking/test-ww_mutex.c:625:
+ printk(KERN_INFO "Beginning ww mutex selftests\n");
-:405: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
#405: FILE: kernel/locking/test-ww_mutex.c:665:
+ printk(KERN_INFO "All ww mutex selftests passed\n");
-:457: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 3 warnings, 2 checks, 332 lines checked
next prev parent reply other threads:[~2021-09-14 9:31 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 13:20 [PATCH] kernel/locking: Add context to ww_mutex_trylock Maarten Lankhorst
2021-09-07 13:20 ` [Intel-gfx] " Maarten Lankhorst
2021-09-07 13:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-09-07 14:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-07 14:59 ` [PATCH] " kernel test robot
2021-09-07 14:59 ` kernel test robot
2021-09-07 14:59 ` [Intel-gfx] " kernel test robot
2021-09-07 17:28 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-09-08 10:14 ` [PATCH] " Peter Zijlstra
2021-09-08 10:14 ` [Intel-gfx] " Peter Zijlstra
2021-09-08 18:30 ` Daniel Vetter
2021-09-08 18:30 ` [Intel-gfx] " Daniel Vetter
2021-09-09 5:38 ` Maarten Lankhorst
2021-09-09 5:38 ` [Intel-gfx] " Maarten Lankhorst
2021-09-09 8:22 ` Peter Zijlstra
2021-09-09 8:22 ` [Intel-gfx] " Peter Zijlstra
2021-09-09 9:32 ` [PATCH v2] " Maarten Lankhorst
2021-09-09 9:32 ` [Intel-gfx] " Maarten Lankhorst
2021-09-10 15:02 ` Peter Zijlstra
2021-09-10 15:02 ` [Intel-gfx] " Peter Zijlstra
2021-09-10 17:27 ` Peter Zijlstra
2021-09-10 17:27 ` [Intel-gfx] " Peter Zijlstra
2021-09-13 8:42 ` Maarten Lankhorst
2021-09-13 8:42 ` [Intel-gfx] " Maarten Lankhorst
2021-09-14 6:50 ` Peter Zijlstra
2021-09-14 6:50 ` [Intel-gfx] " Peter Zijlstra
2021-09-14 12:43 ` Maarten Lankhorst
2021-09-14 12:43 ` [Intel-gfx] " Maarten Lankhorst
2021-09-14 13:54 ` Daniel Vetter
2021-09-14 13:54 ` [Intel-gfx] " Daniel Vetter
2021-09-16 13:00 ` Maarten Lankhorst
2021-09-16 13:00 ` [Intel-gfx] " Maarten Lankhorst
2021-09-16 13:28 ` Peter Zijlstra
2021-09-16 13:28 ` [Intel-gfx] " Peter Zijlstra
2021-09-17 13:13 ` Peter Zijlstra
2021-09-17 13:13 ` [Intel-gfx] " Peter Zijlstra
2021-09-20 15:02 ` Joonas Lahtinen
2021-09-20 15:02 ` [Intel-gfx] " Joonas Lahtinen
2021-09-17 13:17 ` [tip: locking/core] kernel/locking: Add context to ww_mutex_trylock() tip-bot2 for Maarten Lankhorst
2021-11-04 12:27 ` [PATCH] kernel/locking: Use a pointer in ww_mutex_trylock() Sebastian Andrzej Siewior
2021-11-04 12:27 ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-11-04 12:27 ` Sebastian Andrzej Siewior
2021-11-17 13:59 ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-09-10 18:06 ` [PATCH v2] kernel/locking: Add context to ww_mutex_trylock Mark Brown
2021-09-10 18:06 ` [Intel-gfx] " Mark Brown
2021-09-09 9:50 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for kernel/locking: Add context to ww_mutex_trylock. (rev2) Patchwork
2021-09-10 15:36 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for kernel/locking: Add context to ww_mutex_trylock. (rev3) Patchwork
2021-09-14 9:31 ` Patchwork [this message]
2021-09-14 9:58 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for kernel/locking: Add context to ww_mutex_trylock. (rev4) Patchwork
2021-11-04 16:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for kernel/locking: Add context to ww_mutex_trylock. (rev5) Patchwork
2021-11-04 18:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163161187021.3455.14427323980906484470@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.