All of lore.kernel.org
 help / color / mirror / Atom feed
From: Selvin Xavier <selvin.xavier@broadcom.com>
To: dledford@redhat.com, jgg@nvidia.com
Cc: linux-rdma@vger.kernel.org
Subject: [PATCH for-next v2 10/12] RDMA/bnxt_re: Correct FRMR size calculation
Date: Wed, 15 Sep 2021 05:32:41 -0700	[thread overview]
Message-ID: <1631709163-2287-11-git-send-email-selvin.xavier@broadcom.com> (raw)
In-Reply-To: <1631709163-2287-1-git-send-email-selvin.xavier@broadcom.com>

FRMR WQE requires to provide the log2 value of the
PBL and page size.
Use the standard ilog2 to calculate the log2 value

Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/ib_verbs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index c4d7a9e..1cbc7e1 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -2487,7 +2487,8 @@ static int bnxt_re_build_reg_wqe(const struct ib_reg_wr *wr,
 
 	wqe->frmr.l_key = wr->key;
 	wqe->frmr.length = wr->mr->length;
-	wqe->frmr.pbl_pg_sz_log = (wr->mr->page_size >> PAGE_SHIFT_4K) - 1;
+	wqe->frmr.pbl_pg_sz_log = ilog2(PAGE_SIZE >> PAGE_SHIFT_4K);
+	wqe->frmr.pg_sz_log = ilog2(wr->mr->page_size >> PAGE_SHIFT_4K);
 	wqe->frmr.va = wr->mr->iova;
 	return 0;
 }
-- 
2.5.5


  parent reply	other threads:[~2021-09-15 12:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 12:32 [PATCH for-next v2 00/12] RDMA/bnxt_re: Driver update Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 01/12] RDMA/bnxt_re: Add extended statistics counters Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 02/12] RDMA/bnxt_re: Update statistics counter name Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 03/12] RDMA/bnxt_re: Use separate response buffer for stat_ctx_free Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 04/12] RDMA/bnxt_re: Reduce the delay in polling for hwrm command completion Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 05/12] RDMA/bnxt_re: Support multiple page sizes Selvin Xavier
2021-09-20 13:18   ` Leon Romanovsky
2021-09-15 12:32 ` [PATCH for-next v2 06/12] RDMA/bnxt_re: Suppress unwanted error messages Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 07/12] RDMA/bnxt_re: Fix query SRQ failure Selvin Xavier
2021-09-20 13:19   ` Leon Romanovsky
2021-09-15 12:32 ` [PATCH for-next v2 08/12] RDMA/bnxt_re: Fix FRMR issue with single page MR allocation Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 09/12] RDMA/bnxt_re: Use GFP_KERNEL in non atomic context Selvin Xavier
2021-09-20 13:19   ` Leon Romanovsky
2021-09-15 12:32 ` Selvin Xavier [this message]
2021-09-15 12:32 ` [PATCH for-next v2 11/12] RDMA/bnxt_re: Check if the vlan is valid before reporting Selvin Xavier
2021-09-15 12:32 ` [PATCH for-next v2 12/12] MAINTAINERS: Update Broadcom RDMA maintainers Selvin Xavier
2021-09-20 16:40 ` [PATCH for-next v2 00/12] RDMA/bnxt_re: Driver update Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1631709163-2287-11-git-send-email-selvin.xavier@broadcom.com \
    --to=selvin.xavier@broadcom.com \
    --cc=dledford@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.