From: Antoine Tenart <atenart@kernel.org>
To: José Pekkarinen <jose.pekkarinen@unikie.com>, buildroot@buildroot.org
Cc: José Pekkarinen <jose.pekkarinen@unikie.com>
Subject: Re: [Buildroot] [PATCH] package/refpolicy: Treat all modules as custom
Date: Fri, 17 Sep 2021 19:22:37 +0200 [thread overview]
Message-ID: <163189935709.536094.10717640766848618610@kwain> (raw)
In-Reply-To: <20210830114531.2285178-1-jose.pekkarinen@unikie.com>
Hello José,
Quoting José Pekkarinen (2021-08-30 13:45:31)
> The current processing of the modules doesn't work for
> custom made policies appended through the extra dir mechanism,
> since sed won't find a match for custom modules, it will
> continue without triggering and error. This patch removes
> all the modules from modules.conf and add them one by
> one using REFPOLICY_MODULES values.
I'm failing to see what particular setup the change below would fix.
Could you elaborate on the above? Maybe including configuration
snippets and example of such a module (with the file tree, starting from
REFPOLICY_EXTRA_MODULES_DIRS).
Thanks!
Antoine
> diff --git a/package/refpolicy/refpolicy.mk b/package/refpolicy/refpolicy.mk
> index 0194708b37..1c0a2c3385 100644
> --- a/package/refpolicy/refpolicy.mk
> +++ b/package/refpolicy/refpolicy.mk
> @@ -85,9 +85,9 @@ endef
> # In the context of a monolithic policy enabling a piece of the policy as
> # 'base' or 'module' is equivalent, so we enable them as 'base'.
> define REFPOLICY_CONFIGURE_MODULES
> - $(SED) "s/ = module/ = no/g" $(@D)/policy/modules.conf
> + $(SED) "/ = module/d" $(@D)/policy/modules.conf
> $(foreach m,$(sort $(REFPOLICY_MODULES)),
> - $(SED) "/^$(m) =/c\$(m) = base" $(@D)/policy/modules.conf
> + $(SED) "/^# Module: $(m)/a\$(m) = base" $(@D)/policy/modules.conf
> )
> endef
>
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-17 17:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 11:45 [Buildroot] [PATCH] package/refpolicy: Treat all modules as custom José Pekkarinen
2021-08-30 21:14 ` Thomas Petazzoni
2021-09-17 17:22 ` Antoine Tenart [this message]
2021-09-20 6:01 ` José Pekkarinen
2021-09-20 9:30 ` Antoine Tenart
2021-09-20 9:44 ` José Pekkarinen
2021-09-20 13:21 ` Antoine Tenart
2021-09-20 13:39 ` José Pekkarinen
2021-09-20 13:52 ` Antoine Tenart
2021-09-21 6:29 ` José Pekkarinen
2021-09-21 7:12 ` Antoine Tenart
2021-09-21 13:32 ` José Pekkarinen
2021-09-21 13:42 ` Antoine Tenart
2021-09-22 14:00 ` José Pekkarinen
2021-09-22 14:23 ` Antoine Tenart
2021-09-23 6:26 ` José Pekkarinen
2021-09-23 7:59 ` Antoine Tenart
2021-09-23 8:33 ` Antoine Tenart
2021-09-23 8:47 ` José Pekkarinen
2021-09-23 9:08 ` José Pekkarinen
2021-09-23 9:17 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163189935709.536094.10717640766848618610@kwain \
--to=atenart@kernel.org \
--cc=buildroot@buildroot.org \
--cc=jose.pekkarinen@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.