From: patchwork-bot+netdevbpf@kernel.org
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
gospo@broadcom.com
Subject: Re: [PATCH net] bnxt_en: Fix TX timeout when TX ring size is set to the smallest
Date: Mon, 20 Sep 2021 09:10:07 +0000 [thread overview]
Message-ID: <163212900729.27858.970634646008254924.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <1632120712-17410-1-git-send-email-michael.chan@broadcom.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 20 Sep 2021 02:51:52 -0400 you wrote:
> The smallest TX ring size we support must fit a TX SKB with MAX_SKB_FRAGS
> + 1. Because the first TX BD for a packet is always a long TX BD, we
> need an extra TX BD to fit this packet. Define BNXT_MIN_TX_DESC_CNT with
> this value to make this more clear. The current code uses a minimum
> that is off by 1. Fix it using this constant.
>
> The tx_wake_thresh to determine when to wake up the TX queue is half the
> ring size but we must have at least BNXT_MIN_TX_DESC_CNT for the next
> packet which may have maximum fragments. So the comparison of the
> available TX BDs with tx_wake_thresh should be >= instead of > in the
> current code. Otherwise, at the smallest ring size, we will never wake
> up the TX queue and will cause TX timeout.
>
> [...]
Here is the summary with links:
- [net] bnxt_en: Fix TX timeout when TX ring size is set to the smallest
https://git.kernel.org/netdev/net/c/5bed8b0704c9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-09-20 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 6:51 [PATCH net] bnxt_en: Fix TX timeout when TX ring size is set to the smallest Michael Chan
2021-09-20 9:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163212900729.27858.970634646008254924.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.