From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DE2C433EF for ; Mon, 20 Sep 2021 11:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3126B6054E for ; Mon, 20 Sep 2021 11:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236564AbhITLIU (ORCPT ); Mon, 20 Sep 2021 07:08:20 -0400 Received: from foss.arm.com ([217.140.110.172]:45876 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232382AbhITLIT (ORCPT ); Mon, 20 Sep 2021 07:08:19 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C469B1FB; Mon, 20 Sep 2021 04:06:52 -0700 (PDT) Received: from bogus (unknown [10.57.23.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56A443F719; Mon, 20 Sep 2021 04:06:51 -0700 (PDT) Date: Mon, 20 Sep 2021 12:06:32 +0100 From: Sudeep Holla To: Arnd Bergmann Cc: Igor Skalkin , Peter Hilber , Cristian Marussi , Sudeep Holla , Arnd Bergmann , kernel test robot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] firmware: arm_scmi: remove __exit annotation Message-ID: <163213566221.1958937.10094633298863951666.b4-ty@arm.com> References: <20210920100301.1466486-1-arnd@kernel.org> <20210920100301.1466486-2-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920100301.1466486-2-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 12:02:52PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > virtio_scmi_exit() is only called from __exit function, so the annotation > is correct, but when the driver is built-in, the section gets discarded > and the reference from a callback pointer causes a link-time error: > > `virtio_scmi_exit' referenced in section `.rodata' of drivers/firmware/arm_scmi/virtio.o: defined in discarded section `.exit.text' of drivers/firmware/arm_scmi/virtio.o > > I could not figure out a better workaround, so let's just remove that > annotation even if it wastes a couple of bytes in .text. > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [2/2] firmware: arm_scmi: remove __exit annotation https://git.kernel.org/sudeep.holla/c/1cd73200da -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599D8C433EF for ; Mon, 20 Sep 2021 11:08:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A625610A1 for ; Mon, 20 Sep 2021 11:08:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1A625610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LtAhFyh8BLkeW1OyJKwuDlesof4RrelZlF+un59bZ8Q=; b=4FfbRJ4KeYzNxr JzOuRHt7Lg3r6a0gNnIdLa3Dch5Mi8jxZszkmvMxZcF2j8YJapDw2SmFZE5RuzfolHKvbzs8klqtp 0Dz6AtC/e3tw4AmM8rpA1za4RoNGFiFx00484jwKx8PeWCO1I76sMy7NC2NHEre/ZlNKbwnxLIhqn KzAZeoPHH2CfrpBRfxG0p9H9XWV0H+MxFMMNYPyAOBqf9hpXFV1Mi/1lBO2eSs7m5sjRaNaZA0Ruq WnadkvrTWtROttIwgn4s0CI678adz7mDle9x364ht25PKQUUaiWwMZ1ps0QhENuWP889rd90g9HjL v9Z6p6qqM27SuwVqMv3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSH8V-001MPF-De; Mon, 20 Sep 2021 11:06:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSH8R-001MOf-Tv for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 11:06:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C469B1FB; Mon, 20 Sep 2021 04:06:52 -0700 (PDT) Received: from bogus (unknown [10.57.23.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56A443F719; Mon, 20 Sep 2021 04:06:51 -0700 (PDT) Date: Mon, 20 Sep 2021 12:06:32 +0100 From: Sudeep Holla To: Arnd Bergmann Cc: Igor Skalkin , Peter Hilber , Cristian Marussi , Sudeep Holla , Arnd Bergmann , kernel test robot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] firmware: arm_scmi: remove __exit annotation Message-ID: <163213566221.1958937.10094633298863951666.b4-ty@arm.com> References: <20210920100301.1466486-1-arnd@kernel.org> <20210920100301.1466486-2-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210920100301.1466486-2-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_040656_048023_AE1849D3 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 20, 2021 at 12:02:52PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > virtio_scmi_exit() is only called from __exit function, so the annotation > is correct, but when the driver is built-in, the section gets discarded > and the reference from a callback pointer causes a link-time error: > > `virtio_scmi_exit' referenced in section `.rodata' of drivers/firmware/arm_scmi/virtio.o: defined in discarded section `.exit.text' of drivers/firmware/arm_scmi/virtio.o > > I could not figure out a better workaround, so let's just remove that > annotation even if it wastes a couple of bytes in .text. > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [2/2] firmware: arm_scmi: remove __exit annotation https://git.kernel.org/sudeep.holla/c/1cd73200da -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel