From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3B2C433FE for ; Mon, 20 Sep 2021 23:33:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDEAA61350 for ; Mon, 20 Sep 2021 23:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239747AbhITXfH (ORCPT ); Mon, 20 Sep 2021 19:35:07 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:45376 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238939AbhITXdG (ORCPT ); Mon, 20 Sep 2021 19:33:06 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ACD2E2209E; Mon, 20 Sep 2021 23:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1632180697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+xWJ0YkatGIKOHgIGcojVmd5miNxn0VeGIwFFaZE0g=; b=NIWYSMW7/xcDx9iujTBP2ZVH/ylAswRbkhrJNa8S6dq0m0/Hk6cwP0EwSbMYWJuwHLP4tR G16gMLywCWg9GxCUeEflCtWs8uiA7TmRRJj9RrU5OVxyQ3zdc2bK2lBBRGok0RBfHPXPje SbwcGzL5TN+fQks5SFlkTWZtQK+KCLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1632180697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+xWJ0YkatGIKOHgIGcojVmd5miNxn0VeGIwFFaZE0g=; b=4cGiKRfw6Tdv5gQ50a591jAd2tWJ2v5dWHV/wjFpwW93rfTOpjhhaklqRASgPIhRywUWOl hR4tNr8Pv290q7Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C640613B2E; Mon, 20 Sep 2021 23:31:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4IkQIdUZSWGjaQAAMHmgww (envelope-from ); Mon, 20 Sep 2021 23:31:33 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Mel Gorman" Cc: "Linux-MM" , "Theodore Ts'o" , "Andreas Dilger" , "Darrick J . Wong" , "Matthew Wilcox" , "Michal Hocko" , "Dave Chinner" , "Rik van Riel" , "Vlastimil Babka" , "Johannes Weiner" , "Jonathan Corbet" , "Linux-fsdevel" , "LKML" , "Mel Gorman" Subject: Re: [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made In-reply-to: <20210920085436.20939-4-mgorman@techsingularity.net> References: <20210920085436.20939-1-mgorman@techsingularity.net>, <20210920085436.20939-4-mgorman@techsingularity.net> Date: Tue, 21 Sep 2021 09:31:30 +1000 Message-id: <163218069080.3992.14261132300912173043@noble.neil.brown.name> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Sep 2021, Mel Gorman wrote: > + > + reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS, HZ/10); We always seem to pass "HZ/10" to reclaim_throttle(). Should we just hard-code that in the one place inside reclaim_throttle() itself? NeilBrown