All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology
@ 2021-09-20 17:04 Mark Brown
  2021-09-22 10:07 ` Enric Balletbo i Serra
  2021-09-22 14:21 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2021-09-20 17:04 UTC (permalink / raw)
  To: Cheng-Yi Chiang, Enric Balletbo i Serra, Guenter Roeck,
	Liam Girdwood, Benson Leung
  Cc: alsa-devel, Mark Brown

As part of moving to remove the old style defines for the bus clocks update
the cros_ec_codec driver to use more modern terminology for clocking.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/cros_ec_codec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index a201d652aca2..9b92e1a0d1a3 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -283,8 +283,8 @@ static int i2s_rx_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 	struct ec_param_ec_codec_i2s_rx p;
 	enum ec_codec_i2s_rx_daifmt daifmt;
 
-	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-	case SND_SOC_DAIFMT_CBS_CFS:
+	switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+	case SND_SOC_DAIFMT_CBC_CFC:
 		break;
 	default:
 		return -EINVAL;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology
  2021-09-20 17:04 [PATCH] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology Mark Brown
@ 2021-09-22 10:07 ` Enric Balletbo i Serra
  2021-09-22 14:21 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2021-09-22 10:07 UTC (permalink / raw)
  To: Mark Brown, Cheng-Yi Chiang, Guenter Roeck, Liam Girdwood, Benson Leung
  Cc: alsa-devel

Hi Mark,

On 20/9/21 19:04, Mark Brown wrote:
> As part of moving to remove the old style defines for the bus clocks update
> the cros_ec_codec driver to use more modern terminology for clocking.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Looked at other patches that do the same thing and comparing with those, the
change looks good to me. Also, doesn't seem to affect the device that uses this
codec so.

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
>  sound/soc/codecs/cros_ec_codec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
> index a201d652aca2..9b92e1a0d1a3 100644
> --- a/sound/soc/codecs/cros_ec_codec.c
> +++ b/sound/soc/codecs/cros_ec_codec.c
> @@ -283,8 +283,8 @@ static int i2s_rx_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
>  	struct ec_param_ec_codec_i2s_rx p;
>  	enum ec_codec_i2s_rx_daifmt daifmt;
>  
> -	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> -	case SND_SOC_DAIFMT_CBS_CFS:
> +	switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
> +	case SND_SOC_DAIFMT_CBC_CFC:
>  		break;
>  	default:
>  		return -EINVAL;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology
  2021-09-20 17:04 [PATCH] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology Mark Brown
  2021-09-22 10:07 ` Enric Balletbo i Serra
@ 2021-09-22 14:21 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-09-22 14:21 UTC (permalink / raw)
  To: Benson Leung, Cheng-Yi Chiang, Liam Girdwood,
	Enric Balletbo i Serra, Guenter Roeck, Mark Brown
  Cc: alsa-devel

On Mon, 20 Sep 2021 18:04:14 +0100, Mark Brown wrote:
> As part of moving to remove the old style defines for the bus clocks update
> the cros_ec_codec driver to use more modern terminology for clocking.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology
      commit: 94767044f0c5b66de79a03f1ed02e2515da4fab5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-22 14:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 17:04 [PATCH] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology Mark Brown
2021-09-22 10:07 ` Enric Balletbo i Serra
2021-09-22 14:21 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.