From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 3/4] devtools: remove special case build for perf thread example Date: Thu, 30 Mar 2017 16:31:45 +0200 Message-ID: <1632639.Ait0E45soG@xps13> References: <20170329140419.27149-1-bruce.richardson@intel.com> <20170329163856.10932-1-bruce.richardson@intel.com> <20170329163856.10932-4-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by dpdk.org (Postfix) with ESMTP id 31D82D2AB for ; Thu, 30 Mar 2017 16:31:47 +0200 (CEST) Received: by mail-lf0-f51.google.com with SMTP id x137so28325358lff.3 for ; Thu, 30 Mar 2017 07:31:47 -0700 (PDT) In-Reply-To: <20170329163856.10932-4-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-29 17:38, Bruce Richardson: > Since performance-thread example app is now built as part of make examples > we don't need a special case line for it in testbuild.sh script [...] > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -237,9 +237,6 @@ for conf in $configs ; do > EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > O=$(readlink -m $dir/examples) > ! echo $target | grep -q '^x86_64' || \ > - make -j$J -sC examples/performance-thread \ > - EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > - O=$(readlink -m $dir/examples/performance-thread) You are missing the x86_64 check. This patch should be squashed with the first one.