From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Prashant Malani <pmalani@chromium.org>, linux-kernel@vger.kernel.org
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_proto: Fix check_features ret val
Date: Thu, 30 Sep 2021 08:45:55 +0200 [thread overview]
Message-ID: <163298432635.3251747.6538622508689471214.b4-ty@collabora.com> (raw)
In-Reply-To: <20210916014632.2662612-1-pmalani@chromium.org>
On Wed, 15 Sep 2021 18:46:27 -0700, Prashant Malani wrote:
> The kerneldoc for cros_ec_check_features() states that it returns 1 or 0
> depedending on whether a feature is supported or not, but it instead
> returns a negative error number in one case, and a non-1 bitmask in
> other cases.
>
> Since all call-sites only check for a 1 or 0 return value, update
> the function to return boolean values.
Applied, thanks!
[1/1] platform/chrome: cros_ec_proto: Fix check_features ret val
commit: d50497c4a05e73e76874fd0d4942036375a7ec0f
Best regards,
--
Enric Balletbo i Serra <enric.balletbo@collabora.com>
prev parent reply other threads:[~2021-09-30 6:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 1:46 [PATCH] platform/chrome: cros_ec_proto: Fix check_features ret val Prashant Malani
2021-09-16 2:36 ` Guenter Roeck
2021-09-21 11:42 ` Enric Balletbo i Serra
2021-09-21 17:29 ` Prashant Malani
2021-09-22 9:12 ` Enric Balletbo i Serra
2021-09-22 10:55 ` Prashant Malani
2021-09-22 14:09 ` Enric Balletbo i Serra
2021-09-22 18:47 ` Prashant Malani
2021-09-30 6:45 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163298432635.3251747.6538622508689471214.b4-ty@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.