From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Mon, 17 May 2021 12:54:30 +0200 Subject: [PATCH 1/1] xilinx: disable Unicode capitalization In-Reply-To: References: <20210516091731.26845-1-xypron.glpk@gmx.de> <5784507a-58e5-d6e8-3555-36c033131977@xilinx.com> <24351350-e12b-3ab6-e3d0-6ba0138cdb9e@gmx.de> <2f9dee4a-331b-c5fb-797a-d8a4821790e7@denx.de> <652fe0ee-2eb0-532d-5897-d687e0e90e26@xilinx.com> Message-ID: <1632ff18-6880-3d24-7914-563c1d250d35@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 5/17/21 11:47 AM, Michal Simek wrote: > Hi Stefan, > > On 5/17/21 11:40 AM, Stefan Roese wrote: >> Hi Michal, >> >> On 17.05.21 11:37, Michal Simek wrote: >>> Hi, >>> >>> On 5/17/21 11:04 AM, Stefan Roese wrote: >>>> Added Tom to Cc. >>>> >>>> On 17.05.21 10:01, Heinrich Schuchardt wrote: >>>>> On 17.05.21 08:39, Michal Simek wrote: >>>>>> >>>>>> >>>>>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote: >>>>>>> Save some KiB when building? xilinx_versal_virt_defconfig by >>>>>>> disabling >>>>>>> Unicode capitalization support. This avoids build failures when >>>>>>> adding new >>>>>>> features for the UEFI sub-system. >>>>>>> >>>>>>> Signed-off-by: Heinrich Schuchardt >>>>>>> --- >>>>>>> It would be preferable to have a size check for the u-boot binary. >>>>>>> This would avoid seeing problems only during execution. >>>>>>> --- >>>>>>> ?? configs/xilinx_versal_virt_defconfig | 1 + >>>>>>> ?? 1 file changed, 1 insertion(+) >>>>>>> >>>>>>> diff --git a/configs/xilinx_versal_virt_defconfig >>>>>>> b/configs/xilinx_versal_virt_defconfig >>>>>>> index 707693713a..8bc2ff4a4c 100644 >>>>>>> --- a/configs/xilinx_versal_virt_defconfig >>>>>>> +++ b/configs/xilinx_versal_virt_defconfig >>>>>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300 >>>>>>> ?? CONFIG_USB_GADGET_DOWNLOAD=y >>>>>>> ?? CONFIG_USB_FUNCTION_THOR=y >>>>>>> ?? CONFIG_OF_LIBFDT_OVERLAY=y >>>>>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set >>>>>>> -- >>>>>>> 2.30.2 >>>>>>> >>>>>> >>>>>> What's the build issue? Any log? U-Boot is getting bigger and >>>>>> bigger and >>>>> >>>>> Hello Michal, >>>>> >>>>> this job failed: >>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614 >>>>> >>>>> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success: >>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620 >>>> >>>> I had a similar, most likely related issue a few days ago: >>>> >>>> https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results >>>> >>>> >>>> Tom git bi-sected this to this commit, which only adds a bit tiny bit >>>> of image size I assume: >>>> >>>> "I bisected this down to: >>>> commit 368b3f6db4540f913c436e5287be8356bc9a2891 >>>> Author: Stefan Chulski >>>> Date:?? Mon May 3 08:08:44 2021 +0200 >>>> >>>> ???? phy: introduce 1000BaseX and 2500BaseX modes >>>> >>>> ???? Signed-off-by: Stefan Chulski >>>> ???? Signed-off-by: Stefan Roese >>>> >>>> And while I'm not sure off-hand how it does it, it's causing the >>>> breakage.? Maybe something is overflowing now?" >>> >>> I have rebase Heinrich patches on the top of HEAD + my queue and I can't >>> see any issue >>> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/tree/for-heinrich >>> >>> >>> It means likely what Stefan mentioned is likely correct. >> >> The mentioned PHY patch was not pushed to mainline (yet). Please add >> it: >> >> http://patchwork.ozlabs.org/project/uboot/patch/20210503060853.3743626-2-sr at denx.de/ >> >> and run the test again. > > https://pastebin.com/pd9i8LEi > I have applied this patch and I can't see any issue. > Also pipeline passed without any issue. > https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/pipelines/7558 > > Can you apply this one and try on your end? > http://patchwork.ozlabs.org/project/uboot/patch/7a7c5d657a968190e0676251dbd85a947433d592.1620822936.git.michal.simek at xilinx.com/ > > it is in my queue and when u-boot is bigger then certain limit it can > cause issue with early stack allocation. > > Thanks, > Michal > > > The patch "xilinx: versal: Enable CONFIG_POSITION_INDEPENDENT" with CONFIG_SYS_INIT_SP_BSS_OFFSET=1572864 solves the problem: https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269920 Please, consider adding it to a pull request for v2021.07-rc3. Best regards Heinrich