From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B61C433EF for ; Thu, 30 Sep 2021 15:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0866261A07 for ; Thu, 30 Sep 2021 15:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352099AbhI3PCE (ORCPT ); Thu, 30 Sep 2021 11:02:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:47282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352060AbhI3PBx (ORCPT ); Thu, 30 Sep 2021 11:01:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 70CA761A0D; Thu, 30 Sep 2021 15:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633014011; bh=P3IGvvfLtkYj4sQhVrqizbpeSgN1EKz8MdB6rfmt6VQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uGEBZQcPA1PNmoM+56SzDE1q3OpwENvSX5Q/9eIZu2S7AMG6XA40Srrg5gID6QiTt OynBfCZgpxIoUDTxgbMTxnNo0rEqGJjPedWnkMx8jRhTuOYRxgjK+zMMAVqpxPVsZ3 Y+A3N1PPfBDPzw9unYytOBSLaovrigbowEjugEiG5zLGoMIK12EN7S1t51pfY8Hqkc 9PFx0qNK9jJavWUD8oG04fthopLSSvPGQFYfhEj8aX3nnogqiiO1zLs41zizFs+C8W cKx5dhLOGhJT68/5/xawMntFVV39kZfXapwLJQnaRqv0Qc5Ns6NWoNlzOBDxcaFVq3 jdeqW5kDR9SzQ== From: Mark Brown To: Liam Girdwood , Hans de Goede Cc: Mark Brown , alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH regression fix] ASoC: nau8824: Fix headphone vs headset, button-press detection no longer working Date: Thu, 30 Sep 2021 15:58:57 +0100 Message-Id: <163301248178.43045.235876482448408566.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210929201512.460360-1-hdegoede@redhat.com> References: <20210929201512.460360-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, 29 Sep 2021 22:15:12 +0200, Hans de Goede wrote: > Commit 1d25684e2251 ("ASoC: nau8824: Fix open coded prefix handling") > replaced the nau8824_dapm_enable_pin() helper with direct calls to > snd_soc_dapm_enable_pin(), but the helper was using > snd_soc_dapm_force_enable_pin() and not forcing the MICBIAS + SAR > supplies on breaks headphone vs headset and button-press detection. > > Replace the snd_soc_dapm_enable_pin() calls with > snd_soc_dapm_force_enable_pin() to fix this. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: nau8824: Fix headphone vs headset, button-press detection no longer working commit: 42871e95a3afea8956d8cc567ea725b33a837775 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A733C433F5 for ; Thu, 30 Sep 2021 15:02:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B234160F4A for ; Thu, 30 Sep 2021 15:02:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B234160F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 52A4C16C2; Thu, 30 Sep 2021 17:02:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 52A4C16C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633014171; bh=P3IGvvfLtkYj4sQhVrqizbpeSgN1EKz8MdB6rfmt6VQ=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=c4c8/WFhPB7OwR3//GPhJM6U0GFSfv9VYSOlR/PyPzOZ7i9x13BiItl6YErtPnu7C 4Dw3Cq3UFKpK6ceLElq0WXQcXFysghdb/FZ/qkJT8UagV/stkCo7eAIBzwE13f5AEt /QNmRPBj33Me6JNIMFOlJPTwi+1QyRZNHigM3saM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 46DF3F804F3; Thu, 30 Sep 2021 17:00:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F164F804E4; Thu, 30 Sep 2021 17:00:19 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 238E9F804E3 for ; Thu, 30 Sep 2021 17:00:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 238E9F804E3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uGEBZQcP" Received: by mail.kernel.org (Postfix) with ESMTPSA id 70CA761A0D; Thu, 30 Sep 2021 15:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633014011; bh=P3IGvvfLtkYj4sQhVrqizbpeSgN1EKz8MdB6rfmt6VQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uGEBZQcPA1PNmoM+56SzDE1q3OpwENvSX5Q/9eIZu2S7AMG6XA40Srrg5gID6QiTt OynBfCZgpxIoUDTxgbMTxnNo0rEqGJjPedWnkMx8jRhTuOYRxgjK+zMMAVqpxPVsZ3 Y+A3N1PPfBDPzw9unYytOBSLaovrigbowEjugEiG5zLGoMIK12EN7S1t51pfY8Hqkc 9PFx0qNK9jJavWUD8oG04fthopLSSvPGQFYfhEj8aX3nnogqiiO1zLs41zizFs+C8W cKx5dhLOGhJT68/5/xawMntFVV39kZfXapwLJQnaRqv0Qc5Ns6NWoNlzOBDxcaFVq3 jdeqW5kDR9SzQ== From: Mark Brown To: Liam Girdwood , Hans de Goede Subject: Re: [PATCH regression fix] ASoC: nau8824: Fix headphone vs headset, button-press detection no longer working Date: Thu, 30 Sep 2021 15:58:57 +0100 Message-Id: <163301248178.43045.235876482448408566.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210929201512.460360-1-hdegoede@redhat.com> References: <20210929201512.460360-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Mark Brown , stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 29 Sep 2021 22:15:12 +0200, Hans de Goede wrote: > Commit 1d25684e2251 ("ASoC: nau8824: Fix open coded prefix handling") > replaced the nau8824_dapm_enable_pin() helper with direct calls to > snd_soc_dapm_enable_pin(), but the helper was using > snd_soc_dapm_force_enable_pin() and not forcing the MICBIAS + SAR > supplies on breaks headphone vs headset and button-press detection. > > Replace the snd_soc_dapm_enable_pin() calls with > snd_soc_dapm_force_enable_pin() to fix this. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: nau8824: Fix headphone vs headset, button-press detection no longer working commit: 42871e95a3afea8956d8cc567ea725b33a837775 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark