From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F06C433F5 for ; Thu, 30 Sep 2021 18:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49A276126A for ; Thu, 30 Sep 2021 18:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353156AbhI3SKu (ORCPT ); Thu, 30 Sep 2021 14:10:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:54780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353055AbhI3SKs (ORCPT ); Thu, 30 Sep 2021 14:10:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BDB1D619E2; Thu, 30 Sep 2021 18:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633025345; bh=SpOwuMFeKWDwrjzytoNBM5i8GlBsyHpBPYsWVUY8vzc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=HMSY8R3g3r24iHxPWgUSGYEK92/IjPrnTikT+Rd2bBxrpzpMo3T+kn6kXzOkg04XM y60QgKZprX1Y4latZhhw3LF4v5LeRPkJpS9XUXo47/bTctUdxhWW5WKBtBuHBczwWI v7raU8V8rGQKYjywhmIJiRvdZmXVRrTsX74xHk+ixLly/vBkDS4d0EWcyW6iO67RbZ SuGXdymXonn8i7r9zPbfJYlcugURbovdGtN9is7/Od4KkWnKrFA1bZMaM+w8AzCgSo zPVKzRQwpL2RDo4+3sxGTWhgaMAyDARjBXZDxt6bTHPBXes4rm5DjFMgmBxmWdHTNp WkX0ypgLThqCQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210922125419.4125779-3-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-3-maxime@cerno.tech> Subject: Re: [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Nicolas Saenz Julienne , Florian Fainelli , Michael Stapelberg , Linus Torvalds To: Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Date: Thu, 30 Sep 2021 11:09:04 -0700 Message-ID: <163302534457.358640.9878159260142966969@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Maxime Ripard (2021-09-22 05:54:16) > The driver, once it found a divider, tries to round it up by increasing > the least significant bit of the fractional part by one when the > round_up argument is set and there's a remainder. >=20 > However, since it increases the divider it will actually reduce the > clock rate below what we were asking for, leading to issues with > clk_set_min_rate() that will complain that our rounded clock rate is > below the minimum of the rate. >=20 > Since the dividers are fairly precise already, let's remove that part so > that we can have clk_set_min_rate() working. >=20 > This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round > up ability to the clock divisor"). >=20 > Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock d= ivisor") > Signed-off-by: Maxime Ripard > --- Acked-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3511C433EF for ; Thu, 30 Sep 2021 18:10:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C651619E5 for ; Thu, 30 Sep 2021 18:10:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C651619E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+kt8iSl/GHuRBZu+JYclrCJwMw1+E5cSvdj2v/s6Mrc=; b=oYZ/qm6ZaO+TJU wR/11tJfVP3MDbA8TCl9FNn2tVwXjmypyaJdb/nhsEJ3dIrpmXm7vcWs+IlWYQV+bGfdDDm0i8CW1 re2OpBRlDCOnMV7lQSCLo+JKZiJV/qvseWhmKcgk/faangyzkW9jZiEPkL4XmHmLbQD418dVmEeuv 79Q82MzM3TBENxCuGfpMV8lSblKYuSo+gkLzXlnoUPuACNjzNlYKPnLsm7Ev+mKlyJDE5ME2xFn1h /OGww4wTbZRcaVLYExhVBjsWWVmFcgVTcmQyC1zS667gFrA0FjxcIYbDhKB0/YdKxeN1ZTxIiun8F GzOBPIptl7/MED3Z/EAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW0UX-00FSr2-QW; Thu, 30 Sep 2021 18:09:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW0UU-00FSpx-4w; Thu, 30 Sep 2021 18:09:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BDB1D619E2; Thu, 30 Sep 2021 18:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633025345; bh=SpOwuMFeKWDwrjzytoNBM5i8GlBsyHpBPYsWVUY8vzc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=HMSY8R3g3r24iHxPWgUSGYEK92/IjPrnTikT+Rd2bBxrpzpMo3T+kn6kXzOkg04XM y60QgKZprX1Y4latZhhw3LF4v5LeRPkJpS9XUXo47/bTctUdxhWW5WKBtBuHBczwWI v7raU8V8rGQKYjywhmIJiRvdZmXVRrTsX74xHk+ixLly/vBkDS4d0EWcyW6iO67RbZ SuGXdymXonn8i7r9zPbfJYlcugURbovdGtN9is7/Od4KkWnKrFA1bZMaM+w8AzCgSo zPVKzRQwpL2RDo4+3sxGTWhgaMAyDARjBXZDxt6bTHPBXes4rm5DjFMgmBxmWdHTNp WkX0ypgLThqCQ== MIME-Version: 1.0 In-Reply-To: <20210922125419.4125779-3-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-3-maxime@cerno.tech> Subject: Re: [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Nicolas Saenz Julienne , Florian Fainelli , Michael Stapelberg , Linus Torvalds To: Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Date: Thu, 30 Sep 2021 11:09:04 -0700 Message-ID: <163302534457.358640.9878159260142966969@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_110906_236020_3B8068E3 X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Maxime Ripard (2021-09-22 05:54:16) > The driver, once it found a divider, tries to round it up by increasing > the least significant bit of the fractional part by one when the > round_up argument is set and there's a remainder. > > However, since it increases the divider it will actually reduce the > clock rate below what we were asking for, leading to issues with > clk_set_min_rate() that will complain that our rounded clock rate is > below the minimum of the rate. > > Since the dividers are fairly precise already, let's remove that part so > that we can have clk_set_min_rate() working. > > This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round > up ability to the clock divisor"). > > Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock divisor") > Signed-off-by: Maxime Ripard > --- Acked-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel