All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] Block fixes for 5.15-rc4
@ 2021-10-02  2:06 Jens Axboe
  2021-10-02 18:06 ` Linus Torvalds
  2021-10-02 18:07 ` pr-tracker-bot
  0 siblings, 2 replies; 6+ messages in thread
From: Jens Axboe @ 2021-10-02  2:06 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-block

Hi Linus,

A few block fixes for this release:

- Revert a BFQ commit that causes breakage for people. Unfortunately it
  was auto-selected for stable as well, so now 5.14.7 suffers from it
  too. Hopefully stable will pick up this revert quickly too, so we can
  remove the issue on that end as well.

- Add a quirk for Apple NVMe controllers, which due to their
  non-compliance broke due to the introduction of command sequences
  (Keith)

- Use shifts in nbd, fixing a __divdi3 issue (Nick)

Please pull!


The following changes since commit f278eb3d8178f9c31f8dfad7e91440e603dd7f1a:

  block: hold ->invalidate_lock in blkdev_fallocate (2021-09-24 11:06:58 -0600)

are available in the Git repository at:

  git://git.kernel.dk/linux-block.git tags/block-5.15-2021-10-01

for you to fetch changes up to 41e76c6a3c83c85e849f10754b8632ea763d9be4:

  nbd: use shifts rather than multiplies (2021-09-29 20:31:41 -0600)

----------------------------------------------------------------
block-5.15-2021-10-01

----------------------------------------------------------------
Jens Axboe (1):
      Revert "block, bfq: honor already-setup queue merges"

Keith Busch (1):
      nvme: add command id quirk for apple controllers

Nick Desaulniers (1):
      nbd: use shifts rather than multiplies

 block/bfq-iosched.c      | 16 +++-------------
 drivers/block/nbd.c      | 29 +++++++++++++++++------------
 drivers/nvme/host/core.c |  4 +++-
 drivers/nvme/host/nvme.h |  6 ++++++
 drivers/nvme/host/pci.c  |  3 ++-
 5 files changed, 31 insertions(+), 27 deletions(-)

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Block fixes for 5.15-rc4
  2021-10-02  2:06 [GIT PULL] Block fixes for 5.15-rc4 Jens Axboe
@ 2021-10-02 18:06 ` Linus Torvalds
  2021-10-02 19:01   ` Jens Axboe
                     ` (2 more replies)
  2021-10-02 18:07 ` pr-tracker-bot
  1 sibling, 3 replies; 6+ messages in thread
From: Linus Torvalds @ 2021-10-02 18:06 UTC (permalink / raw)
  To: Jens Axboe, Aditya Garg; +Cc: linux-block

On Fri, Oct 1, 2021 at 7:06 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> - Add a quirk for Apple NVMe controllers, which due to their
>   non-compliance broke due to the introduction of command sequences
>   (Keith)

Pulled.

Did we get confirmation that this fixes the issue for Aditya? I just
remember seeing issues with some of the proposed patches, but I think
there was an additional problem that was specific to the Apple M1, so
I may be confused.

              Linus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Block fixes for 5.15-rc4
  2021-10-02  2:06 [GIT PULL] Block fixes for 5.15-rc4 Jens Axboe
  2021-10-02 18:06 ` Linus Torvalds
@ 2021-10-02 18:07 ` pr-tracker-bot
  1 sibling, 0 replies; 6+ messages in thread
From: pr-tracker-bot @ 2021-10-02 18:07 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linus Torvalds, linux-block

The pull request you sent on Fri, 1 Oct 2021 20:06:05 -0600:

> git://git.kernel.dk/linux-block.git tags/block-5.15-2021-10-01

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ab2a7a35c4e7e848de9a7cf70f36b62584154140

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Block fixes for 5.15-rc4
  2021-10-02 18:06 ` Linus Torvalds
@ 2021-10-02 19:01   ` Jens Axboe
  2021-10-03  2:08   ` Keith Busch
       [not found]   ` <PNZPR01MB4415C6C1CED76358BC8089A4B8AD9@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
  2 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2021-10-02 19:01 UTC (permalink / raw)
  To: Linus Torvalds, Aditya Garg; +Cc: linux-block

On 10/2/21 12:06 PM, Linus Torvalds wrote:
> On Fri, Oct 1, 2021 at 7:06 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> - Add a quirk for Apple NVMe controllers, which due to their
>>   non-compliance broke due to the introduction of command sequences
>>   (Keith)
> 
> Pulled.

Great, thanks.

> Did we get confirmation that this fixes the issue for Aditya? I just
> remember seeing issues with some of the proposed patches, but I think
> there was an additional problem that was specific to the Apple M1, so
> I may be confused.

Yes, Aditya confirmed that applying it to 5.14.7 fixed the issue there.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Block fixes for 5.15-rc4
  2021-10-02 18:06 ` Linus Torvalds
  2021-10-02 19:01   ` Jens Axboe
@ 2021-10-03  2:08   ` Keith Busch
       [not found]   ` <PNZPR01MB4415C6C1CED76358BC8089A4B8AD9@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
  2 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2021-10-03  2:08 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Jens Axboe, Aditya Garg, linux-block

On Sat, Oct 02, 2021 at 11:06:21AM -0700, Linus Torvalds wrote:
> On Fri, Oct 1, 2021 at 7:06 PM Jens Axboe <axboe@kernel.dk> wrote:
> >
> > - Add a quirk for Apple NVMe controllers, which due to their
> >   non-compliance broke due to the introduction of command sequences
> >   (Keith)
> 
> Pulled.
> 
> Did we get confirmation that this fixes the issue for Aditya? I just
> remember seeing issues with some of the proposed patches, but I think
> there was an additional problem that was specific to the Apple M1, so
> I may be confused.

Yes, the tested-by came in a little after the patch was applied so we
missed including the tag, but here's the confirmation:

  https://lkml.org/lkml/2021/9/28/50

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Block fixes for 5.15-rc4
       [not found]   ` <PNZPR01MB4415C6C1CED76358BC8089A4B8AD9@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
@ 2021-10-03  5:24     ` Aditya Garg
  0 siblings, 0 replies; 6+ messages in thread
From: Aditya Garg @ 2021-10-03  5:24 UTC (permalink / raw)
  To: Linus Torvalds, Jens Axboe; +Cc: linux-block

One thing I forgot to mention was that some of the hunks of this patch failed to apply on 5.10.69 LTS, making me unable to test it over there, since 5.10.67 onwards, the same issue was seen.

> On 03-Oct-2021, at 9:57 AM, Aditya Garg <gargaditya08@live.com> wrote:
> 
> I tested this and it works for me. Thank you for the time of all the developers who helped to get this issue resolved.
> From: Linus Torvalds <torvalds@linux-foundation.org>
> Sent: Saturday, October 2, 2021 11:36:21 PM
> To: Jens Axboe <axboe@kernel.dk>; Aditya Garg <gargaditya08@live.com>
> Cc: linux-block@vger.kernel.org <linux-block@vger.kernel.org>
> Subject: Re: [GIT PULL] Block fixes for 5.15-rc4
>  
> On Fri, Oct 1, 2021 at 7:06 PM Jens Axboe <axboe@kernel.dk> wrote:
> >
> > - Add a quirk for Apple NVMe controllers, which due to their
> >   non-compliance broke due to the introduction of command sequences
> >   (Keith)
> 
> Pulled.
> 
> Did we get confirmation that this fixes the issue for Aditya? I just
> remember seeing issues with some of the proposed patches, but I think
> there was an additional problem that was specific to the Apple M1, so
> I may be confused.
> 
>               Linus


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-03  5:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-02  2:06 [GIT PULL] Block fixes for 5.15-rc4 Jens Axboe
2021-10-02 18:06 ` Linus Torvalds
2021-10-02 19:01   ` Jens Axboe
2021-10-03  2:08   ` Keith Busch
     [not found]   ` <PNZPR01MB4415C6C1CED76358BC8089A4B8AD9@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-10-03  5:24     ` Aditya Garg
2021-10-02 18:07 ` pr-tracker-bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.