All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, roopa@nvidia.com,
	donaldsharp72@gmail.com, dsahern@gmail.com, idosch@idosch.org,
	nikolay@nvidia.com
Subject: Re: [PATCH iproute2-next 00/12] ip: nexthop: cache nexthops and print routes' nh info
Date: Mon, 04 Oct 2021 00:40:08 +0000	[thread overview]
Message-ID: <163330800881.10241.15878981717990557235.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210930113844.1829373-1-razor@blackwall.org>

Hello:

This series was applied to iproute2/iproute2-next.git (refs/heads/main):

On Thu, 30 Sep 2021 14:38:32 +0300 you wrote:
> From: Nikolay Aleksandrov <nikolay@nvidia.com>
> 
> Hi,
> This set tries to help with an old ask that we've had for some time
> which is to print nexthop information while monitoring or dumping routes.
> The core problem is that people cannot follow nexthop changes while
> monitoring route changes, by the time they check the nexthop it could be
> deleted or updated to something else. In order to help them out I've
> added a nexthop cache which is populated (only used if -d / show_details
> is specified) while decoding routes and kept up to date while monitoring.
> The nexthop information is printed on its own line starting with the
> "nh_info" attribute and its embedded inside it if printing JSON. To
> cache the nexthop entries I parse them into structures, in order to
> reuse most of the code the print helpers have been altered so they rely
> on prepared structures. Nexthops are now always parsed into a structure,
> even if they won't be cached, that structure is later used to print the
> nexthop and destroyed if not going to be cached. New nexthops (not found
> in the cache) are retrieved from the kernel using a private netlink
> socket so they don't disrupt an ongoing dump, similar to how interfaces
> are retrieved and cached.
> 
> [...]

Here is the summary with links:
  - [iproute2-next,01/12] ip: print_rta_if takes ifindex as device argument instead of attribute
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=f72789965eff
  - [iproute2-next,02/12] ip: export print_rta_gateway version which outputs prepared gateway string
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=371e889da771
  - [iproute2-next,03/12] ip: nexthop: add resilient group structure
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=cfb0a8729ea4
  - [iproute2-next,04/12] ip: nexthop: split print_nh_res_group into parse and print parts
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=60a7515b89ff
  - [iproute2-next,05/12] ip: nexthop: add nh entry structure
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=7ec1cee630e3
  - [iproute2-next,06/12] ip: nexthop: parse attributes into nh entry structure before printing
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=945c26db686b
  - [iproute2-next,07/12] ip: nexthop: factor out print_nexthop's nh entry printing
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=a2ca43121501
  - [iproute2-next,08/12] ip: nexthop: factor out ipnh_get_id rtnl talk into a helper
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=53d7c43bd385
  - [iproute2-next,09/12] ip: nexthop: add cache helpers
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=60a970303288
  - [iproute2-next,10/12] ip: nexthop: add a helper which retrieves and prints cached nh entry
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=cb3d18c29e20
  - [iproute2-next,11/12] ip: route: print and cache detailed nexthop information when requested
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=5d5dc549ce7d
  - [iproute2-next,12/12] ip: nexthop: add print_cache_nexthop which prints and manages the nh cache
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=7ca868a7aa26

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2021-10-04  0:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 11:38 [PATCH iproute2-next 00/12] ip: nexthop: cache nexthops and print routes' nh info Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 01/12] ip: print_rta_if takes ifindex as device argument instead of attribute Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 02/12] ip: export print_rta_gateway version which outputs prepared gateway string Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 03/12] ip: nexthop: add resilient group structure Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 04/12] ip: nexthop: split print_nh_res_group into parse and print parts Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 05/12] ip: nexthop: add nh entry structure Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 06/12] ip: nexthop: parse attributes into nh entry structure before printing Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 07/12] ip: nexthop: factor out print_nexthop's nh entry printing Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 08/12] ip: nexthop: factor out ipnh_get_id rtnl talk into a helper Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 09/12] ip: nexthop: add cache helpers Nikolay Aleksandrov
2021-10-04  0:33   ` David Ahern
2021-10-04  9:03     ` [PATCH iproute2-next] ip: nexthop: keep cache netlink socket open Nikolay Aleksandrov
2021-10-05 14:35       ` David Ahern
2021-09-30 11:38 ` [PATCH iproute2-next 10/12] ip: nexthop: add a helper which retrieves and prints cached nh entry Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 11/12] ip: route: print and cache detailed nexthop information when requested Nikolay Aleksandrov
2021-09-30 11:38 ` [PATCH iproute2-next 12/12] ip: nexthop: add print_cache_nexthop which prints and manages the nh cache Nikolay Aleksandrov
2021-10-04  0:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163330800881.10241.15878981717990557235.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=donaldsharp72@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=idosch@idosch.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.