From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C1FC433EF for ; Tue, 5 Oct 2021 14:02:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1ED1619F5 for ; Tue, 5 Oct 2021 14:02:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B1ED1619F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D80A6EB87; Tue, 5 Oct 2021 14:02:34 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [IPv6:2610:10:20:722:a800:ff:feee:56cf]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F67B6EB8A; Tue, 5 Oct 2021 14:02:33 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 2B42BAA916; Tue, 5 Oct 2021 14:02:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Patchwork To: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org Date: Tue, 05 Oct 2021 14:02:33 -0000 Message-ID: <163344255317.19281.17146218722880828900@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20211004170535.4173-1-ville.syrjala@linux.intel.com> In-Reply-To: <20211004170535.4173-1-ville.syrjala@linux.intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_drm/i915=3A_Improve_DP_link_training_further_=28rev5=29?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: drm/i915: Improve DP link training further (rev5) URL : https://patchwork.freedesktop.org/series/95405/ State : warning == Summary == $ dim checkpatch origin/drm-tip dee501a3511e drm/i915: Tweak the DP "max vswing reached?" condition 94bb4313c0df drm/i915: Show LTTPR in the TPS debug print ddfa1864e7d7 drm/i915: Print the DP vswing adjustment request -:25: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #25: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:349: +#define TRAIN_REQ_VSWING_ARGS(link_status) \ + _TRAIN_REQ_VSWING_ARGS(link_status, 0), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 1), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 2), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 3) -:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'link_status' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:349: +#define TRAIN_REQ_VSWING_ARGS(link_status) \ + _TRAIN_REQ_VSWING_ARGS(link_status, 0), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 1), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 2), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 3) -:31: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #31: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:355: + (drm_dp_get_adjust_request_pre_emphasis((link_status), (lane)) >> DP_TRAIN_PRE_EMPHASIS_SHIFT) -:32: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #32: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:356: +#define TRAIN_REQ_PREEMPH_ARGS(link_status) \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 0), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 1), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 2), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 3) -:32: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'link_status' - possible side-effects? #32: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:356: +#define TRAIN_REQ_PREEMPH_ARGS(link_status) \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 0), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 1), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 2), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 3) total: 2 errors, 1 warnings, 2 checks, 41 lines checked 15ce918cc135 drm/i915: Pimp link training debug prints dbbc7aeca18a drm/i915: Call intel_dp_dump_link_status() for CR failures