From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6131C433EF for ; Tue, 5 Oct 2021 17:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4C1C6121F for ; Tue, 5 Oct 2021 17:17:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236783AbhJERTW (ORCPT ); Tue, 5 Oct 2021 13:19:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:56670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234938AbhJERTU (ORCPT ); Tue, 5 Oct 2021 13:19:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C0406124C; Tue, 5 Oct 2021 17:17:27 +0000 (UTC) From: Catalin Marinas To: linux-arm-kernel@lists.infradead.org, Pingfan Liu Cc: Will Deacon , "Paul E. McKenney" , Thomas Gleixner , linux-kernel@vger.kernel.org, Mark Rutland , Yuichi Ito , Julien Thierry , Marc Zyngier , Joey Gouly , Sami Tolvanen Subject: Re: [PATCHv4 0/3] arm64/irqentry: remove duplicate housekeeping of rcu Date: Tue, 5 Oct 2021 18:17:25 +0100 Message-Id: <163345423700.2001694.5653085141940230637.b4-ty@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211001144406.7719-1-kernelfans@gmail.com> References: <20211001144406.7719-1-kernelfans@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Oct 2021 22:44:03 +0800, Pingfan Liu wrote: > When an IRQ is taken, some accounting needs to be performed to enter and > exit IRQ context around the IRQ handler. Historically arch code would > leave this to the irqchip or core IRQ code, but these days we want this > to happen in exception entry code, and architectures such as arm64 do > this. > > Currently handle_domain_irq() performs this entry/exit accounting, and > if used on an architecture where the entry code also does this, the > entry/exit accounting will be performed twice per IRQ. This is > problematic as core RCU code such as rcu_is_cpu_rrupt_from_idle() > depends on this happening once per IRQ, and will not detect quescent > periods correctly, leading to stall warnings. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional https://git.kernel.org/arm64/c/db795cf55b21 [2/3] arm64: entry: refactor EL1 interrupt entry logic https://git.kernel.org/arm64/c/ad0d5cfb9535 [3/3] arm64: entry: avoid double-accounting IRQ RCU entry https://git.kernel.org/arm64/c/12074b059fdc -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31906C433EF for ; Tue, 5 Oct 2021 17:18:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED08F61381 for ; Tue, 5 Oct 2021 17:18:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED08F61381 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gI340VzJ1p2bbCjfVqhyl6jhIgIzYaE9AJ3EyXy+YnY=; b=FtIEcMgQ3+vEQ5 ZQj8rTfL27XAPOpdLS7i41spIF+Ns8eTViW/80ERLCmWMyPSM1mP1XuCc+t5W7qmzBOfX1TE/kjgI lAAbjurASGtTQ2zxphPLIXVNP/T/4NH4amAKbOGSqyfM6lK1ce8XBwxwHhXASx5vk82nth11h4fnm cSsSgdZeuedvzOv2kbmaxuwnD5SbsPy6UCA6gFSYIjp/8lAJjTtLIk9sSUZA/Fyc8SjN/F+hkzu+Y OTLvHkvBcpfRnr2M3Rmb6qyqNJJdUrYDCc1a3KFT4HMlk3WqILSqXwEmD6XgMWv4HJ7Qr0BJ7G+/o pce7f+8optdfiWZPPPsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXo4M-00BPXy-Mo; Tue, 05 Oct 2021 17:17:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXo4I-00BPXC-E0 for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 17:17:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C0406124C; Tue, 5 Oct 2021 17:17:27 +0000 (UTC) From: Catalin Marinas To: linux-arm-kernel@lists.infradead.org, Pingfan Liu Cc: Will Deacon , "Paul E. McKenney" , Thomas Gleixner , linux-kernel@vger.kernel.org, Mark Rutland , Yuichi Ito , Julien Thierry , Marc Zyngier , Joey Gouly , Sami Tolvanen Subject: Re: [PATCHv4 0/3] arm64/irqentry: remove duplicate housekeeping of rcu Date: Tue, 5 Oct 2021 18:17:25 +0100 Message-Id: <163345423700.2001694.5653085141940230637.b4-ty@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211001144406.7719-1-kernelfans@gmail.com> References: <20211001144406.7719-1-kernelfans@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_101730_507754_86CD890D X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 1 Oct 2021 22:44:03 +0800, Pingfan Liu wrote: > When an IRQ is taken, some accounting needs to be performed to enter and > exit IRQ context around the IRQ handler. Historically arch code would > leave this to the irqchip or core IRQ code, but these days we want this > to happen in exception entry code, and architectures such as arm64 do > this. > > Currently handle_domain_irq() performs this entry/exit accounting, and > if used on an architecture where the entry code also does this, the > entry/exit accounting will be performed twice per IRQ. This is > problematic as core RCU code such as rcu_is_cpu_rrupt_from_idle() > depends on this happening once per IRQ, and will not detect quescent > periods correctly, leading to stall warnings. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional https://git.kernel.org/arm64/c/db795cf55b21 [2/3] arm64: entry: refactor EL1 interrupt entry logic https://git.kernel.org/arm64/c/ad0d5cfb9535 [3/3] arm64: entry: avoid double-accounting IRQ RCU entry https://git.kernel.org/arm64/c/12074b059fdc -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel