From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706DBC433F5 for ; Tue, 5 Oct 2021 22:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 574D86120D for ; Tue, 5 Oct 2021 22:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236895AbhJEWr5 (ORCPT ); Tue, 5 Oct 2021 18:47:57 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:43901 "EHLO mail-ot1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230113AbhJEWry (ORCPT ); Tue, 5 Oct 2021 18:47:54 -0400 Received: by mail-ot1-f52.google.com with SMTP id x33-20020a9d37a4000000b0054733a85462so788134otb.10; Tue, 05 Oct 2021 15:46:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=rXuuVcqlOPGRQ8KPZYAGmcmEqaRdABG3AyDsI/H0JEo=; b=5M97xTMxwA2Hk+SvV7hrgGEpsSeX+QbhQEm4pI4dXQdmZjkrHhb48cwOgvrbMljcN5 mT6w9CHc1L4nqy2I2BHxHHMsRPfJwfSDLpQVVaZzw0H3xh9t7bxozlp48tC6AjNukiW8 go1tv3ekdPSW9vpqSGfoiS8ZJwp2RTjpvMsa6eZTS16JnnCGKwd25AhtzeN0Z8tpRQVW /gLyPpU7hHFwXx32+jWtEBAQgDEeWJG83+7X98+m4+PeLSZEPAQBuDkamia3JFW04aBm MQSDtmnAzBP3ZHPu3S0b74YQirxEdzf3HQG6j9c0xZhmESmXsaXpOoQ+UChrIkrzR49+ 75+w== X-Gm-Message-State: AOAM531hoKhBHOZ4l1OgT75hV7T6i95li3l+u6VQG3clR4Qp1dJFYWtQ rldwlE1BZM/7LdnYr2Ddcg== X-Google-Smtp-Source: ABdhPJxu1yHXCK7JsFPVWCnV3YwQqmVgBcxLJQObQXFkUx2eUkxTxDAYsMRWCskB3IZu70rdOx5wmA== X-Received: by 2002:a9d:72d5:: with SMTP id d21mr17442035otk.181.1633473963274; Tue, 05 Oct 2021 15:46:03 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id i127sm3627476oia.43.2021.10.05.15.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 15:46:02 -0700 (PDT) Received: (nullmailer pid 106785 invoked by uid 1000); Tue, 05 Oct 2021 22:45:59 -0000 From: Rob Herring To: Hector Martin Cc: Mark Kettenis , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Linus Walleij , Philipp Zabel , Marc Zyngier , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Arnd Bergmann , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Rob Herring , Alyssa Rosenzweig In-Reply-To: <20211005155923.173399-2-marcan@marcan.st> References: <20211005155923.173399-1-marcan@marcan.st> <20211005155923.173399-2-marcan@marcan.st> Subject: Re: [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding Date: Tue, 05 Oct 2021 17:45:59 -0500 Message-Id: <1633473959.420655.106783.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Oct 2021 00:59:17 +0900, Hector Martin wrote: > The PMGR block in Apple Silicon SoCs is responsible for SoC power > management. There are two PMGRs in T8103, with different register > layouts but compatible registers. In order to support this as well > as future SoC generations with backwards-compatible registers, we > declare these blocks as syscons and bind to individual registers > in child nodes. Each register controls one SoC device. > > The respective apple compatibles are defined in case device-specific > quirks are necessary in the future, but currently these nodes are > expected to be bound by the generic syscon driver. > > Signed-off-by: Hector Martin > --- > .../bindings/arm/apple/apple,pmgr.yaml | 74 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/arm/apple/apple,pmgr.example.dts:30.40-35.15: ERROR (duplicate_node_names): /example-0/soc/power-management@23b700000: Duplicate node name ERROR: Input tree has errors, aborting (use -f to force output) make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/arm/apple/apple,pmgr.example.dt.yaml] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1441: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1536742 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD850C433F5 for ; Tue, 5 Oct 2021 22:48:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8897061211 for ; Tue, 5 Oct 2021 22:48:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8897061211 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z5L7H91qN0Tnda07iMhJ3mTlV+WLbqttdLitmqAqoDI=; b=rhLpWDYShuXC5L TEj/zg0ol2TaDT2lCk4Q8U+XnlANTf3TYuWmwgmAZlK0b/13jnVsUwc+fubVH+sJ3QISGhqOawl1u 3/GMw+2XBH5pndZ/rA1w3sFA1/RBtS2LZJPh6j7OPfxup+6HV91hIpe4QfXHu+QvtbNUpgU+x4a7W raZ04rd4Pq2uiZzprWLfAif9+AwL22+mU5M1tdmkIsk2rRCUs1BNcBMisji4sqhplgLPCdk3IqRrP vVuizSuFhqssRZ0xzeW9s+rJTtO+nbGXZA6TSWF1Pn5cCoqnFKB2d6a+8XppVlI2BgAHGckkE/les 1PgJnDWV1eQPhIjRRGXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXtCN-00C7y0-Oc; Tue, 05 Oct 2021 22:46:12 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXtCG-00C7ud-6L for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 22:46:08 +0000 Received: by mail-ot1-f48.google.com with SMTP id 77-20020a9d0ed3000000b00546e10e6699so908486otj.2 for ; Tue, 05 Oct 2021 15:46:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=rXuuVcqlOPGRQ8KPZYAGmcmEqaRdABG3AyDsI/H0JEo=; b=whJxdN2/avScC/uEzyIGM46O00oPZ5Y/e3ChDlWKGEwS/tpO16BDZ3qR3s7u0BJW+q QaDHH1REwYompEOvR7edXQRw6pGcEQkWhVXdLt/MfaYKsMb86XCk1bTOMXUOE/lYf23y 2yjQmyTkdKIgPGTrDlkfi4EXracenFsmnn9g+Fen9m8KtFoyE1o5D1e72XolDJeqQdaP td9MwIBz8Lo8bxdWEyJjh80hm3M9DvzfXQnrZ6/637UAeD/SK8QfU8u7JKkFwEKu4UIj 6xo3eMbsqhASzO1pHV2eu4ARE/TLliC2g/oi/UssDWzQfrWGfO6Epa2z7mpGI82MNgbF bmtw== X-Gm-Message-State: AOAM532QWWq3K9ojXfjblIzD45PlT22vrOvMVyy1My6LQRng+TXDFlVv LXOt9gG6CsN70E5FtSWGxQ== X-Google-Smtp-Source: ABdhPJxu1yHXCK7JsFPVWCnV3YwQqmVgBcxLJQObQXFkUx2eUkxTxDAYsMRWCskB3IZu70rdOx5wmA== X-Received: by 2002:a9d:72d5:: with SMTP id d21mr17442035otk.181.1633473963274; Tue, 05 Oct 2021 15:46:03 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id i127sm3627476oia.43.2021.10.05.15.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 15:46:02 -0700 (PDT) Received: (nullmailer pid 106785 invoked by uid 1000); Tue, 05 Oct 2021 22:45:59 -0000 From: Rob Herring To: Hector Martin Cc: Mark Kettenis , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Linus Walleij , Philipp Zabel , Marc Zyngier , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Arnd Bergmann , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Rob Herring , Alyssa Rosenzweig In-Reply-To: <20211005155923.173399-2-marcan@marcan.st> References: <20211005155923.173399-1-marcan@marcan.st> <20211005155923.173399-2-marcan@marcan.st> Subject: Re: [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding Date: Tue, 05 Oct 2021 17:45:59 -0500 Message-Id: <1633473959.420655.106783.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_154604_272856_CC9312C9 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 06 Oct 2021 00:59:17 +0900, Hector Martin wrote: > The PMGR block in Apple Silicon SoCs is responsible for SoC power > management. There are two PMGRs in T8103, with different register > layouts but compatible registers. In order to support this as well > as future SoC generations with backwards-compatible registers, we > declare these blocks as syscons and bind to individual registers > in child nodes. Each register controls one SoC device. > > The respective apple compatibles are defined in case device-specific > quirks are necessary in the future, but currently these nodes are > expected to be bound by the generic syscon driver. > > Signed-off-by: Hector Martin > --- > .../bindings/arm/apple/apple,pmgr.yaml | 74 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/arm/apple/apple,pmgr.example.dts:30.40-35.15: ERROR (duplicate_node_names): /example-0/soc/power-management@23b700000: Duplicate node name ERROR: Input tree has errors, aborting (use -f to force output) make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/arm/apple/apple,pmgr.example.dt.yaml] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1441: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1536742 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel