From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 895DAC433EF for ; Fri, 8 Oct 2021 04:31:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5562060FDC for ; Fri, 8 Oct 2021 04:31:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbhJHEdi (ORCPT ); Fri, 8 Oct 2021 00:33:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:57910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbhJHEdh (ORCPT ); Fri, 8 Oct 2021 00:33:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 033DA60F3A; Fri, 8 Oct 2021 04:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633667503; bh=utkmbRIJp7j/rfAwWkG5g17O9iieLqyGctrPZuR07oU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=qAUKYUF8o2QxOtUmCJZ48ELFKpXhVoh0lmGpW/9Yrizk/L0xmbw2xWVeRq2FEcHFt v2CF9AVbbmsDs6U8M4mOosI6yO5gGQTNAnacbBueWdQErGMgBFJCxh+hobHhc3yP0Y e6bmdQi72UHTMnXyeRBAwxG0mqrluG5ekjkebg9Y2SNybbxxjg1NrcyQgz9UA4vg9T OTaE5JZDQO+ydlV8oOQLsM1prBeI3J/Sen6ncqrRGHWkoEpX2WogMj4zo23wl3gzzT RCpMBsLyR/rAOB+W0pwOG3yR9kMeKB7cqDEqP5rimbX4exKM1wSpm+9dMf4kvsk//i +kLtlDYUDQNFQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210928235635.1348330-6-willmcvicker@google.com> References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-6-willmcvicker@google.com> Subject: Re: [PATCH v2 05/12] clk: export __clk_lookup From: Stephen Boyd Cc: Lee Jones , Geert Uytterhoeven , Saravana Kannan , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org To: Alessandro Zummo , Alexandre Belloni , Catalin Marinas , Chanwoo Choi , John Stultz , Krzysztof Kozlowski , Linus Walleij , Michael Turquette , Russell King , Sylwester Nawrocki , Thomas Gleixner , Tomasz Figa , Will Deacon , Will McVicker Date: Thu, 07 Oct 2021 21:31:41 -0700 Message-ID: <163366750168.2041162.10913803047304286656@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Quoting Will McVicker (2021-09-28 16:56:22) > This symbol is needed to modularize the samsung clk drivers. It's used > to get the clock using the clock name. >=20 > Signed-off-by: Will McVicker > --- > drivers/clk/clk.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 65508eb89ec9..f2aa4b49adfc 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -612,6 +612,7 @@ struct clk *__clk_lookup(const char *name) > =20 > return !core ? NULL : core->hw->clk; > } > +EXPORT_SYMBOL_GPL(__clk_lookup); I'd prefer we deleted this API. Can you make the samsung clk driver stop using it instead? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B3FC433EF for ; Fri, 8 Oct 2021 04:33:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3503F61037 for ; Fri, 8 Oct 2021 04:33:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3503F61037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DHzWcFXuw/xrboMUHDD/moQCsW5RCLtjDvnYHzb7zh0=; b=0DtqVgiqM/2/v2 rMqjvpb555zhGPHn4WcGt9lUmuZKP+5uCYNK0EwQtWjeU5Z96fYDlCKxDGDvcz2+SbyVIYMtgQucq /IO6jFnk6T3FYcOqpDTdRcPDshvTYaaJ6r7seDY8O2FMMobqe0zo6lHdSkOuRH2L34DJmHaaTPsBI 8nrLvvp2MPXS7LP4/2WbJL5Cn4FQt5mir1YiQB4vA5QNYNNUtpKM/1gaIBS7FL1o+lKL9WFvESmkn ZQBLEehobxhOPkvNCFZK+Ur24chFXTSPJ3y5pBoNnlWrHH09ta0l91/WbsHqoImB5dFOoi0fWM4ep wyTJozHUSP8bTPHR75ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYhXv-001ZBF-28; Fri, 08 Oct 2021 04:31:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYhXr-001ZAv-IS for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 04:31:44 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 033DA60F3A; Fri, 8 Oct 2021 04:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633667503; bh=utkmbRIJp7j/rfAwWkG5g17O9iieLqyGctrPZuR07oU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=qAUKYUF8o2QxOtUmCJZ48ELFKpXhVoh0lmGpW/9Yrizk/L0xmbw2xWVeRq2FEcHFt v2CF9AVbbmsDs6U8M4mOosI6yO5gGQTNAnacbBueWdQErGMgBFJCxh+hobHhc3yP0Y e6bmdQi72UHTMnXyeRBAwxG0mqrluG5ekjkebg9Y2SNybbxxjg1NrcyQgz9UA4vg9T OTaE5JZDQO+ydlV8oOQLsM1prBeI3J/Sen6ncqrRGHWkoEpX2WogMj4zo23wl3gzzT RCpMBsLyR/rAOB+W0pwOG3yR9kMeKB7cqDEqP5rimbX4exKM1wSpm+9dMf4kvsk//i +kLtlDYUDQNFQ== MIME-Version: 1.0 In-Reply-To: <20210928235635.1348330-6-willmcvicker@google.com> References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-6-willmcvicker@google.com> Subject: Re: [PATCH v2 05/12] clk: export __clk_lookup From: Stephen Boyd Cc: Lee Jones , Geert Uytterhoeven , Saravana Kannan , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org To: Alessandro Zummo , Alexandre Belloni , Catalin Marinas , Chanwoo Choi , John Stultz , Krzysztof Kozlowski , Linus Walleij , Michael Turquette , Russell King , Sylwester Nawrocki , Thomas Gleixner , Tomasz Figa , Will Deacon , Will McVicker Date: Thu, 07 Oct 2021 21:31:41 -0700 Message-ID: <163366750168.2041162.10913803047304286656@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_213143_668668_0E73A74E X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Will McVicker (2021-09-28 16:56:22) > This symbol is needed to modularize the samsung clk drivers. It's used > to get the clock using the clock name. > > Signed-off-by: Will McVicker > --- > drivers/clk/clk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 65508eb89ec9..f2aa4b49adfc 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -612,6 +612,7 @@ struct clk *__clk_lookup(const char *name) > > return !core ? NULL : core->hw->clk; > } > +EXPORT_SYMBOL_GPL(__clk_lookup); I'd prefer we deleted this API. Can you make the samsung clk driver stop using it instead? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel