From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41AAC433EF for ; Fri, 8 Oct 2021 06:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C0F260551 for ; Fri, 8 Oct 2021 06:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbhJHGKI (ORCPT ); Fri, 8 Oct 2021 02:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbhJHGKF (ORCPT ); Fri, 8 Oct 2021 02:10:05 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D651C061570 for ; Thu, 7 Oct 2021 23:08:10 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id s75so2112084pgs.5 for ; Thu, 07 Oct 2021 23:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=HtNb7Tgg0FX/qljbg4W3bUMaXu11sKsG1sEi11NjGME=; b=o/8tZZV19jXhzpFd9tEL7D7fkf1vyjW/yB5Dt7N8fLIVyceFJ/yMvT7IGDOgEhQRxX IcwoIYrIPzSIGfhdbM2oHhZh/dNVyQyrLPP6qBB53R61AFkn4zvMp7+nHTg9pnWo3Yfy RSdKxJv8TPSSqBI2JLowqewTEyOQcVCIqBomFNLsi9PGEJjEuZq0iJcuA3sKJ1kahumU 7tIx3tRZp1RXOGXWEm7yDlol9saM1HhMXhJth3ibbH+WLR11HCORkISE9KSAzpCW/Z1E SQRKfhQZ3UuqyCD0/ApNOT+YpHngsfxaKuio8XuoYrwOPIYkleECaNEZYyhzFS5tizWH +IfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=HtNb7Tgg0FX/qljbg4W3bUMaXu11sKsG1sEi11NjGME=; b=xMrK3QgOSiOY1VUJtJdRXS6tm+/hhfGSEH8nUE8PcxuIdqN8Qe6Sn6Fk3vBY48ectI VqzYPyvgQofeHfnV9dV77oDf2G8CcuPRUzfPEBMW2WjEgVH7FiiTO3Uj5caeY3/F7eJ7 kcoJ2R2iOm6SDRDrbbwCv5w6EDfwd+nr2MWJdJGfc2VxiKSyS5D/BR1HzMqYBzhAHGOr BGow1V3OvXUOQ+Dqp67hfFQf3WQstBwLbMsU9S31F6lX1N772Req6E9oSWSiGXeb6r90 6CJhTTq8YyzHYOU0nWCyX4OSrlUCTXmnHaMEYpffxag8Q7UdgXECK9uCJEzBv0G6Hwvv gOZQ== X-Gm-Message-State: AOAM533Q/GvzkS3/8B9s22Hnhp+fcqgjxxPmpa3s5h/Yu65D+peOOWzN 6/qkHwOUKljGW89zo1qucXSIvD310qk= X-Google-Smtp-Source: ABdhPJy4hFmQBsdpxbQjO045CgwH00G1/mXtBrpeTnm1jkesnohtpQUh8U1VM0aRpuab29bvHKN1hw== X-Received: by 2002:aa7:9a1d:0:b0:44c:af89:e24 with SMTP id w29-20020aa79a1d000000b0044caf890e24mr8543328pfj.12.1633673290082; Thu, 07 Oct 2021 23:08:10 -0700 (PDT) Received: from bj03382pcu.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id e20sm1291145pfc.11.2021.10.07.23.08.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Oct 2021 23:08:09 -0700 (PDT) From: Huangzhaoyang To: Catalin Marinas , Will Deacon , Mark Rutland , Suzuki K Poulose , Ionela Voinescu , Quentin Perret , Vladimir Murzin , linux-arm-kernel@lists.infradead.org, Zhaoyang Huang , linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: [RFC PATCH] arch: ARM64: add isb before enable pan Date: Fri, 8 Oct 2021 14:07:49 +0800 Message-Id: <1633673269-15048-1-git-send-email-huangzhaoyang@gmail.com> X-Mailer: git-send-email 1.7.9.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhaoyang Huang set_pstate_pan failure is observed in an ARM64 system occasionaly on a reboot test, which can be work around by a msleep on the sw context. We assume suspicious on disorder of previous instr of disabling SW_PAN and add an isb here. PS: The bootup test failed with a invalid TTBR1_EL1 that equals 0x34000000, which is alike racing between on chip PAN and SW_PAN. Signed-off-by: Zhaoyang Huang --- arch/arm64/kernel/cpufeature.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index efed283..3c0de0d 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1663,6 +1663,7 @@ static void cpu_enable_pan(const struct arm64_cpu_capabilities *__unused) WARN_ON_ONCE(in_interrupt()); sysreg_clear_set(sctlr_el1, SCTLR_EL1_SPAN, 0); + isb(); set_pstate_pan(1); } #endif /* CONFIG_ARM64_PAN */ -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8914CC433EF for ; Fri, 8 Oct 2021 06:09:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B4C360FE8 for ; Fri, 8 Oct 2021 06:09:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B4C360FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=zhZBQpj8A3objAGjz8Pezhx888rYorDi8PABwdIcwXw=; b=iCuCbBcoKt3ltB n5l3ct5RMPIfiHaMlrvNoBhNrbYoe5TDIm6MQyMcemJldxrTkz+BrDWV+Pb6m6QMfOrvwZPRZqlWa QDj95+UBEJnq4AjF+TN4jlGye1BYHvQgPZz0juNN9N8rM769+iTmlZ8zvmp+5h23yyXE7kAM/2I52 MvC7SR0v3eUgY3JXqS+oLbKjMvf9MGeETdt/u9538JnYKtNOT4XbXAsWJkZ2jsrgN8bfr07mzYAUQ Ik1SfdfOQ0TScRc6VP6z5jJyb5oEb7y5jx9mdSNd+7YhaqndhIjHbXZ5s3OkqIUgTJuiHa5fqFCZW BGQi8ugpV0M+o74ykeqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYj3H-001gLJ-CG; Fri, 08 Oct 2021 06:08:15 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYj3D-001gKv-T9 for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 06:08:13 +0000 Received: by mail-pf1-x436.google.com with SMTP id s16so7351399pfk.0 for ; Thu, 07 Oct 2021 23:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=HtNb7Tgg0FX/qljbg4W3bUMaXu11sKsG1sEi11NjGME=; b=o/8tZZV19jXhzpFd9tEL7D7fkf1vyjW/yB5Dt7N8fLIVyceFJ/yMvT7IGDOgEhQRxX IcwoIYrIPzSIGfhdbM2oHhZh/dNVyQyrLPP6qBB53R61AFkn4zvMp7+nHTg9pnWo3Yfy RSdKxJv8TPSSqBI2JLowqewTEyOQcVCIqBomFNLsi9PGEJjEuZq0iJcuA3sKJ1kahumU 7tIx3tRZp1RXOGXWEm7yDlol9saM1HhMXhJth3ibbH+WLR11HCORkISE9KSAzpCW/Z1E SQRKfhQZ3UuqyCD0/ApNOT+YpHngsfxaKuio8XuoYrwOPIYkleECaNEZYyhzFS5tizWH +IfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=HtNb7Tgg0FX/qljbg4W3bUMaXu11sKsG1sEi11NjGME=; b=GMVtvxabgMfSCZw3siYPBafowIku8Uft3Dzh1Fya+v1tZUbY4lRBAYhLhxs10AFIDt /uR29syR2UempMfs5i2MdKKAZQFk1JxkIGQE8zRYurGiaPb15EMqndSvNG1MEP2nvY4V 2E3b7wIVFyT2sQFbgi/ZVZs5//oyAUFqmOkNZkK39NJV6RC+oKk017VX9WPGGfrmTZEQ yTtbW98JaXD2GBQkII4Vm5SeuPL6KZJ4BU5ucwyMi5tzu+r+bRs+eKTLAnqOC5LGkDFc qBnSn8TIvxnSzzcC4IlYp5VuIiJJTY22KTsi0VS1qTiH0ygBdu95PeAtulCTmMOqX+2t G4Eg== X-Gm-Message-State: AOAM530mFnOi1WOOvpKw5vuQJYksGuHuTRxvJaCNHE82bAVoaOCn2lE1 RjrrlRhfwTrZgXi5HCme1eE= X-Google-Smtp-Source: ABdhPJy4hFmQBsdpxbQjO045CgwH00G1/mXtBrpeTnm1jkesnohtpQUh8U1VM0aRpuab29bvHKN1hw== X-Received: by 2002:aa7:9a1d:0:b0:44c:af89:e24 with SMTP id w29-20020aa79a1d000000b0044caf890e24mr8543328pfj.12.1633673290082; Thu, 07 Oct 2021 23:08:10 -0700 (PDT) Received: from bj03382pcu.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id e20sm1291145pfc.11.2021.10.07.23.08.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Oct 2021 23:08:09 -0700 (PDT) From: Huangzhaoyang To: Catalin Marinas , Will Deacon , Mark Rutland , Suzuki K Poulose , Ionela Voinescu , Quentin Perret , Vladimir Murzin , linux-arm-kernel@lists.infradead.org, Zhaoyang Huang , linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: [RFC PATCH] arch: ARM64: add isb before enable pan Date: Fri, 8 Oct 2021 14:07:49 +0800 Message-Id: <1633673269-15048-1-git-send-email-huangzhaoyang@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_230812_003678_481BA9B0 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Zhaoyang Huang set_pstate_pan failure is observed in an ARM64 system occasionaly on a reboot test, which can be work around by a msleep on the sw context. We assume suspicious on disorder of previous instr of disabling SW_PAN and add an isb here. PS: The bootup test failed with a invalid TTBR1_EL1 that equals 0x34000000, which is alike racing between on chip PAN and SW_PAN. Signed-off-by: Zhaoyang Huang --- arch/arm64/kernel/cpufeature.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index efed283..3c0de0d 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1663,6 +1663,7 @@ static void cpu_enable_pan(const struct arm64_cpu_capabilities *__unused) WARN_ON_ONCE(in_interrupt()); sysreg_clear_set(sctlr_el1, SCTLR_EL1_SPAN, 0); + isb(); set_pstate_pan(1); } #endif /* CONFIG_ARM64_PAN */ -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel