All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: kvm@vger.kernel.org, Alexandru Elisei <alexandru.elisei@arm.com>,
	julien.thierry.kdev@gmail.com
Cc: catalin.marinas@arm.com, kernel-team@android.com,
	Will Deacon <will@kernel.org>,
	christoffer.dall@arm.com, vivek.gautam@arm.com
Subject: Re: [PATCH kvmtool 00/10] Run kvm-unit-tests with --kernel
Date: Tue, 12 Oct 2021 09:46:54 +0100	[thread overview]
Message-ID: <163402804886.3592955.3123326945963617623.b4-ty@kernel.org> (raw)
In-Reply-To: <20210923144505.60776-1-alexandru.elisei@arm.com>

On Thu, 23 Sep 2021 15:44:55 +0100, Alexandru Elisei wrote:
> What prompted this series (which I really hoped will turn out smaller than
> it did) is my attempt to add support for kvmtool to kvm-unit-tests
> automated test runner [1]. When working through the review comments for
> that series, I realized that kvmtool must be able to load an initrd when
> running a test to get all the features that tests rely on.
> 
> kvm-unit-tests uses the initrd, which is expected to be a text file in the
> format key=value, to pass parameters to a test. The initrd is by default
> generated by the runner script, but the location of a custom initrd file
> can also be set using the environment variable KVM_UNIT_TEST_ENV (many
> thanks to Andrew Jones for explaining that). Contained in the automatically
> generated initrd is information about the presence of certain commits in
> the host kernel.  These commits are important because they fix serious bugs
> in KVM, and running tests which are designed to exercise the fix on systems
> where it isn't present can cause the host kernel to crash. kvm-unit-tests
> calls these bug fixing commits erratas, and their presence is signalled by
> an entry ERRATA_<commit_id>=y in the initrd.
> 
> [...]

Applied patches 1-7, 9 and 10 to kvmtool (master), thanks!

[01/10] builtin-run: Treat specifying both --kernel and --firmware as an error
        https://git.kernel.org/will/kvmtool/c/6810e75ce9e0
[02/10] builtin-run: Warn when ignoring initrd because --firmware was specified
        https://git.kernel.org/will/kvmtool/c/6cbec43ef88d
[03/10] builtin-run: Do not attempt to find vmlinux if --firmware
        https://git.kernel.org/will/kvmtool/c/638630c9f7a3
[04/10] builtin-run: Abstract argument validation into a separate function
        https://git.kernel.org/will/kvmtool/c/cce9616484bd
[05/10] Use kvm->nr_disks instead of kvm->cfg.image_count
        https://git.kernel.org/will/kvmtool/c/39ab3a0b380c
[06/10] builtin-run: Move kernel command line generation to a separate function
        https://git.kernel.org/will/kvmtool/c/a5253f7cc810
[07/10] Add --nodefaults command line argument
        https://git.kernel.org/will/kvmtool/c/5613ae26b998
[09/10] arm64: Use the default offset when the kernel image magic is not found
        https://git.kernel.org/will/kvmtool/c/5303f0964ffd
[10/10] arm64: Be more permissive when parsing the kernel header
        https://git.kernel.org/will/kvmtool/c/dc6646192057

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

      parent reply	other threads:[~2021-10-12  8:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 14:44 [PATCH kvmtool 00/10] Run kvm-unit-tests with --kernel Alexandru Elisei
2021-09-23 14:44 ` [PATCH kvmtool 01/10] builtin-run: Treat specifying both --kernel and --firmware as an error Alexandru Elisei
2021-09-23 14:44 ` [PATCH kvmtool 02/10] builtin-run: Warn when ignoring initrd because --firmware was specified Alexandru Elisei
2021-09-23 14:44 ` [PATCH kvmtool 03/10] builtin-run: Do not attempt to find vmlinux if --firmware Alexandru Elisei
2021-09-23 14:44 ` [PATCH kvmtool 04/10] builtin-run: Abstract argument validation into a separate function Alexandru Elisei
2021-09-23 14:45 ` [PATCH kvmtool 05/10] Use kvm->nr_disks instead of kvm->cfg.image_count Alexandru Elisei
2021-09-23 14:45 ` [PATCH kvmtool 06/10] builtin-run: Move kernel command line generation to a separate function Alexandru Elisei
2021-09-23 14:45 ` [PATCH kvmtool 07/10] Add --nodefaults command line argument Alexandru Elisei
2021-09-23 14:45 ` [PATCH kvmtool 08/10] Add --nocompat option to disable compat warnings Alexandru Elisei
2021-10-12  8:34   ` Will Deacon
2021-10-12 14:24     ` Alexandru Elisei
2021-09-23 14:45 ` [PATCH kvmtool 09/10] arm64: Use the default offset when the kernel image magic is not found Alexandru Elisei
2021-09-23 14:45 ` [PATCH kvmtool 10/10] arm64: Be more permissive when parsing the kernel header Alexandru Elisei
2021-10-12  8:46 ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163402804886.3592955.3123326945963617623.b4-ty@kernel.org \
    --to=will@kernel.org \
    --cc=alexandru.elisei@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kernel-team@android.com \
    --cc=kvm@vger.kernel.org \
    --cc=vivek.gautam@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.