* [PATCH] arm: replace snprintf in show functions with sysfs_emit
@ 2021-10-13 3:22 ` Qing Wang
0 siblings, 0 replies; 2+ messages in thread
From: Qing Wang @ 2021-10-13 3:22 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel; +Cc: Qing Wang
coccicheck complains about the use of snprintf() in sysfs show functions:
WARNING: use scnprintf or sprintf
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: Qing Wang <wangqing@vivo.com>
---
arch/arm/mm/cache-l2x0-pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
index 993fefd..a9bd05b 100644
--- a/arch/arm/mm/cache-l2x0-pmu.c
+++ b/arch/arm/mm/cache-l2x0-pmu.c
@@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
struct l2x0_event_attribute *lattr;
lattr = container_of(attr, typeof(*lattr), attr);
- return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
+ return sysfs_emit(buf, "config=0x%x\n", lattr->config);
}
static umode_t l2x0_pmu_event_attr_is_visible(struct kobject *kobj,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arm: replace snprintf in show functions with sysfs_emit
@ 2021-10-13 3:22 ` Qing Wang
0 siblings, 0 replies; 2+ messages in thread
From: Qing Wang @ 2021-10-13 3:22 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel; +Cc: Qing Wang
coccicheck complains about the use of snprintf() in sysfs show functions:
WARNING: use scnprintf or sprintf
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: Qing Wang <wangqing@vivo.com>
---
arch/arm/mm/cache-l2x0-pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
index 993fefd..a9bd05b 100644
--- a/arch/arm/mm/cache-l2x0-pmu.c
+++ b/arch/arm/mm/cache-l2x0-pmu.c
@@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
struct l2x0_event_attribute *lattr;
lattr = container_of(attr, typeof(*lattr), attr);
- return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
+ return sysfs_emit(buf, "config=0x%x\n", lattr->config);
}
static umode_t l2x0_pmu_event_attr_is_visible(struct kobject *kobj,
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-13 3:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 3:22 [PATCH] arm: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-13 3:22 ` Qing Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.