From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48B42C433EF for ; Wed, 13 Oct 2021 12:59:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CF04610E8 for ; Wed, 13 Oct 2021 12:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233969AbhJMNBh (ORCPT ); Wed, 13 Oct 2021 09:01:37 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:59885 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234117AbhJMNBe (ORCPT ); Wed, 13 Oct 2021 09:01:34 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 49B35580FDD; Wed, 13 Oct 2021 08:59:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 13 Oct 2021 08:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= 791G39jFrJZONJnbSy58yWoM2GVK7lalZlPVC7suoWA=; b=PdxNWxqn6V1R+QuM FoTeKnBfrH6s0tP5doa29y0i6RbYImnGOe2hn4gCvNi9oT7g9IBYmtPx4Spx3WxK UnFDLRWIhgLSVESQeCM4Uc9enYOB3nQHHPzVb9ZIV5r6zTScBBV1GDNEIYoAq/0N UNQ/+EWx4LblqdsAolBZH7kU7azzNeHd+huaSZuMj8ECBDE6Um4CL6PNyxUrK3yB 9WZ9KEf4BDb16CeelzCqBeaqPqxNNQ+GpyBcH0PyKDs0KxsYRtwIcj/aOtw16klJ ynb7TP2KQPnVfs+5nJ5JbrC6XVruaK0qln3MDvyVfLGtt8Y5eKs/pUTJ/puhM0av IFUcOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=791G39jFrJZONJnbSy58yWoM2GVK7lalZlPVC7suo WA=; b=A2f0Lj5g6EBh6vkLa5gGVeld86Ar842tVnzptQ0vzYsbsVsE/0fn6byOX eRe+V3pepi6D9pNyDkdVPzv980QVwvaJdenRMTH3HyeJxjEbfF5VPtWprBuGp3r2 lMviyDpoOQnH1mT+DBz7ryIUdM2srzB8hehbDZwE6OigPsJV4TJMjqvgXgMhlrod 7am3AQgciAKZWBVsIHQriks2m0vL937FuWCgcaN7sem47anIG328CHL6pkhaWkr8 m2aS0ZO+CqWWe4q6KPHG/Thz+xPlc140Ei3k1w5u1aizQ7B3z0VJTKsbmqeCq+kx uB0j42h6u7Md9vp4w/1JIBICFu0Vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejuefggeekfffgueevtddvudffhfejffejjedvvdduudethefhfefhfeeg ieekkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 08:59:30 -0400 (EDT) From: Maxime Ripard To: Maxime Ripard , Maarten Lankhorst , David Airlie , Daniel Vetter , Thomas Zimmermann Cc: Linus Torvalds , linux-rpi-kernel@lists.infradead.org, Florian Fainelli , Mike Turquette , Michael Stapelberg , Nicolas Saenz Julienne , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd Subject: Re: (subset) [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Date: Wed, 13 Oct 2021 14:59:22 +0200 Message-Id: <163412979204.237205.8541013897768601342.b4-ty@cerno.tech> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210922125419.4125779-3-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-3-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, 22 Sep 2021 14:54:16 +0200, Maxime Ripard wrote: > The driver, once it found a divider, tries to round it up by increasing > the least significant bit of the fractional part by one when the > round_up argument is set and there's a remainder. > > However, since it increases the divider it will actually reduce the > clock rate below what we were asking for, leading to issues with > clk_set_min_rate() that will complain that our rounded clock rate is > below the minimum of the rate. > > [...] Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725C5C433F5 for ; Wed, 13 Oct 2021 13:23:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A95760041 for ; Wed, 13 Oct 2021 13:23:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3A95760041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUkDPVNBJ5ylN2KZWZiUeJDlar9ZMslua6LGho/9WpQ=; b=NygA0AgElWelsH VdoK6YbElZZeMo/iDaKF1nd0fjmeU16x6Z6fqvPQd6ZpIqAoo3JhbazFBIoash4TOO85s+wJ6l6Pm A8IkLAC4dybxUQOACWzop5QZUIALPWixWzsB91mtRmjy7SZuDsO+Xy42aYRLvFRwpUmcEoJ/JFMCP WDOprEcv/kW16HSwvIHTdDaYDzLqHi8WaY6LpzXokHfRxKEcLqAShWPBt27GRBEtsechANwf0jcyY W25m/bsERW225XgGJbFRblp5cLLGWBneYosk96LGsdF3j/IdNDYCkFk6qHCZy/L1v6bidCC/CY+Az R40ETcUYI6r+/egtTmQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maeBB-00GqoL-Bc; Wed, 13 Oct 2021 13:20:22 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1madr1-00Gj5E-Vv; Wed, 13 Oct 2021 12:59:33 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 49B35580FDD; Wed, 13 Oct 2021 08:59:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 13 Oct 2021 08:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= 791G39jFrJZONJnbSy58yWoM2GVK7lalZlPVC7suoWA=; b=PdxNWxqn6V1R+QuM FoTeKnBfrH6s0tP5doa29y0i6RbYImnGOe2hn4gCvNi9oT7g9IBYmtPx4Spx3WxK UnFDLRWIhgLSVESQeCM4Uc9enYOB3nQHHPzVb9ZIV5r6zTScBBV1GDNEIYoAq/0N UNQ/+EWx4LblqdsAolBZH7kU7azzNeHd+huaSZuMj8ECBDE6Um4CL6PNyxUrK3yB 9WZ9KEf4BDb16CeelzCqBeaqPqxNNQ+GpyBcH0PyKDs0KxsYRtwIcj/aOtw16klJ ynb7TP2KQPnVfs+5nJ5JbrC6XVruaK0qln3MDvyVfLGtt8Y5eKs/pUTJ/puhM0av IFUcOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=791G39jFrJZONJnbSy58yWoM2GVK7lalZlPVC7suo WA=; b=A2f0Lj5g6EBh6vkLa5gGVeld86Ar842tVnzptQ0vzYsbsVsE/0fn6byOX eRe+V3pepi6D9pNyDkdVPzv980QVwvaJdenRMTH3HyeJxjEbfF5VPtWprBuGp3r2 lMviyDpoOQnH1mT+DBz7ryIUdM2srzB8hehbDZwE6OigPsJV4TJMjqvgXgMhlrod 7am3AQgciAKZWBVsIHQriks2m0vL937FuWCgcaN7sem47anIG328CHL6pkhaWkr8 m2aS0ZO+CqWWe4q6KPHG/Thz+xPlc140Ei3k1w5u1aizQ7B3z0VJTKsbmqeCq+kx uB0j42h6u7Md9vp4w/1JIBICFu0Vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejuefggeekfffgueevtddvudffhfejffejjedvvdduudethefhfefhfeeg ieekkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 08:59:30 -0400 (EDT) From: Maxime Ripard To: Maxime Ripard , Maarten Lankhorst , David Airlie , Daniel Vetter , Thomas Zimmermann Cc: Linus Torvalds , linux-rpi-kernel@lists.infradead.org, Florian Fainelli , Mike Turquette , Michael Stapelberg , Nicolas Saenz Julienne , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd Subject: Re: (subset) [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Date: Wed, 13 Oct 2021 14:59:22 +0200 Message-Id: <163412979204.237205.8541013897768601342.b4-ty@cerno.tech> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210922125419.4125779-3-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-3-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_055932_139598_91F4F812 X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 22 Sep 2021 14:54:16 +0200, Maxime Ripard wrote: > The driver, once it found a divider, tries to round it up by increasing > the least significant bit of the fractional part by one when the > round_up argument is set and there's a remainder. > > However, since it increases the divider it will actually reduce the > clock rate below what we were asking for, leading to issues with > clk_set_min_rate() that will complain that our rounded clock rate is > below the minimum of the rate. > > [...] Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel