From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04390C433EF for ; Thu, 14 Oct 2021 10:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFD0F610CC for ; Thu, 14 Oct 2021 10:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230375AbhJNK2N (ORCPT ); Thu, 14 Oct 2021 06:28:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbhJNK1w (ORCPT ); Thu, 14 Oct 2021 06:27:52 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFC39C06174E; Thu, 14 Oct 2021 03:25:47 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id t11so3842747plq.11; Thu, 14 Oct 2021 03:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KXS2nUcAjz3o0YUh91xZNToPY0k4AGqu28iPxHecA3U=; b=gcsmDTCXikZipwe/mjfYMy0k+t8P0l4//3rPe4+Zt16aO3RzxA9aRKuo7ApV5uSiCl QuPt9Osur8/HV9m+5Z3xeYf3GUzuF7nt01+lPXt7UuG8uN0/zOME9cW6wqdWUkilfUOu C8QsXzsPXoX0TU/IZZH6BxYqSK83rtEruOq0jIb8A7GwctWEXBysx641mxZxgi65b3Xz a9f6fJbaUpKukhPBcaxIpSy9P2qJvCjJCZKHK9p2obv+p1TRWR1EY9VAh81WZSUuHQ9M ekfd+98ZDFeQ/sKnZB+99J4808ui+orAy13ODgRn8GUHWwLcpjVwadffLmfyvU8eMQUU lSfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KXS2nUcAjz3o0YUh91xZNToPY0k4AGqu28iPxHecA3U=; b=kqzisSB5vGU+04v7VvrqZt8FziYQHKcKHYVdx2MYEepCeodoiaKcqm0cSu1yjiPrP8 SWGvtIXPWdtr5Ogj/N6vlx1AJqCGz9dG4yUih2/Wred6UhU951yg5Q33KUoZh1WpbMrx xqXREBo1SU8v6NzXfc9SqN8q+dUrST9F5U8swY6HJC5HMwv8hLQ08KGv6PNEaAGt8DMj OoVKfBDT3CiVNeIH9gqqI/7zMGxny8rqS9rjPTUd8gOzBg0/Tj1lVYwBGRtUQ8uSxhWj qFzLLyTXmQG5CUU+5Ejw5RY3jkOS3FX5Xk4WQ4RO16ZKpTkhVG8DIXu78KJgPFEOTSn5 NwQQ== X-Gm-Message-State: AOAM531dW0gTIMvlcHVnqf66vzvZHdm/+TmHKF41hrSYBh8Jl9nB9Q6F Ou4wTUr5bcpJ9MVQg9SPTx0= X-Google-Smtp-Source: ABdhPJwVDaJUyUEgX1EvPHisAB+vEoDE9e/NrSa6GWYRIx4LR6DrxUimK8nk6LUMtKw6uu0YAJ5yQg== X-Received: by 2002:a17:90b:30d6:: with SMTP id hi22mr19731006pjb.4.1634207147427; Thu, 14 Oct 2021 03:25:47 -0700 (PDT) Received: from fmin-OptiPlex-7060.nreal.work ([137.59.103.165]) by smtp.gmail.com with ESMTPSA id ip10sm2105939pjb.40.2021.10.14.03.25.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Oct 2021 03:25:47 -0700 (PDT) From: dillon.minfei@gmail.com To: mchehab@kernel.org, mchehab+huawei@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@collabora.com, gnurou@gmail.com, pihsun@chromium.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, gabriel.fernandez@st.com, gabriel.fernandez@foss.st.com Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Dillon Min Subject: [PATCH v4 7/8] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell Date: Thu, 14 Oct 2021 18:25:05 +0800 Message-Id: <1634207106-7632-8-git-send-email-dillon.minfei@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1634207106-7632-1-git-send-email-dillon.minfei@gmail.com> References: <1634207106-7632-1-git-send-email-dillon.minfei@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dillon Min stm32's clk driver register two ltdc gate clk to clk core by clk_hw_register_gate() and clk_hw_register_composite() first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver both of them point to the same offset of stm32's RCC register. after kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. stm32f469/746/769 have the same issue, fix it. Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") Signed-off-by: Dillon Min Acked-by: Stephen Boyd Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/ Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDUjqFFwkOeQeFDg@mail.gmail.com/ Signed-off-by: Dillon Min --- v4: no change. drivers/clk/clk-stm32f4.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index af46176ad053..473dfe632cc5 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -129,7 +129,6 @@ static const struct stm32f4_gate_data stm32f429_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, }; static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { @@ -211,7 +210,6 @@ static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, }; static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { @@ -286,7 +284,6 @@ static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, }; static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { @@ -364,7 +361,6 @@ static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, { STM32F4_RCC_APB2ENR, 30, "mdio", "apb2_div" }, }; -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50AC4C433EF for ; Thu, 14 Oct 2021 10:30:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18490610D0 for ; Thu, 14 Oct 2021 10:30:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 18490610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+595KdDFu2KdMVr+6CDtjhZ5L/gZM0hHyNXQoMSxmQ8=; b=zWVA4sS9AqAQhX 1asUX5LrRf8/IzxzHi93lRa4E+emf/nePSwt27fvy9+c55LzTRyQbkmrxiScCGxr9jBpjcjTf+PU2 qDn51TQVmL7jTnLgz+f4qYWG8WgZ1mNXt/mI7GfDEcE94/zrKRLZlZ+H9oGhXiw4KdH33cN6en8e5 Z8rJklOY0iJ7S5cuWgJb5bvGejS6syZ/gq8SWvfogyXKOw8C8dS/WLINaGsN27QRh4PGDPPWQGOAY kZj0lIrRyL2zmY5S5leKh21/1QOIeWfleyQfdjmzdBzVz+rgQBpQFRlydpoxiyLWR4A3lXxd9uqoU AyjJbMP1DE7aU6/GYk9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maxxR-002YxX-TY; Thu, 14 Oct 2021 10:27:30 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maxvo-002YIE-KI for linux-arm-kernel@lists.infradead.org; Thu, 14 Oct 2021 10:25:52 +0000 Received: by mail-pl1-x62f.google.com with SMTP id x8so3850275plv.8 for ; Thu, 14 Oct 2021 03:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KXS2nUcAjz3o0YUh91xZNToPY0k4AGqu28iPxHecA3U=; b=gcsmDTCXikZipwe/mjfYMy0k+t8P0l4//3rPe4+Zt16aO3RzxA9aRKuo7ApV5uSiCl QuPt9Osur8/HV9m+5Z3xeYf3GUzuF7nt01+lPXt7UuG8uN0/zOME9cW6wqdWUkilfUOu C8QsXzsPXoX0TU/IZZH6BxYqSK83rtEruOq0jIb8A7GwctWEXBysx641mxZxgi65b3Xz a9f6fJbaUpKukhPBcaxIpSy9P2qJvCjJCZKHK9p2obv+p1TRWR1EY9VAh81WZSUuHQ9M ekfd+98ZDFeQ/sKnZB+99J4808ui+orAy13ODgRn8GUHWwLcpjVwadffLmfyvU8eMQUU lSfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KXS2nUcAjz3o0YUh91xZNToPY0k4AGqu28iPxHecA3U=; b=pAxbnk4IvmZMj7RByoC+nlXgatQhXqnGMXc9BqhrSGgG/yY0DM5ZICg0Zwj5yUNcdv gVD/UM+snhtKG3hC+p+itnt3oX3h0R64PeMSBjh8Bb6zNyrOgWuyKYHptL187VQzR+ey oek9alC4JJmAQ4yK4gLrdybq8tWOLcR7bZp7Hnb0WJMsgeHKxRMoKuwJr/2IgcC2bLf4 xitSshK5ElAlskpe6S/rl/4bQ8evxssPnMC66OTXOaejjUyxiBpGRvu+xErt3TSusFuf dPz+WCgW0+Hly31X5D6XK1G1l7LgmYWS+gtM7y0q/vzygxvBUd6SzBAufAUa324sf0Vu AKOw== X-Gm-Message-State: AOAM531zqYAmm3lbOMsq2sLb35O1cbbbd6ftytUbrVHZBQa3Y41pO+Qm pbZWnctswCgkWR8H/gyxHnk= X-Google-Smtp-Source: ABdhPJwVDaJUyUEgX1EvPHisAB+vEoDE9e/NrSa6GWYRIx4LR6DrxUimK8nk6LUMtKw6uu0YAJ5yQg== X-Received: by 2002:a17:90b:30d6:: with SMTP id hi22mr19731006pjb.4.1634207147427; Thu, 14 Oct 2021 03:25:47 -0700 (PDT) Received: from fmin-OptiPlex-7060.nreal.work ([137.59.103.165]) by smtp.gmail.com with ESMTPSA id ip10sm2105939pjb.40.2021.10.14.03.25.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Oct 2021 03:25:47 -0700 (PDT) From: dillon.minfei@gmail.com To: mchehab@kernel.org, mchehab+huawei@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@collabora.com, gnurou@gmail.com, pihsun@chromium.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, gabriel.fernandez@st.com, gabriel.fernandez@foss.st.com Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Dillon Min Subject: [PATCH v4 7/8] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell Date: Thu, 14 Oct 2021 18:25:05 +0800 Message-Id: <1634207106-7632-8-git-send-email-dillon.minfei@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1634207106-7632-1-git-send-email-dillon.minfei@gmail.com> References: <1634207106-7632-1-git-send-email-dillon.minfei@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211014_032548_712183_93A1265F X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dillon Min stm32's clk driver register two ltdc gate clk to clk core by clk_hw_register_gate() and clk_hw_register_composite() first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver both of them point to the same offset of stm32's RCC register. after kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. stm32f469/746/769 have the same issue, fix it. Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") Signed-off-by: Dillon Min Acked-by: Stephen Boyd Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/ Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDUjqFFwkOeQeFDg@mail.gmail.com/ Signed-off-by: Dillon Min --- v4: no change. drivers/clk/clk-stm32f4.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index af46176ad053..473dfe632cc5 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -129,7 +129,6 @@ static const struct stm32f4_gate_data stm32f429_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, }; static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { @@ -211,7 +210,6 @@ static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, }; static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { @@ -286,7 +284,6 @@ static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, }; static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { @@ -364,7 +361,6 @@ static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, { STM32F4_RCC_APB2ENR, 30, "mdio", "apb2_div" }, }; -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel