Re: [PATCH] clk-si5341: replace snprintf in show functions with sysfs_emit

From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Qing Wang <wangqing@vivo.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Qing Wang <wangqing@vivo.com>,
	Robert Hancock <robert.hancock@calian.com>
Subject: Re: [PATCH] clk-si5341: replace snprintf in show functions with sysfs_emit
Date: Thu, 14 Oct 2021 18:19:38 -0700	[thread overview]
Message-ID: <163426077803.1688384.13526132296218990684@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1634095574-4076-1-git-send-email-wangqing@vivo.com>

Quoting Qing Wang (2021-10-12 20:26:14)
> coccicheck complains about the use of snprintf() in sysfs show functions.
> 
> Fix the following coccicheck warning:
> drivers/clk/clk-si5341.c:1471:8-16: WARNING: use scnprintf or sprintf.
> drivers/clk/clk-si5341.c:1486:8-16: WARNING: use scnprintf or sprintf.
> drivers/clk/clk-si5341.c:1501:8-16: WARNING: use scnprintf or sprintf.
> drivers/clk/clk-si5341.c:1516:8-16: WARNING: use scnprintf or sprintf.
> 
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> Signed-off-by: Qing Wang <wangqing@vivo.com>

Please include authors on Cc

> ---
>  drivers/clk/clk-si5341.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
> index 57ae183..5d62ddb 100644
> --- a/drivers/clk/clk-si5341.c
> +++ b/drivers/clk/clk-si5341.c
> @@ -1468,7 +1468,7 @@ static ssize_t input_present_show(struct device *dev,
>         if (res < 0)
>                 return res;
>         res = !(status & SI5341_STATUS_LOSREF);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(input_present);
>  
> @@ -1483,7 +1483,7 @@ static ssize_t input_present_sticky_show(struct device *dev,
>         if (res < 0)
>                 return res;
>         res = !(status & SI5341_STATUS_LOSREF);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(input_present_sticky);
>  
> @@ -1498,7 +1498,7 @@ static ssize_t pll_locked_show(struct device *dev,
>         if (res < 0)
>                 return res;
>         res = !(status & SI5341_STATUS_LOL);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(pll_locked);
>  
> @@ -1513,7 +1513,7 @@ static ssize_t pll_locked_sticky_show(struct device *dev,
>         if (res < 0)
>                 return res;
>         res = !(status & SI5341_STATUS_LOL);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(pll_locked_sticky);
>