From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: Re: [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes
Date: Fri, 15 Oct 2021 13:48:00 +0100 [thread overview]
Message-ID: <163430208014.11213.12603150192143954358@Monstersaurus> (raw)
In-Reply-To: <20211012183431.718691-1-niklas.soderlund+renesas@ragnatech.se>
Quoting Niklas Söderlund (2021-10-12 19:34:31)
> The different port@ entries of the adv7482 nodes shall be encapsulated
> in a ports node, add one. This change do not change how the driver
> parses the DT and no driver change is needed.
>
> The change however makes it possible to validate the source files with a
> correct json-schema.
>
Nice to fix up the validation.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 40 +++++++-------
> .../boot/dts/renesas/salvator-common.dtsi | 54 ++++++++++---------
> 2 files changed, 49 insertions(+), 45 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 9c7146084ea1c779..b051e2f3aceb5a17 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -423,37 +423,39 @@ video-receiver@70 {
> compatible = "adi,adv7482";
> reg = <0x70>;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> interrupt-parent = <&gpio0>;
> interrupt-names = "intrq1", "intrq2";
> interrupts = <7 IRQ_TYPE_LEVEL_LOW>,
> <17 IRQ_TYPE_LEVEL_LOW>;
>
> - port@7 {
> - reg = <7>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - adv7482_ain7: endpoint {
> - remote-endpoint = <&cvbs_con>;
> + port@7 {
> + reg = <7>;
> +
> + adv7482_ain7: endpoint {
> + remote-endpoint = <&cvbs_con>;
> + };
> };
> - };
>
> - port@8 {
> - reg = <8>;
> + port@8 {
> + reg = <8>;
>
> - adv7482_hdmi: endpoint {
> - remote-endpoint = <&hdmi_in_con>;
> + adv7482_hdmi: endpoint {
> + remote-endpoint = <&hdmi_in_con>;
> + };
> };
> - };
>
> - port@a {
> - reg = <10>;
> + port@a {
> + reg = <10>;
>
> - adv7482_txa: endpoint {
> - clock-lanes = <0>;
> - data-lanes = <1 2>;
> - remote-endpoint = <&csi40_in>;
> + adv7482_txa: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2>;
> + remote-endpoint = <&csi40_in>;
> + };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index eb1f3b82300b1601..5a55ed7a7efac181 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -524,47 +524,49 @@ video-receiver@70 {
> reg-names = "main", "dpll", "cp", "hdmi", "edid", "repeater",
> "infoframe", "cbus", "cec", "sdp", "txa", "txb" ;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> interrupt-parent = <&gpio6>;
> interrupt-names = "intrq1", "intrq2";
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
> <31 IRQ_TYPE_LEVEL_LOW>;
>
> - port@7 {
> - reg = <7>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - adv7482_ain7: endpoint {
> - remote-endpoint = <&cvbs_con>;
> + port@7 {
> + reg = <7>;
> +
> + adv7482_ain7: endpoint {
> + remote-endpoint = <&cvbs_con>;
> + };
> };
> - };
>
> - port@8 {
> - reg = <8>;
> + port@8 {
> + reg = <8>;
>
> - adv7482_hdmi: endpoint {
> - remote-endpoint = <&hdmi_in_con>;
> + adv7482_hdmi: endpoint {
> + remote-endpoint = <&hdmi_in_con>;
> + };
> };
> - };
>
> - port@a {
> - reg = <10>;
> + port@a {
> + reg = <10>;
>
> - adv7482_txa: endpoint {
> - clock-lanes = <0>;
> - data-lanes = <1 2 3 4>;
> - remote-endpoint = <&csi40_in>;
> + adv7482_txa: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csi40_in>;
> + };
> };
> - };
>
> - port@b {
> - reg = <11>;
> + port@b {
> + reg = <11>;
>
> - adv7482_txb: endpoint {
> - clock-lanes = <0>;
> - data-lanes = <1>;
> - remote-endpoint = <&csi20_in>;
> + adv7482_txb: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + remote-endpoint = <&csi20_in>;
> + };
> };
> };
> };
> --
> 2.33.0
>
prev parent reply other threads:[~2021-10-15 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 18:34 [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes Niklas Söderlund
2021-10-13 14:57 ` Geert Uytterhoeven
2021-10-13 15:55 ` Sergei Shtylyov
2021-10-15 12:48 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163430208014.11213.12603150192143954358@Monstersaurus \
--to=kieran.bingham@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.